From: "Michael S. Tsirkin" <mst@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: eperezma@redhat.com, sebastien.boeuf@intel.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/4] vdpa: Add resume operation
Date: Tue, 18 Oct 2022 02:13:13 -0400 [thread overview]
Message-ID: <20221018021110-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <d017b048-6f40-bd02-5639-03f0526fef5c@oracle.com>
On Mon, Oct 17, 2022 at 05:12:42PM -0700, Si-Wei Liu wrote:
> Hi,
>
> I don't know why but it looks that this series wasn't showing up in the list
> for some reason. Only the recipients in the To or Cc lines seemed able to
> get it. Would it be possible to fix the mail client or include me to the
> thread for review?
>
> Thanks,
> -Siwei
>
This is true! I didn't notice.
https://lore.kernel.org/virtualization/491fb8fe786739958eb9ff3df2250a4188b0bbe5.1665745877.git.sebastien.boeuf@intel.com/
Sebastien the fix is not to Cc Si-Wei - please fix your setup and
repost, confirm the patches are on list. I am not merging patches that
were not on the list.
thanks!
>
> On 10/17/2022 12:19 AM, Jason Wang wrote:
> > On Fri, Oct 14, 2022 at 7:14 PM <sebastien.boeuf@intel.com> wrote:
> > > From: Sebastien Boeuf <sebastien.boeuf@intel.com>
> > >
> > > Add a new operation to allow a vDPA device to be resumed after it has
> > > been suspended. Trying to resume a device that wasn't suspended will
> > > result in a no-op.
> > >
> > > This operation is optional. If it's not implemented, the associated
> > > backend feature bit will not be exposed. And if the feature bit is not
> > > exposed, invoking this operation will return an error.
> > >
> > > Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
> > Acked-by: Jason Wang <jasowang@redhat.com>
> >
> > > ---
> > > include/linux/vdpa.h | 6 +++++-
> > > 1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/include/linux/vdpa.h b/include/linux/vdpa.h
> > > index 6d0f5e4e82c2..96d308cbf97b 100644
> > > --- a/include/linux/vdpa.h
> > > +++ b/include/linux/vdpa.h
> > > @@ -219,7 +219,10 @@ struct vdpa_map_file {
> > > * @reset: Reset device
> > > * @vdev: vdpa device
> > > * Returns integer: success (0) or error (< 0)
> > > - * @suspend: Suspend or resume the device (optional)
> > > + * @suspend: Suspend the device (optional)
> > > + * @vdev: vdpa device
> > > + * Returns integer: success (0) or error (< 0)
> > > + * @resume: Resume the device (optional)
> > > * @vdev: vdpa device
> > > * Returns integer: success (0) or error (< 0)
> > > * @get_config_size: Get the size of the configuration space includes
> > > @@ -324,6 +327,7 @@ struct vdpa_config_ops {
> > > void (*set_status)(struct vdpa_device *vdev, u8 status);
> > > int (*reset)(struct vdpa_device *vdev);
> > > int (*suspend)(struct vdpa_device *vdev);
> > > + int (*resume)(struct vdpa_device *vdev);
> > > size_t (*get_config_size)(struct vdpa_device *vdev);
> > > void (*get_config)(struct vdpa_device *vdev, unsigned int offset,
> > > void *buf, unsigned int len);
> > > --
> > > 2.34.1
> > >
> > > ---------------------------------------------------------------------
> > > Intel Corporation SAS (French simplified joint stock company)
> > > Registered headquarters: "Les Montalets"- 2, rue de Paris,
> > > 92196 Meudon Cedex, France
> > > Registration Number: 302 456 199 R.C.S. NANTERRE
> > > Capital: 5 208 026.16 Euros
> > >
> > > This e-mail and any attachments may contain confidential material for
> > > the sole use of the intended recipient(s). Any review or distribution
> > > by others is strictly prohibited. If you are not the intended
> > > recipient, please contact the sender and delete all copies.
> > >
> > _______________________________________________
> > Virtualization mailing list
> > Virtualization@lists.linux-foundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/virtualization
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-10-18 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1665745877.git.sebastien.boeuf@intel.com>
[not found] ` <491fb8fe786739958eb9ff3df2250a4188b0bbe5.1665745877.git.sebastien.boeuf@intel.com>
2022-10-17 7:19 ` [PATCH v2 1/4] vdpa: Add resume operation Jason Wang
2022-10-18 0:12 ` Si-Wei Liu
2022-10-18 6:13 ` Michael S. Tsirkin [this message]
[not found] ` <df57ddc44ed8950dc79c63597e3091b1da551959.1665745877.git.sebastien.boeuf@intel.com>
2022-10-17 7:20 ` [PATCH v2 2/4] vhost-vdpa: Introduce RESUME backend feature bit Jason Wang
[not found] ` <d23b16abdc15f5e2aa1430cf48101dd256638809.1665745877.git.sebastien.boeuf@intel.com>
2022-10-17 7:22 ` [PATCH v2 3/4] vhost-vdpa: uAPI to resume the device Jason Wang
[not found] ` <bdbf1921652c93e372b1e283cd9367a9b5f31447.1665745877.git.sebastien.boeuf@intel.com>
2022-10-17 7:26 ` [PATCH v2 4/4] vdpa_sim: Implement resume vdpa op Jason Wang
[not found] ` <2f9a1b3a32d35ab6c40a87fe158f55430ebeb2e2.camel@intel.com>
[not found] ` <CAJaqyWeLi+mmOFi8-+65XwurFbBcAnCe5XFKjQ=4Gbo4hwhdUw@mail.gmail.com>
[not found] ` <82ae5fc04bb24019c27552a9cc8a973919f1088d.camel@intel.com>
2022-10-18 6:14 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221018021110-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=sebastien.boeuf@intel.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).