From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E853DC4332F for ; Mon, 19 Dec 2022 06:20:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 73A3781348; Mon, 19 Dec 2022 06:20:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 73A3781348 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EIQQMawc X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OIzHAHJpmBsX; Mon, 19 Dec 2022 06:20:30 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 05F8A81326; Mon, 19 Dec 2022 06:20:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 05F8A81326 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6C82FC0032; Mon, 19 Dec 2022 06:20:29 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id BE304C002D for ; Mon, 19 Dec 2022 06:20:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 67D4D60B15 for ; Mon, 19 Dec 2022 06:20:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 67D4D60B15 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EIQQMawc X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1UO3R7fAcXiO for ; Mon, 19 Dec 2022 06:20:25 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 09164605E0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 09164605E0 for ; Mon, 19 Dec 2022 06:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671430822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nmHgH44YO+1fWxNrpKpYFMutQaCxauHria2kl24sBVY=; b=EIQQMawcymvsd/wGsrEgC5+Ke36gt0lm7uNf3Kjipw9I+WcGpn7u74P6KRySavTzxh1ijR 0LX0WlyII0mdawgIdqtKuVXUVdCpxoqVpxEJvXVLDfNk3YZX3KqMx+BAMAqJTCeWnVJR9i q6RlhXF4hhlOk99Rlr+JvBcG35y/OiQ= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-649-xLa_SNobMiOn6UmPh1i8DA-1; Mon, 19 Dec 2022 01:20:21 -0500 X-MC-Unique: xLa_SNobMiOn6UmPh1i8DA-1 Received: by mail-qv1-f72.google.com with SMTP id q17-20020a056214019100b004b1d3c9f3acso5175400qvr.0 for ; Sun, 18 Dec 2022 22:20:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nmHgH44YO+1fWxNrpKpYFMutQaCxauHria2kl24sBVY=; b=54GVJ4fowaarDXUcdId7IObKh9oKztaienVOgPV6U19OlyeYW+jxjsgz2B7DZBuJiA JI0W+/7SaGrIlfsLi6VIMOKjt5f0RXlKkHdl7dCEKSWAvOYRgUP1TwS9HQ46a/VN7qR6 0nSs4EQxWAoe8L15QyxT4s/EaPhV4OfwCJ4Sp0AvDvgom5Mc89CreJ+BRBS1ATLLA//7 6N+rtYJuSGj3ZEk3uS2TU+4XEin7lCizIRtHUCMTlsFU83T+U6CQ2eZ1ismjmVb2E181 t5rEy9WTZCjGbA3RVTWQd6jLJ0fH8Y2LPtNY4hENEuSbWwng+0ElUDoYzR86b8Mmp6YD g/2Q== X-Gm-Message-State: ANoB5pmSNXki3BsPFZ3P0kvyyLVJLNTXcM2jP6MVu0cVUNfaghEaCFUI 2cs4nIpY4iDzJ6ylAdnmda/SXoyN2KLwjkWOSuVCKq5B0FfRXwWGyvy0NWFKq4Gl9ZbPfVUSjg4 CFazMW2PBKO8v4g8hVJIvdQt/UVcJgDX0Rinzuo+O9w== X-Received: by 2002:a0c:f892:0:b0:4c7:6c12:5db with SMTP id u18-20020a0cf892000000b004c76c1205dbmr55819861qvn.40.1671430821202; Sun, 18 Dec 2022 22:20:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf4o5ruKrZQ3mkYIZlLSnXry7UvegxwMnK9f4SJe6lKY1RpuFh1tICbIL0ZeD2iaMWLDvlXWSA== X-Received: by 2002:a0c:f892:0:b0:4c7:6c12:5db with SMTP id u18-20020a0cf892000000b004c76c1205dbmr55819846qvn.40.1671430820950; Sun, 18 Dec 2022 22:20:20 -0800 (PST) Received: from redhat.com ([45.144.113.29]) by smtp.gmail.com with ESMTPSA id f1-20020a05620a280100b006ee949b8051sm6470263qkp.51.2022.12.18.22.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Dec 2022 22:20:20 -0800 (PST) Date: Mon, 19 Dec 2022 01:20:14 -0500 From: "Michael S. Tsirkin" To: Ricardo =?iso-8859-1?Q?Ca=F1uelo?= Subject: Re: [RESEND PATCH v5 1/1] docs: driver-api: virtio: virtio on Linux Message-ID: <20221219011647-mutt-send-email-mst@kernel.org> References: <20221010064359.1324353-1-ricardo.canuelo@collabora.com> <20221010064359.1324353-2-ricardo.canuelo@collabora.com> <87v8oqsq6k.fsf@rcn-XPS-13-9305.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 In-Reply-To: <87v8oqsq6k.fsf@rcn-XPS-13-9305.i-did-not-set--mail-host-address--so-tickle-me> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: corbet@lwn.net, cohuck@redhat.com, linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org, Bagas Sanjaya , kernel@collabora.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Tue, Oct 11, 2022 at 10:46:43AM +0200, Ricardo Ca=F1uelo wrote: > >> +It's at this stage that the virtqueues will be allocated and configur= ed > >> +by calling the appropriate ``virtio_find`` helper function, such as > >> +virtio_find_single_vq() or virtio_find_vqs(), which will end up > >> +calling a transport-specific ``find_vqs`` method. > >> + > > > > Looks like the wording at the beginning confuses me, so better say: > > > > ---- >8 ---- > > diff --git a/Documentation/driver-api/virtio/virtio.rst b/Documentation= /driver-api/virtio/virtio.rst > > index 07fd2d7c51e689..7947b4ca690efd 100644 > > --- a/Documentation/driver-api/virtio/virtio.rst > > +++ b/Documentation/driver-api/virtio/virtio.rst > > @@ -123,10 +123,10 @@ When the device is registered to the virtio bus t= he kernel will look > > for a driver in the bus that can handle the device and call that > > driver's ``probe`` method. > = > I think this is a matter of style as well, maybe a native speaker can > pitch in about the correctness of it. > = > Cheers, > Ricardo I think I agree with this comment. This seems minor enough so I applied the patch for now. Bagas would you like to post your suggestion as a patch = on top? Would be appreciated. Thanks! -- = MST _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization