From: Bjorn Helgaas <helgaas@kernel.org>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
virtualization@lists.linux-foundation.org
Subject: Re: [RESEND PATCH 1/3] Add SolidRun vendor id
Date: Thu, 29 Dec 2022 13:55:51 -0600 [thread overview]
Message-ID: <20221229195551.GA626165@bhelgaas> (raw)
In-Reply-To: <20221219083511.73205-2-alvaro.karsz@solid-run.com>
Hi Alvaro,
On Mon, Dec 19, 2022 at 10:35:09AM +0200, Alvaro Karsz wrote:
> The vendor id is used in 2 differrent source files,
> the SNET vdpa driver and pci quirks.
s/id/ID/ # both in subject and commit log
s/differrent/different/
s/vdpa/vDPA/ # seems to be the conventional style
s/pci/PCI/
Make the commit log say what this patch does.
> Signed-off-by: Alvaro Karsz <alvaro.karsz@solid-run.com>
With the above and the sorting fix below:
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> include/linux/pci_ids.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index b362d90eb9b..33bbe3160b4 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -3115,4 +3115,6 @@
>
> #define PCI_VENDOR_ID_NCUBE 0x10ff
>
> +#define PCI_VENDOR_ID_SOLIDRUN 0xd063
Move this to the right spot so the file is sorted by vendor ID.
PCI_VENDOR_ID_NCUBE, PCI_VENDOR_ID_OCZ, and PCI_VENDOR_ID_XEN got
added in the wrong place.
> #endif /* _LINUX_PCI_IDS_H */
> --
> 2.32.0
>
> _______________________________________________
> Virtualization mailing list
> Virtualization@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-12-29 19:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 8:35 [RESEND PATCH 0/3] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-19 8:35 ` [RESEND PATCH 1/3] Add SolidRun vendor id Alvaro Karsz
2022-12-29 19:55 ` Bjorn Helgaas [this message]
2022-12-29 21:06 ` Alvaro Karsz
2022-12-29 21:29 ` Bjorn Helgaas
2022-12-29 22:27 ` Michael S. Tsirkin
2022-12-19 8:35 ` [RESEND PATCH 2/3] New PCI quirk for SolidRun SNET DPU Alvaro Karsz
2022-12-29 19:55 ` Bjorn Helgaas
2022-12-19 8:35 ` [PATCH 3/3 v6] virtio: vdpa: new SolidNET DPU driver Alvaro Karsz
2022-12-19 10:43 ` Michael S. Tsirkin
2022-12-19 10:44 ` Michael S. Tsirkin
2022-12-19 10:49 ` Michael S. Tsirkin
2022-12-19 10:55 ` Alvaro Karsz
2022-12-19 11:03 ` Michael S. Tsirkin
2022-12-19 11:32 ` Alvaro Karsz
2022-12-19 16:40 ` Michael S. Tsirkin
2022-12-20 6:50 ` Jason Wang
2022-12-20 7:25 ` Alvaro Karsz
2022-12-20 8:54 ` Jason Wang
[not found] ` <Y6HjpvDfIusAz2uS@dev-arch.thelio-3990X>
2022-12-20 16:46 ` Alvaro Karsz
2022-12-20 21:48 ` Arnd Bergmann
[not found] ` <Y6IfwHicoMojJrIB@dev-arch.thelio-3990X>
2022-12-20 23:20 ` Michael S. Tsirkin
2022-12-21 6:40 ` Michael S. Tsirkin
2022-12-21 7:05 ` Alvaro Karsz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221229195551.GA626165@bhelgaas \
--to=helgaas@kernel.org \
--cc=alvaro.karsz@solid-run.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).