From: Laurent Vivier <lvivier@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: "Cindy Lu" <lulu@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
"Eugenio Pérez" <eperezma@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Gautam Dawar" <gautam.dawar@xilinx.com>,
"Eli Cohen" <elic@nvidia.com>
Subject: [PATCH v2 0/1] virtio_net: vdpa: update MAC address when it is generated by virtio-net
Date: Mon, 23 Jan 2023 13:00:21 +0100 [thread overview]
Message-ID: <20230123120022.2364889-1-lvivier@redhat.com> (raw)
When the MAC address is not provided by the vdpa device virtio_net
driver assigns a random one without notifying the device.
The consequence, in the case of mlx5_vdpa, is the internal routing
tables of the device are not updated and this can block the
communication between two namespaces.
To fix this problem, use virtnet_send_command(VIRTIO_NET_CTRL_MAC)
to set the address from virtnet_probe() when the MAC address is
not provided by the device.
v2:
- remove vdpa_sim related fixes
- check virtio_has_feature(vdev, VIRTIO_NET_F_MAC) rather than
addr_assign_type
Laurent Vivier (1):
virtio_net: notify MAC address change on device initialization
drivers/net/virtio_net.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
--
2.39.0
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next reply other threads:[~2023-01-23 12:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 12:00 Laurent Vivier [this message]
2023-01-23 12:00 ` [PATCH v2 1/1] virtio_net: notify MAC address change on device initialization Laurent Vivier
2023-01-24 10:15 ` Michael S. Tsirkin
2023-01-24 11:04 ` Laurent Vivier
2023-01-27 11:08 ` Michael S. Tsirkin
2023-01-27 12:28 ` Laurent Vivier
2023-01-27 14:53 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230123120022.2364889-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=davem@davemloft.net \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gautam.dawar@xilinx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).