* Re: [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails [not found] <772e9fe133f21fa78fb98a2ebe8969efbbd58e3c.camel@gmail.com> @ 2022-12-28 6:58 ` Jason Wang 2022-12-29 4:25 ` Zhu, Lingshan 2023-01-27 10:37 ` Michael S. Tsirkin 1 sibling, 1 reply; 3+ messages in thread From: Jason Wang @ 2022-12-28 6:58 UTC (permalink / raw) To: Tanmay Bhushan; +Cc: virtualization, linux-kernel, Michael S. Tsirkin On Wed, Dec 28, 2022 at 5:15 AM Tanmay Bhushan <007047221b@gmail.com> wrote: > > From 7eae04667ddaac8baa4812d48ef2c942cedef946 Mon Sep 17 00:00:00 2001 > From: Tanmay Bhushan <007047221b@gmail.com> > Date: Tue, 27 Dec 2022 22:02:16 +0100 > Subject: [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails > > ifcvf_mgmt_dev leaks memory if it is not freed before > returning. Call is made to correct return statement > so memory does not leak. ifcvf_init_hw does not take > care of this so it is needed to do it here. > > Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> Acked-by: Jason Wang <jasowang@redhat.com> Thanks > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c > b/drivers/vdpa/ifcvf/ifcvf_main.c > index f9c0044c6442..44b29289aa19 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -849,7 +849,7 @@ static int ifcvf_probe(struct pci_dev *pdev, const > struct pci_device_id *id) > ret = ifcvf_init_hw(vf, pdev); > if (ret) { > IFCVF_ERR(pdev, "Failed to init IFCVF hw\n"); > - return ret; > + goto err; > } > > for (i = 0; i < vf->nr_vring; i++) > -- > 2.34.1 > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails 2022-12-28 6:58 ` [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails Jason Wang @ 2022-12-29 4:25 ` Zhu, Lingshan 0 siblings, 0 replies; 3+ messages in thread From: Zhu, Lingshan @ 2022-12-29 4:25 UTC (permalink / raw) To: Jason Wang, Tanmay Bhushan Cc: virtualization, linux-kernel, Michael S. Tsirkin On 12/28/2022 2:58 PM, Jason Wang wrote: > On Wed, Dec 28, 2022 at 5:15 AM Tanmay Bhushan <007047221b@gmail.com> wrote: >> From 7eae04667ddaac8baa4812d48ef2c942cedef946 Mon Sep 17 00:00:00 2001 >> From: Tanmay Bhushan <007047221b@gmail.com> >> Date: Tue, 27 Dec 2022 22:02:16 +0100 >> Subject: [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails >> >> ifcvf_mgmt_dev leaks memory if it is not freed before >> returning. Call is made to correct return statement >> so memory does not leak. ifcvf_init_hw does not take >> care of this so it is needed to do it here. >> >> Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> > Acked-by: Jason Wang <jasowang@redhat.com> > > Thanks Acked-by: Zhu Lingshan <lingshan.zhu@intel.com> Thanks > >> --- >> drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c >> b/drivers/vdpa/ifcvf/ifcvf_main.c >> index f9c0044c6442..44b29289aa19 100644 >> --- a/drivers/vdpa/ifcvf/ifcvf_main.c >> +++ b/drivers/vdpa/ifcvf/ifcvf_main.c >> @@ -849,7 +849,7 @@ static int ifcvf_probe(struct pci_dev *pdev, const >> struct pci_device_id *id) >> ret = ifcvf_init_hw(vf, pdev); >> if (ret) { >> IFCVF_ERR(pdev, "Failed to init IFCVF hw\n"); >> - return ret; >> + goto err; >> } >> >> for (i = 0; i < vf->nr_vring; i++) >> -- >> 2.34.1 >> >> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails [not found] <772e9fe133f21fa78fb98a2ebe8969efbbd58e3c.camel@gmail.com> 2022-12-28 6:58 ` [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails Jason Wang @ 2023-01-27 10:37 ` Michael S. Tsirkin 1 sibling, 0 replies; 3+ messages in thread From: Michael S. Tsirkin @ 2023-01-27 10:37 UTC (permalink / raw) To: Tanmay Bhushan; +Cc: linux-kernel, virtualization On Tue, Dec 27, 2022 at 10:15:25PM +0100, Tanmay Bhushan wrote: > >From 7eae04667ddaac8baa4812d48ef2c942cedef946 Mon Sep 17 00:00:00 2001 > From: Tanmay Bhushan <007047221b@gmail.com> > Date: Tue, 27 Dec 2022 22:02:16 +0100 > Subject: [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails > > ifcvf_mgmt_dev leaks memory if it is not freed before > returning. Call is made to correct return statement > so memory does not leak. ifcvf_init_hw does not take > care of this so it is needed to do it here. > > Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> > --- > drivers/vdpa/ifcvf/ifcvf_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c > b/drivers/vdpa/ifcvf/ifcvf_main.c > index f9c0044c6442..44b29289aa19 100644 > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > @@ -849,7 +849,7 @@ static int ifcvf_probe(struct pci_dev *pdev, const > struct pci_device_id *id) BTW your patch was mangled but I fixed it. > ret = ifcvf_init_hw(vf, pdev); > if (ret) { > IFCVF_ERR(pdev, "Failed to init IFCVF hw\n"); > - return ret; > + goto err; > } > > for (i = 0; i < vf->nr_vring; i++) > -- > 2.34.1 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-27 10:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <772e9fe133f21fa78fb98a2ebe8969efbbd58e3c.camel@gmail.com>
2022-12-28 6:58 ` [PATCH] vdpa: ifcvf: Do proper cleanup if IFCVF init fails Jason Wang
2022-12-29 4:25 ` Zhu, Lingshan
2023-01-27 10:37 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).