From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>, Arnd Bergmann <arnd@arndb.de>,
Amit Shah <amit@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
elena.reshetova@intel.com, kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v1 2/6] virtio console: Harden port adding
Date: Fri, 27 Jan 2023 07:12:52 -0500 [thread overview]
Message-ID: <20230127071152-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <87k018p4xs.fsf@ubik.fi.intel.com>
On Fri, Jan 27, 2023 at 01:55:43PM +0200, Alexander Shishkin wrote:
> "Michael S. Tsirkin" <mst@redhat.com> writes:
>
> > On Thu, Jan 19, 2023 at 10:13:18PM +0200, Alexander Shishkin wrote:
> >> When handling control messages, instead of peeking at the device memory
> >> to obtain bits of the control structure,
> >
> > Except the message makes it seem that we are getting data from
> > device memory, when we do nothing of the kind.
>
> We can be, see below.
>
> >> take a snapshot of it once and
> >> use it instead, to prevent it from changing under us. This avoids races
> >> between port id validation and control event decoding, which can lead
> >> to, for example, a NULL dereference in port removal of a nonexistent
> >> port.
> >>
> >> The control structure is small enough (8 bytes) that it can be cached
> >> directly on the stack.
> >
> > I still have no real idea why we want a copy here.
> > If device can poke anywhere at memory then it can crash kernel anyway.
> > If there's a bounce buffer or an iommu or some other protection
> > in place, then this memory can no longer change by the time
> > we look at it.
>
> We can have shared pages between the host and guest without bounce
> buffers in between, so they can be both looking directly at the same
> page.
>
> Regards,
How does this configuration work? What else is in this page?
> --
> Alex
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-27 12:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230119135721.83345-1-alexander.shishkin@linux.intel.com>
[not found] ` <20230119135721.83345-3-alexander.shishkin@linux.intel.com>
2023-01-19 15:20 ` [PATCH v1 2/6] virtio console: Harden port adding Greg Kroah-Hartman
[not found] ` <87ilh2quto.fsf@ubik.fi.intel.com>
2023-01-19 18:57 ` Greg Kroah-Hartman
[not found] ` <87a62eqo4h.fsf@ubik.fi.intel.com>
2023-01-20 7:15 ` Greg Kroah-Hartman
2023-01-27 11:02 ` Michael S. Tsirkin
[not found] ` <87k018p4xs.fsf@ubik.fi.intel.com>
2023-01-27 12:12 ` Michael S. Tsirkin [this message]
[not found] ` <87edrgp2is.fsf@ubik.fi.intel.com>
2023-01-27 13:31 ` Greg Kroah-Hartman
[not found] ` <87bkmkoyd1.fsf@ubik.fi.intel.com>
2023-01-27 14:37 ` Greg Kroah-Hartman
2023-01-27 14:46 ` Michael S. Tsirkin
2023-01-27 13:52 ` Michael S. Tsirkin
2023-01-20 12:59 ` Michael S. Tsirkin
[not found] ` <20230119135721.83345-5-alexander.shishkin@linux.intel.com>
2023-01-19 15:22 ` [PATCH v1 4/6] virtio console: Harden control message handling Greg Kroah-Hartman
2023-01-20 12:45 ` Michael S. Tsirkin
[not found] ` <87y1pxp39k.fsf@ubik.fi.intel.com>
2023-01-27 10:58 ` Michael S. Tsirkin
2023-01-20 11:55 ` [PATCH v1 0/6] Harden a few virtio bits Michael S. Tsirkin
[not found] ` <877cxhqtdi.fsf@ubik.fi.intel.com>
2023-01-20 12:40 ` Michael S. Tsirkin
[not found] ` <20230119135721.83345-4-alexander.shishkin@linux.intel.com>
2023-01-20 12:54 ` [PATCH v1 3/6] virtio 9p: Fix an overflow Michael S. Tsirkin
[not found] ` <20230119135721.83345-7-alexander.shishkin@linux.intel.com>
2023-01-20 12:56 ` [PATCH v1 6/6] virtio_ring: Prevent bounds check bypass on descriptor index Michael S. Tsirkin
[not found] ` <20230119135721.83345-2-alexander.shishkin@linux.intel.com>
2023-01-19 15:17 ` [PATCH v1 1/6] virtio console: Harden multiport against invalid host input Greg Kroah-Hartman
[not found] ` <87fsc6qrvx.fsf@ubik.fi.intel.com>
2023-01-19 19:18 ` Greg Kroah-Hartman
2023-01-20 13:01 ` Michael S. Tsirkin
[not found] ` <20230119135721.83345-6-alexander.shishkin@linux.intel.com>
2023-01-20 13:09 ` [PATCH v1 5/6] virtio_net: Guard against buffer length overflow in xdp_linearize_page() Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127071152-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).