From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Auger <eric.auger@redhat.com>
Cc: lvivier@redhat.com, kvm@vger.kernel.org, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
eric.auger.pro@gmail.com
Subject: Re: [PATCH 0/2] vhost/net: Clear the pending messages when the backend is removed
Date: Sun, 29 Jan 2023 17:33:23 -0500 [thread overview]
Message-ID: <20230129173240-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <3fe5971a-5991-488f-cef5-473c9faa1ba1@redhat.com>
On Sun, Jan 29, 2023 at 06:58:09PM +0100, Eric Auger wrote:
> Hi,
>
> On 1/17/23 16:15, Eric Auger wrote:
> > When the vhost iotlb is used along with a guest virtual iommu
> > and the guest gets rebooted, some MISS messages may have been
> > recorded just before the reboot and spuriously executed by
> > the virtual iommu after the reboot. This is due to the fact
> > the pending messages are not cleared.
> >
> > As vhost does not have any explicit reset user API,
> > VHOST_NET_SET_BACKEND looks a reasonable point where to clear
> > the pending messages, in case the backend is removed (fd = -1).
> >
> > This version is a follow-up on the discussions held in [1].
> >
> > The first patch removes an unused 'enabled' parameter in
> > vhost_init_device_iotlb().
>
> Gentle Ping. Does it look a reasonable fix now?
>
> Thanks
>
> Eric
Yes I applied this - giving it a bit of time in next.
> >
> > Best Regards
> >
> > Eric
> >
> > History:
> > [1] RFC: [RFC] vhost: Clear the pending messages on vhost_init_device_iotlb()
> > https://lore.kernel.org/all/20221107203431.368306-1-eric.auger@redhat.com/
> >
> > Eric Auger (2):
> > vhost: Remove the enabled parameter from vhost_init_device_iotlb
> > vhost/net: Clear the pending messages when the backend is removed
> >
> > drivers/vhost/net.c | 5 ++++-
> > drivers/vhost/vhost.c | 5 +++--
> > drivers/vhost/vhost.h | 3 ++-
> > 3 files changed, 9 insertions(+), 4 deletions(-)
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2023-01-29 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 15:15 [PATCH 0/2] vhost/net: Clear the pending messages when the backend is removed Eric Auger
2023-01-17 15:15 ` [PATCH 1/2] vhost: Remove the enabled parameter from vhost_init_device_iotlb Eric Auger
2023-01-17 15:15 ` [PATCH 2/2] vhost/net: Clear the pending messages when the backend is removed Eric Auger
2023-01-29 17:58 ` [PATCH 0/2] " Eric Auger
2023-01-29 22:33 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230129173240-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).