virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yongji Xie <xieyongji@bytedance.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Christoph Hellwig <hch@lst.de>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2 01/11] genirq/affinity:: Export irq_create_affinity_masks()
Date: Mon, 13 Feb 2023 06:59:39 -0500	[thread overview]
Message-ID: <20230213065116-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACycT3u=vULuZ9-ZakBjxmbu88iUb+xB2mHJUnHA_8SuUV7H4w@mail.gmail.com>

On Mon, Jan 30, 2023 at 07:53:55PM +0800, Yongji Xie wrote:
> On Fri, Jan 27, 2023 at 4:22 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Mon, Dec 19, 2022 at 05:36:02PM +0800, Yongji Xie wrote:
> > > On Mon, Dec 19, 2022 at 3:33 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> > > >
> > > > On Mon, Dec 05, 2022 at 04:41:17PM +0800, Xie Yongji wrote:
> > > > > Export irq_create_affinity_masks() so that some modules
> > > > > can make use of it to implement interrupt affinity
> > > > > spreading mechanism.
> > > > >
> > > > > Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> > > >
> > > > So this got nacked, what's the plan now?
> > > >
> > >
> > > I‘d like to check with Christoph again first.
> > >
> > > Hi Christoph,
> > >
> > > Jason will post some patches to get rid of the DMA API for vDPA
> > > simulators. And the irq affinity algorithm is independent of the IRQ
> > > subsystem IIUC. So could you allow this patch so that we can reuse the
> > > algorithm to select the best CPU (per-cpu affinity if possible, or at
> > > least per-node) to run the virtqueue's irq callback.
> > >
> > > Thanks,
> > > Yongji
> >
> > I think you need to explain why you are building low level
> > affinity masks.
> 
> In VDUSE case, we use workqueue to run the virtqueue's irq callback.
> Now I want to queue the irq callback kwork to one specific CPU to get
> per-cpu affinity if possible, or at least per-node. So I need to use
> this function to build the low level affinity masks for each
> virtqueue.
> 
> > what's the plan now?
> >
> 
> If there is no objection, I'll post a new version.
> 
> Thanks,
> Yongji

I doubt you made a convicing case here - I think Christoph was saying if
it is not an irq it should not use an irq affinity API.
So a new API possibly sharing implementation with irq affinity
is called for then? Maybe.


-- 
MST

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2023-02-13 11:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221205084127.535-1-xieyongji@bytedance.com>
     [not found] ` <20221205084127.535-3-xieyongji@bytedance.com>
2022-12-16  3:52   ` [PATCH v2 02/11] vdpa: Add set/get_vq_affinity callbacks in vdpa_config_ops Jason Wang
     [not found] ` <20221205084127.535-4-xieyongji@bytedance.com>
2022-12-16  3:58   ` [PATCH v2 03/11] vdpa: Add set_irq_affinity callback " Jason Wang
     [not found]     ` <CACycT3u237c2jHaYeoPQoXK1eb4FDOJJcc6_21N3m=aBHsDwFg@mail.gmail.com>
2022-12-19  6:06       ` Jason Wang
     [not found]         ` <CACycT3t1AVyDjZ-HzWPHxfhur=hh9aYW3=Fp7ML8YieBbwDa+Q@mail.gmail.com>
2022-12-20  6:31           ` Jason Wang
     [not found]             ` <CACycT3vP42dpq5NXFJ-Qua=MKsW9visq+mykS7H6i9gUcqo4NQ@mail.gmail.com>
2022-12-21  3:20               ` Jason Wang
     [not found] ` <20221205084127.535-5-xieyongji@bytedance.com>
2022-12-16  3:59   ` [PATCH v2 04/11] vduse: Refactor allocation for vduse virtqueues Jason Wang
     [not found] ` <20221205084127.535-6-xieyongji@bytedance.com>
2022-12-16  4:02   ` [PATCH v2 05/11] vduse: Introduce bound workqueue for irq injection Jason Wang
     [not found]     ` <CACycT3tyR0zTfTgE3BhL0GZqWAj2KDC0Q+tfm+rV=wbgHPOhFA@mail.gmail.com>
2022-12-20  6:27       ` Jason Wang
     [not found]         ` <CACycT3vMktY1g57NhRMnAD0_F45MxpM=730reN-U_qqaN=daDg@mail.gmail.com>
2022-12-21  3:19           ` Jason Wang
     [not found] ` <20221205085846.741-1-xieyongji@bytedance.com>
2022-12-16  5:30   ` [PATCH v2 06/11] vduse: Support automatic irq callback affinity Jason Wang
     [not found]     ` <CACycT3vu0_xCG7SvdP-zkZkuOGdudx2apOwi3CZ4MOFSe-XAFg@mail.gmail.com>
2022-12-20  6:32       ` Jason Wang
     [not found] ` <20221205090243.791-1-xieyongji@bytedance.com>
     [not found]   ` <20221205090243.791-2-xieyongji@bytedance.com>
2022-12-16  5:35     ` [PATCH v2 08/11] vduse: Add sysfs interface for " Jason Wang
     [not found]       ` <CACycT3sGf9-zvR_XGEJuPVQhLSp4zsiO1x7RZ5KHBKbE5Deu2Q@mail.gmail.com>
2022-12-20  6:29         ` Jason Wang
     [not found]   ` <20221205090243.791-3-xieyongji@bytedance.com>
2022-12-16  5:43     ` [PATCH v2 09/11] vduse: Add enable_irq_wq sysfs interface for virtqueues Jason Wang
     [not found]   ` <20221205090243.791-4-xieyongji@bytedance.com>
2022-12-16  5:49     ` [PATCH v2 10/11] vduse: Delay iova domain creation Jason Wang
     [not found]   ` <20221205090243.791-5-xieyongji@bytedance.com>
2022-12-16  6:02     ` [PATCH v2 11/11] vduse: Support specifying bounce buffer size via sysfs Jason Wang
     [not found] ` <20221205084127.535-2-xieyongji@bytedance.com>
2022-12-06  8:18   ` [PATCH v2 01/11] genirq/affinity:: Export irq_create_affinity_masks() Christoph Hellwig
     [not found]     ` <CACycT3sXHGQt_V=rgwvEv4v8+oUaAOu1T=tWrKePdybMHagzng@mail.gmail.com>
2022-12-06  8:47       ` Christoph Hellwig
     [not found]         ` <CACycT3uk4FCswFj8VqqPDgdEM73iqMnYSL8j6DYxCiy1FNSvHQ@mail.gmail.com>
2022-12-07  5:56           ` Jason Wang
2022-12-19  7:33   ` Michael S. Tsirkin
     [not found]     ` <CACycT3utDJFZtWzqCUXJaqRjkCXPMTAi+VJd3g6dw25vWqaduw@mail.gmail.com>
2023-01-27  8:22       ` Michael S. Tsirkin
     [not found]         ` <CACycT3u=vULuZ9-ZakBjxmbu88iUb+xB2mHJUnHA_8SuUV7H4w@mail.gmail.com>
2023-02-13 11:59           ` Michael S. Tsirkin [this message]
     [not found]             ` <CACycT3uY1dfP=5d1go+POh7-J1tUMW+9RXi92KtcFJYMzq-bOQ@mail.gmail.com>
2023-02-13 18:53               ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230213065116-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xieyongji@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).