* Re: [PATCH 2/2] vdpa/mlx5: Initialize CVQ iotlb spinlock [not found] <20230206122016.1149373-1-elic@nvidia.com> @ 2023-02-13 12:19 ` Michael S. Tsirkin [not found] ` <570ab4b9-eed7-3c5a-400a-261a9a205b4f@nvidia.com> 0 siblings, 1 reply; 2+ messages in thread From: Michael S. Tsirkin @ 2023-02-13 12:19 UTC (permalink / raw) To: Eli Cohen; +Cc: eperezma, linux-kernel, virtualization On Mon, Feb 06, 2023 at 02:20:16PM +0200, Eli Cohen wrote: > Initialize itolb spinlock. > > Fixes: 5262912ef3cf ("vdpa/mlx5: Add support for control VQ and MAC setting") > Signed-off-by: Eli Cohen <elic@nvidia.com> threading was broken here but whatevs. > --- > drivers/vdpa/mlx5/core/resources.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/vdpa/mlx5/core/resources.c b/drivers/vdpa/mlx5/core/resources.c > index 45ad41287a31..d5a59c9035fb 100644 > --- a/drivers/vdpa/mlx5/core/resources.c > +++ b/drivers/vdpa/mlx5/core/resources.c > @@ -233,6 +233,7 @@ static int init_ctrl_vq(struct mlx5_vdpa_dev *mvdev) > if (!mvdev->cvq.iotlb) > return -ENOMEM; > > + spin_lock_init(&mvdev->cvq.iommu_lock); > vringh_set_iotlb(&mvdev->cvq.vring, mvdev->cvq.iotlb, &mvdev->cvq.iommu_lock); > > return 0; > -- > 2.38.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
[parent not found: <570ab4b9-eed7-3c5a-400a-261a9a205b4f@nvidia.com>]
* Re: [PATCH 2/2] vdpa/mlx5: Initialize CVQ iotlb spinlock [not found] ` <570ab4b9-eed7-3c5a-400a-261a9a205b4f@nvidia.com> @ 2023-02-13 12:26 ` Michael S. Tsirkin 0 siblings, 0 replies; 2+ messages in thread From: Michael S. Tsirkin @ 2023-02-13 12:26 UTC (permalink / raw) To: Eli Cohen; +Cc: eperezma, linux-kernel, virtualization On Mon, Feb 13, 2023 at 02:24:40PM +0200, Eli Cohen wrote: > > On 13/02/2023 14:19, Michael S. Tsirkin wrote: > > On Mon, Feb 06, 2023 at 02:20:16PM +0200, Eli Cohen wrote: > > > Initialize itolb spinlock. > > > > > > Fixes: 5262912ef3cf ("vdpa/mlx5: Add support for control VQ and MAC setting") > > > Signed-off-by: Eli Cohen <elic@nvidia.com> > > threading was broken here but whatevs. > What exactly do you mean by "threading was broken". Is it because I sent two > unrelated fixes together appearing as patch 1/2 and 2/2? exactly. if I see 2/2 I expect a thread so I can find 1/2 and preferably a cover letter explaining what unifies all these patches. If they are unrelated no need to number them. > > > > > --- > > > drivers/vdpa/mlx5/core/resources.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/vdpa/mlx5/core/resources.c b/drivers/vdpa/mlx5/core/resources.c > > > index 45ad41287a31..d5a59c9035fb 100644 > > > --- a/drivers/vdpa/mlx5/core/resources.c > > > +++ b/drivers/vdpa/mlx5/core/resources.c > > > @@ -233,6 +233,7 @@ static int init_ctrl_vq(struct mlx5_vdpa_dev *mvdev) > > > if (!mvdev->cvq.iotlb) > > > return -ENOMEM; > > > + spin_lock_init(&mvdev->cvq.iommu_lock); > > > vringh_set_iotlb(&mvdev->cvq.vring, mvdev->cvq.iotlb, &mvdev->cvq.iommu_lock); > > > return 0; > > > -- > > > 2.38.1 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-13 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230206122016.1149373-1-elic@nvidia.com>
2023-02-13 12:19 ` [PATCH 2/2] vdpa/mlx5: Initialize CVQ iotlb spinlock Michael S. Tsirkin
[not found] ` <570ab4b9-eed7-3c5a-400a-261a9a205b4f@nvidia.com>
2023-02-13 12:26 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).