Re: [PATCH 3/3] virtio_ring: Use const to annotate read-only pointer params

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Mar 08, 2023 at 09:07:49AM -0500, Feng Liu wrote:
> 
> 
> On 2023-03-08 a.m.12:58, Jason Wang wrote:
> > External email: Use caution opening links or attachments
> > 
> > 
> > On Tue, Mar 7, 2023 at 11:57 AM Feng Liu <feliu@nvidia.com> wrote:
> > > 
> > > Add const to make the read-only pointer parameters clear, similar to
> > > many existing functions.
> > > 
> > > Signed-off-by: Feng Liu <feliu@nvidia.com>
> > > Reviewed-by: Jiri Pirko <jiri@nvidia.com>
> > > Reviewed-by: Parav Pandit <parav@nvidia.com>
> > > Reviewed-by: Gavin Li <gavinl@nvidia.com>
> > > Reviewed-by: Bodong Wang <bodong@nvidia.com>
> > > ---
> > >   drivers/virtio/virtio_ring.c | 25 ++++++++++++-------------
> > >   include/linux/virtio.h       | 12 ++++++------
> > >   2 files changed, 18 insertions(+), 19 deletions(-)
> > > 
> > 
> > [...]
> > 
> > > 
> > > -/*
> > > - * This should prevent the device from being used, allowing drivers to
> > > +/ This should prevent the device from being used, allowing drivers to
> > >    * recover.  You may need to grab appropriate locks to flush.
> > >    */
> > 
> > Any reason for this change?
> > 
> Hi, Jason
> The original comment of the code had a syntax problem and couldn't compile,
> I fixed it here

This is how it looked before your patch:

/*
 * This should prevent the device from being used, allowing drivers to
 * recover.  You may need to grab appropriate locks to flush.
 */

I see no problem here.


> > Thanks
> > 

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization