From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84C56C77B73 for ; Tue, 30 May 2023 17:55:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1C0E081F4F; Tue, 30 May 2023 17:55:36 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1C0E081F4F Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hUgIqd3b X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gw9ygzyYZtGT; Tue, 30 May 2023 17:55:35 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id A4AF181F4A; Tue, 30 May 2023 17:55:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A4AF181F4A Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6DDBEC0035; Tue, 30 May 2023 17:55:34 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 23006C002A for ; Tue, 30 May 2023 17:55:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E494E60A9D for ; Tue, 30 May 2023 17:55:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E494E60A9D Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hUgIqd3b X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XCkufrMHhh-D for ; Tue, 30 May 2023 17:55:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0FAE0607B4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 0FAE0607B4 for ; Tue, 30 May 2023 17:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685469330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jSKPWaXFdOGi0gSIhT9fJ0n4SI2mbHxCHrbzwzolEv4=; b=hUgIqd3b+1meSSmfdKzFDAz6YjycXWIAkAzqKRTvtf0IGABjKf53sFyJr3jWCt94IAGBS7 4wSpm5Z6LJeWtGeT+4LHrlPvlbrVMqptpq/j81IH8tm3UCYNQXnncAAYtRglZb/TNeB6KJ WlmoS2OBDK37wA1cFtW9Lj5f+AVrtlk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-563-7UptTIn6N8aSZ4cTqPplkA-1; Tue, 30 May 2023 13:55:26 -0400 X-MC-Unique: 7UptTIn6N8aSZ4cTqPplkA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1855D3C14AA8; Tue, 30 May 2023 17:55:26 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.225.218]) by smtp.corp.redhat.com (Postfix) with SMTP id 33D6C112132C; Tue, 30 May 2023 17:55:23 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 30 May 2023 19:55:07 +0200 (CEST) Date: Tue, 30 May 2023 19:55:03 +0200 From: Oleg Nesterov To: Christian Brauner Subject: Re: [PATCH 3/3] fork, vhost: Use CLONE_THREAD to fix freezer/ps regression Message-ID: <20230530175503.GA21270@redhat.com> References: <20230524141022.GA19091@redhat.com> <87ttw1zt4i.fsf@email.froward.int.ebiederm.org> <20230525115512.GA9229@redhat.com> <87y1lcxwcj.fsf@email.froward.int.ebiederm.org> <87cz2mrtnk.fsf@email.froward.int.ebiederm.org> <87mt1pmezu.fsf@email.froward.int.ebiederm.org> <20230529111859.GA15193@redhat.com> <20230530-autor-faxnummer-01e0a31c0fb8@brauner> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230530-autor-faxnummer-01e0a31c0fb8@brauner> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Cc: axboe@kernel.dk, mst@redhat.com, linux@leemhuis.info, linux-kernel@vger.kernel.org, "Eric W. Biederman" , stefanha@redhat.com, nicolas.dichtel@6wind.com, virtualization@lists.linux-foundation.org, Linus Torvalds X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 05/30, Christian Brauner wrote: > > On Mon, May 29, 2023 at 01:19:39PM +0200, Oleg Nesterov wrote: > > > > If we want CLONE_THREAD, I think vhost_worker() should exit after get_signal() > > returns SIGKILL. Perhaps it should "disable" vhost_work_queue() somehow and > > Yes, and that's what I proposed at the beginning of this tread. Yes. And you know, I misunderstood you even if I had the same feeling from the very beginning too (except I wasn't and still not sure CLONE_THREAD is a good idea). Because... OK, I think it doesn't matter now ;) Mike, Eric, et al. I'll try to (at least) read your emails tomorrow. Another day spent on redhat bugzillas. Oleg. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization