* Re: [PATCH] vduse: avoid empty string for dev name [not found] <20230530033626.1266794-1-sheng.zhao@bytedance.com> @ 2023-05-31 1:51 ` Jason Wang [not found] ` <CACycT3sPTZLho19ZRKPmcTmvRYh4NW9QBT6z=dkq1U_Acd2o6g@mail.gmail.com> 1 sibling, 0 replies; 3+ messages in thread From: Jason Wang @ 2023-05-31 1:51 UTC (permalink / raw) To: Sheng Zhao; +Cc: xieyongji, virtualization, Xianjun Zeng, mst On Tue, May 30, 2023 at 11:37 AM Sheng Zhao <sheng.zhao@bytedance.com> wrote: > > Syzkaller hits a kernel WARN when the first character of the dev name > provided is NULL. Solution is to add a NULL check before calling > cdev_device_add() in vduse_create_dev(). > > kobject: (0000000072042169): attempted to be registered with empty name! > WARNING: CPU: 0 PID: 112695 at lib/kobject.c:236 > Call Trace: > kobject_add_varg linux/src/lib/kobject.c:390 [inline] > kobject_add+0xf6/0x150 linux/src/lib/kobject.c:442 > device_add+0x28f/0xc20 linux/src/drivers/base/core.c:2167 > cdev_device_add+0x83/0xc0 linux/src/fs/char_dev.c:546 > vduse_create_dev linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2254 [inline] > vduse_ioctl+0x7b5/0xf30 linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2316 > vfs_ioctl linux/src/fs/ioctl.c:47 [inline] > file_ioctl linux/src/fs/ioctl.c:510 [inline] > do_vfs_ioctl+0x14b/0xa80 linux/src/fs/ioctl.c:697 > ksys_ioctl+0x7c/0xa0 linux/src/fs/ioctl.c:714 > __do_sys_ioctl linux/src/fs/ioctl.c:721 [inline] > __se_sys_ioctl linux/src/fs/ioctl.c:719 [inline] > __x64_sys_ioctl+0x42/0x50 linux/src/fs/ioctl.c:719 > do_syscall_64+0x94/0x330 linux/src/arch/x86/entry/common.c:291 > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > Reported-by: Xianjun Zeng <zengxianjun@bytedance.com> > Signed-off-by: Sheng Zhao <sheng.zhao@bytedance.com> Acked-by: Jason Wang <jasowang@redhat.com> Thanks > --- > drivers/vdpa/vdpa_user/vduse_dev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c > index de97e38c3b82..5f5c21674fdc 100644 > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > @@ -1685,6 +1685,9 @@ static bool vduse_validate_config(struct vduse_dev_config *config) > if (config->vq_num > 0xffff) > return false; > > + if (!config->name[0]) > + return false; > + > if (!device_is_allowed(config->device_id)) > return false; > > -- > 2.20.1 > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CACycT3sPTZLho19ZRKPmcTmvRYh4NW9QBT6z=dkq1U_Acd2o6g@mail.gmail.com>]
[parent not found: <CA+nqC_FVJS2Fv98ztY=Szbv7KhqZQ1bQxc-6E909u3z1zub9zA@mail.gmail.com>]
* Re: [PATCH] vduse: avoid empty string for dev name [not found] ` <CA+nqC_FVJS2Fv98ztY=Szbv7KhqZQ1bQxc-6E909u3z1zub9zA@mail.gmail.com> @ 2023-06-05 13:23 ` Michael S. Tsirkin [not found] ` <CA+nqC_E44t30v8Kjrx3A36kcyEcAesnEHoP7Q_XJbn129wOT1A@mail.gmail.com> 0 siblings, 1 reply; 3+ messages in thread From: Michael S. Tsirkin @ 2023-06-05 13:23 UTC (permalink / raw) To: 赵盛; +Cc: Yongji Xie, Xianjun Zeng, virtualization On Mon, Jun 05, 2023 at 06:17:55AM -0700, 赵盛 wrote: > Hi Yongji, > Thanks for your feedback, I'll resubmit the patch with this change. Just send a Fixes tag in a reply no need to resubmit - I queued it already. > Sheng > From: "Yongji Xie"<xieyongji@bytedance.com> > Date: Thu, Jun 1, 2023, 11:31 > Subject: Re: [PATCH] vduse: avoid empty string for dev name > To: "Sheng Zhao"<sheng.zhao@bytedance.com> > Cc: "Michael S. Tsirkin"<mst@redhat.com>, "Jason Wang"<jasowang@redhat.com>, > "virtualization"<virtualization@lists.linux-foundation.org>, "Xianjun Zeng"< > zengxianjun@bytedance.com> > On Tue, May 30, 2023 at 11:37 AM Sheng Zhao <sheng.zhao@bytedance.com> wrote: > > > > Syzkaller hits a kernel WARN when the first character of the dev name > > provided is NULL. Solution is to add a NULL check before calling > > cdev_device_add() in vduse_create_dev(). > > > > kobject: (0000000072042169): attempted to be registered with empty name! > > WARNING: CPU: 0 PID: 112695 at lib/kobject.c:236 > > Call Trace: > > kobject_add_varg linux/src/lib/kobject.c:390 [inline] > > kobject_add+0xf6/0x150 linux/src/lib/kobject.c:442 > > device_add+0x28f/0xc20 linux/src/drivers/base/core.c:2167 > > cdev_device_add+0x83/0xc0 linux/src/fs/char_dev.c:546 > > vduse_create_dev linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2254 [inline] > > vduse_ioctl+0x7b5/0xf30 linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2316 > > vfs_ioctl linux/src/fs/ioctl.c:47 [inline] > > file_ioctl linux/src/fs/ioctl.c:510 [inline] > > do_vfs_ioctl+0x14b/0xa80 linux/src/fs/ioctl.c:697 > > ksys_ioctl+0x7c/0xa0 linux/src/fs/ioctl.c:714 > > __do_sys_ioctl linux/src/fs/ioctl.c:721 [inline] > > __se_sys_ioctl linux/src/fs/ioctl.c:719 [inline] > > __x64_sys_ioctl+0x42/0x50 linux/src/fs/ioctl.c:719 > > do_syscall_64+0x94/0x330 linux/src/arch/x86/entry/common.c:291 > > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > > > Reported-by: Xianjun Zeng <zengxianjun@bytedance.com> > > Signed-off-by: Sheng Zhao <sheng.zhao@bytedance.com> > > Miss a "Fixes" tag. Others look good to me. > > Reviewed-by: Xie Yongji <xieyongji@bytedance.com> > > Thanks, > Yongji > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CA+nqC_E44t30v8Kjrx3A36kcyEcAesnEHoP7Q_XJbn129wOT1A@mail.gmail.com>]
* Re: [PATCH] vduse: avoid empty string for dev name [not found] ` <CA+nqC_E44t30v8Kjrx3A36kcyEcAesnEHoP7Q_XJbn129wOT1A@mail.gmail.com> @ 2023-06-05 14:02 ` Michael S. Tsirkin 0 siblings, 0 replies; 3+ messages in thread From: Michael S. Tsirkin @ 2023-06-05 14:02 UTC (permalink / raw) To: 赵盛; +Cc: Yongji Xie, Xianjun Zeng, virtualization On Mon, Jun 05, 2023 at 06:48:43AM -0700, 赵盛 wrote: > Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace") Thanks! Just don't do the mangled text and avoid top-posting in the future. > From: "Michael S. Tsirkin"<mst@redhat.com> > Date: Mon, Jun 5, 2023, 21:24 > Subject: [External] Re: [PATCH] vduse: avoid empty string for dev name > To: "赵盛"<sheng.zhao@bytedance.com> > Cc: "Yongji Xie"<xieyongji@bytedance.com>, "Jason Wang"<jasowang@redhat.com>, > "virtualization"<virtualization@lists.linux-foundation.org>, "Xianjun Zeng"< > zengxianjun@bytedance.com> > On Mon, Jun 05, 2023 at 06:17:55AM -0700, 赵盛 wrote: > Hi Yongji, > Thanks > for your feedback, I'll resubmit the patch with this change. Just send a Fixes > tag in a reply no need to resubmit - I queued it already. > Sheng > From: > "Yongji Xie"<xieyongji@bytedance.com> > Date: Thu, Jun 1, 2023, 11:31 > > Subject: Re: [PATCH] vduse: avoid empty string for dev name > To: "Sheng Zhao" > <sheng.zhao@bytedance.com> > Cc: "Michael S. Tsirkin"<mst@redhat.com>, "Jason > Wang"<jasowang@redhat.com>, > "virtualization"< > virtualization@lists.linux-foundation.org>, "Xianjun Zeng"< > > zengxianjun@bytedance.com> > On Tue, May 30, 2023 at 11:37 AM Sheng Zhao < > sheng.zhao@bytedance.com> wrote: > > > > Syzkaller hits a kernel WARN when the > first character of the dev name > > provided is NULL. Solution is to add a NULL > check before calling > > cdev_device_add() in vduse_create_dev(). > > > > > kobject: (0000000072042169): attempted to be registered with empty name! > > > WARNING: CPU: 0 PID: 112695 at lib/kobject.c:236 > > Call Trace: > > > kobject_add_varg linux/src/lib/kobject.c:390 [inline] > > kobject_add+0xf6/ > 0x150 linux/src/lib/kobject.c:442 > > device_add+0x28f/0xc20 linux/src/drivers > /base/core.c:2167 > > cdev_device_add+0x83/0xc0 linux/src/fs/char_dev.c:546 > > > vduse_create_dev linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2254 [inline] > > > vduse_ioctl+0x7b5/0xf30 linux/src/drivers/vdpa/vdpa_user/vduse_dev.c:2316 > > > vfs_ioctl linux/src/fs/ioctl.c:47 [inline] > > file_ioctl linux/src/fs/ > ioctl.c:510 [inline] > > do_vfs_ioctl+0x14b/0xa80 linux/src/fs/ioctl.c:697 > > > ksys_ioctl+0x7c/0xa0 linux/src/fs/ioctl.c:714 > > __do_sys_ioctl linux/src/ > fs/ioctl.c:721 [inline] > > __se_sys_ioctl linux/src/fs/ioctl.c:719 [inline] > > > __x64_sys_ioctl+0x42/0x50 linux/src/fs/ioctl.c:719 > > do_syscall_64+0x94/ > 0x330 linux/src/arch/x86/entry/common.c:291 > > > entry_SYSCALL_64_after_hwframe+0x44/0xa9 > > > > Reported-by: Xianjun Zeng < > zengxianjun@bytedance.com> > > Signed-off-by: Sheng Zhao < > sheng.zhao@bytedance.com> > > Miss a "Fixes" tag. Others look good to me. > > > Reviewed-by: Xie Yongji <xieyongji@bytedance.com> > > Thanks, > Yongji > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-05 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230530033626.1266794-1-sheng.zhao@bytedance.com>
2023-05-31 1:51 ` [PATCH] vduse: avoid empty string for dev name Jason Wang
[not found] ` <CACycT3sPTZLho19ZRKPmcTmvRYh4NW9QBT6z=dkq1U_Acd2o6g@mail.gmail.com>
[not found] ` <CA+nqC_FVJS2Fv98ztY=Szbv7KhqZQ1bQxc-6E909u3z1zub9zA@mail.gmail.com>
2023-06-05 13:23 ` Michael S. Tsirkin
[not found] ` <CA+nqC_E44t30v8Kjrx3A36kcyEcAesnEHoP7Q_XJbn129wOT1A@mail.gmail.com>
2023-06-05 14:02 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).