From: Alex Williamson <alex.williamson@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-aio@kvack.org, Muchun Song <muchun.song@linux.dev>,
Tony Krowiak <akrowiak@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Paul Durrant <paul@xen.org>, Tom Rix <trix@redhat.com>,
Roman Gushchin <roman.gushchin@linux.dev>,
dri-devel@lists.freedesktop.org, Michal Hocko <mhocko@kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
linux-mm@kvack.org, Kirti Wankhede <kwankhede@nvidia.com>,
netdev@vger.kernel.org, Vineeth Vijayan <vneethv@linux.ibm.com>,
Diana Craciun <diana.craciun@oss.nxp.com>,
Borislav Petkov <bp@alien8.de>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Fei Li <fei1.li@intel.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Marcin Wojtas <mw@semihalf.com>, Arnd Bergmann <arnd@arndb.de>,
Leon Romanovsky <leon@kernel.org>,
Harald Freudenberger <freude@linux.ibm.com>,
x86@kernel.org, Halil Pasic <pasic@linux.ibm.com>,
Ingo Molnar <mingo@redhat.com>, Moritz Fischer <mdf@kernel.org>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Xu Yilun <yilun.xu@intel.com>,
linux-fpga@vger.kernel.org, Zhi Wang <zhi.a.wang@intel.com>,
Wu Hao <hao.wu@intel.com>, Jason Herne <jjherne@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Andrew Donnellan <ajd@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
linux-s390@vger.kernel.org, Dominik Behr <dbehr@chromium.org>,
intel-gfx@lists.freedesktop.org,
Sean Christopherson <seanjc@google.com>,
Eric Auger <eric.auger@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shakeel Butt <shakeelb@google.com>,
kvm@vger.kernel.org, Rodrigo Vivi <rodrigo.vivi@intel.com>,
cgroups@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
virtualization@lists.linux-foundation.org,
intel-gvt-dev@lists.freedesktop.org, io-uring@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Christian Brauner <brauner@kernel.org>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Oded Gabbay <ogabbay@kernel.org>,
linux-usb@vger.kernel.org,
Peter Oberparleiter <oberpar@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Benjamin LaHaise <bcrl@kvack.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Sven Schnelle <svens@linux.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-fsdevel@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
linuxppc-dev@lists.ozlabs.org,
Pavel Begunkov <asml.silence@gmail.com>
Subject: Re: [PATCH 0/2] eventfd: simplify signal helpers
Date: Mon, 17 Jul 2023 16:52:03 -0600 [thread overview]
Message-ID: <20230717165203.4ee6b1e6.alex.williamson@redhat.com> (raw)
In-Reply-To: <ZLW8wEzkhBxd0O0L@ziepe.ca>
On Mon, 17 Jul 2023 19:12:16 -0300
Jason Gunthorpe <jgg@ziepe.ca> wrote:
> On Mon, Jul 17, 2023 at 01:08:31PM -0600, Alex Williamson wrote:
>
> > What would that mechanism be? We've been iterating on getting the
> > serialization and buffering correct, but I don't know of another means
> > that combines the notification with a value, so we'd likely end up with
> > an eventfd only for notification and a separate ring buffer for
> > notification values.
>
> All FDs do this. You just have to make a FD with custom
> file_operations that does what this wants. The uAPI shouldn't be able
> to tell if the FD is backing it with an eventfd or otherwise. Have the
> kernel return the FD instead of accepting it. Follow the basic design
> of eg mlx5vf_save_fops
Sure, userspace could poll on any fd and read a value from it, but at
that point we're essentially duplicating a lot of what eventfd provides
for a minor(?) semantic difference over how the counter value is
interpreted. Using an actual eventfd allows the ACPI notification to
work as just another interrupt index within the existing vfio IRQ uAPI.
Thanks,
Alex
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-07-17 22:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230630155936.3015595-1-jaz@semihalf.com>
[not found] ` <20230714-gauner-unsolidarisch-fc51f96c61e8@brauner>
2023-07-14 15:24 ` [PATCH 0/2] eventfd: simplify signal helpers Jason Gunthorpe
[not found] ` <CAH76GKPF4BjJLrzLBW8k12ATaAGADeMYc2NQ9+j0KgRa0pomUw@mail.gmail.com>
2023-07-17 19:08 ` Alex Williamson
2023-07-17 22:12 ` Jason Gunthorpe
2023-07-17 22:52 ` Alex Williamson [this message]
2023-07-18 15:56 ` Jason Gunthorpe
[not found] <20230713-vfs-eventfd-signal-v1-0-7fda6c5d212b@kernel.org>
2023-07-13 17:10 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717165203.4ee6b1e6.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=bp@alien8.de \
--cc=brauner@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dbehr@chromium.org \
--cc=diana.craciun@oss.nxp.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=eric.auger@redhat.com \
--cc=farman@linux.ibm.com \
--cc=fbarrat@linux.ibm.com \
--cc=fei1.li@intel.com \
--cc=freude@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=hao.wu@intel.com \
--cc=hca@linux.ibm.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=io-uring@vger.kernel.org \
--cc=jaz@semihalf.com \
--cc=jgg@ziepe.ca \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-aio@kvack.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mdf@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=muchun.song@linux.dev \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=oberpar@linux.ibm.com \
--cc=ogabbay@kernel.org \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=rodrigo.vivi@intel.com \
--cc=roman.gushchin@linux.dev \
--cc=seanjc@google.com \
--cc=shakeelb@google.com \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=trix@redhat.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vneethv@linux.ibm.com \
--cc=x86@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yilun.xu@intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).