From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org
Subject: Re: Unbinding virtio_pci_modern does not release BAR4 in Linux 6.5.0-rc4
Date: Thu, 10 Aug 2023 10:15:44 -0400 [thread overview]
Message-ID: <20230810141544.GB2931656@fedora> (raw)
In-Reply-To: <CACGkMEvjrs17TMH2=b+mwm7qGFqEWV3jHydLyK7=Aj8spBNthw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1627 bytes --]
On Thu, Aug 10, 2023 at 11:08:52AM +0800, Jason Wang wrote:
> On Thu, Aug 3, 2023 at 10:37 PM Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > Hi,
> > After running "driverctl --nosave set-override 0000:01:00.0 vfio-pci" on
> > a virtio-blk-pci device, /proc/iomem shows that BAR4 is still owned by
> > virtio_pci_modern even though the vfio-pci driver is now bound to the
> > PCI device.
> >
> > This regression was introduced after 6.4.7 but I don't see the culprit
> > in the git logs.
> >
> > Unfortunately I don't have time to investigate further right now but
> > I've included instructions on how to reproduce this below.
> >
> > Can anyone else reproduce this and can we still fix it for the upcoming
> > Linux 6.5?
>
> This seems to be fixed by:
>
> https://lore.kernel.org/lkml/20230720131423-mutt-send-email-mst@kernel.org/T/
Awesome, thanks for letting me know!
Stefan
>
> Thanks
>
> >
> > Thanks,
> > Stefan
> > ---
> > $ qemu-system-x86_64 \
> > -M q35,accel=kvm,kernel-irqchip=split \
> > -cpu host \
> > -m 1G \
> > -device intel-iommu,intremap=on,device-iotlb=on \
> > --blockdev file,filename=test.img,cache.direct=on,node-name=drive0 \
> > --device virtio-blk-pci,drive=drive0 \
> > -blockdev file,filename=test2.img,cache.direct=on,node-name=drive2 \
> > --device ioh3420,id=pcie.1,chassis=1 \
> > --device virtio-blk-pci,disable-legacy=on,disable-modern=off,drive=drive2,iommu_platform=on,ats=on,bus=pcie.1
> >
> > (guest)# driverctl --nosave set-override 0000:01:00.0 vfio-pci
> > (guest)# cat /proc/iomem
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
prev parent reply other threads:[~2023-08-10 14:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:37 Unbinding virtio_pci_modern does not release BAR4 in Linux 6.5.0-rc4 Stefan Hajnoczi
2023-08-10 3:08 ` Jason Wang
2023-08-10 14:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810141544.GB2931656@fedora \
--to=stefanha@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).