From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: Niklas Schnelle <schnelle@linux.ibm.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, iommu@lists.linux.dev,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 1/2] iommu/virtio: Make use of ops->iotlb_sync_map
Date: Fri, 22 Sep 2023 09:41:30 -0300 [thread overview]
Message-ID: <20230922124130.GD13795@ziepe.ca> (raw)
In-Reply-To: <20230922075719.GB1361815@myrica>
On Fri, Sep 22, 2023 at 08:57:19AM +0100, Jean-Philippe Brucker wrote:
> > > They're not strictly equivalent: this check works around a temporary issue
> > > with the IOMMU core, which calls map/unmap before the domain is
> > > finalized.
> >
> > Where? The above points to iommu_create_device_direct_mappings() but
> > it doesn't because the pgsize_bitmap == 0:
>
> __iommu_domain_alloc() sets pgsize_bitmap in this case:
>
> /*
> * If not already set, assume all sizes by default; the driver
> * may override this later
> */
> if (!domain->pgsize_bitmap)
> domain->pgsize_bitmap = bus->iommu_ops->pgsize_bitmap;
Dirver's shouldn't do that.
The core code was fixed to try again with mapping reserved regions to
support these kinds of drivers.
Jason
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-09-22 12:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230918-viommu-sync-map-v2-0-f33767f6cf7a@linux.ibm.com>
[not found] ` <20230918-viommu-sync-map-v2-2-f33767f6cf7a@linux.ibm.com>
2023-09-18 15:59 ` [PATCH v2 2/2] iommu/virtio: Add ops->flush_iotlb_all and enable deferred flush Jean-Philippe Brucker
[not found] ` <20230918-viommu-sync-map-v2-1-f33767f6cf7a@linux.ibm.com>
2023-09-18 15:58 ` [PATCH v2 1/2] iommu/virtio: Make use of ops->iotlb_sync_map Jean-Philippe Brucker
2023-09-18 16:37 ` Robin Murphy
2023-09-19 8:15 ` Jean-Philippe Brucker
2023-09-19 8:28 ` Robin Murphy
2023-09-22 7:52 ` Jean-Philippe Brucker
2023-09-19 14:46 ` Jason Gunthorpe
2023-09-22 7:57 ` Jean-Philippe Brucker
2023-09-22 12:41 ` Jason Gunthorpe [this message]
2023-09-22 13:13 ` Robin Murphy
2023-09-22 16:27 ` Jason Gunthorpe
2023-09-22 18:07 ` Robin Murphy
2023-09-22 23:33 ` Jason Gunthorpe
[not found] ` <42860c87-cf4d-0413-c3ae-b74ee9e7e5e6@linux.intel.com>
2023-09-25 12:40 ` Jason Gunthorpe
2023-09-25 13:07 ` Robin Murphy
2023-09-25 13:29 ` Jason Gunthorpe
2023-09-25 17:23 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922124130.GD13795@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).