[PATCH 0/9] drm: Annotate structs with __counted_by

From: Kees Cook <keescook@chromium.org>
To: David Airlie <airlied@gmail.com>
Cc: "Tejas Upadhyay" <tejas.upadhyay@intel.com>,
	"Emma Anholt" <emma@anholt.net>, "Tom Rix" <trix@redhat.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	llvm@lists.linux.dev, dri-devel@lists.freedesktop.org,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	"Prike Liang" <Prike.Liang@amd.com>,
	"Huang Rui" <ray.huang@amd.com>,
	"Andrzej Hajda" <andrzej.hajda@intel.com>,
	"Marijn Suijten" <marijn.suijten@somainline.org>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Karol Herbst" <kherbst@redhat.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	amd-gfx@lists.freedesktop.org,
	"Kuogee Hsieh" <quic_khsieh@quicinc.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	"VMware Graphics Reviewers"
	<linux-graphics-maintainer@vmware.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"Andi Shyti" <andi.shyti@linux.intel.com>,
	nouveau@lists.freedesktop.org,
	"David Airlie" <airlied@redhat.com>,
	virtualization@lists.linux-foundation.org,
	"Chia-I Wu" <olvaffe@gmail.com>,
	linux-hardening@vger.kernel.org,
	"Lijo Lazar" <lijo.lazar@amd.com>,
	"Lyude Paul" <lyude@redhat.com>,
	"Kees Cook" <keescook@chromium.org>,
	"Yifan Zhang" <yifan1.zhang@amd.com>,
	linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	"Kevin Wang" <kevin1.wang@amd.com>,
	"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Melissa Wen" <mwen@igalia.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Gurchetan Singh" <gurchetansingh@chromium.org>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"Evan Quan" <evan.quan@amd.com>, "Sean Paul" <sean@poorly.run>,
	"Tvrtko Ursulin" <tvrtko.ursulin@linux.intel.com>,
	"Xiaojian Du" <Xiaojian.Du@amd.com>, "Le Ma" <le.ma@amd.com>,
	freedreno@lists.freedesktop.org,
	"Bjorn Andersson" <andersson@kernel.org>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"Nick Desaulniers" <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org, "Rob Clark" <robdclark@gmail.com>,
	"Zack Rusin" <zackr@vmware.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Nirmoy Das" <nirmoy.das@intel.com>, "Lang Yu" <Lang.Yu@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"John Harrison" <john.c.harrison@Intel.com>,
	"Hawking Zhang" <Hawking.Zhang@amd.com>
Subject: [PATCH 0/9] drm: Annotate structs with __counted_by
Date: Fri, 22 Sep 2023 10:32:05 -0700	[thread overview]
Message-ID: <20230922173110.work.084-kees@kernel.org> (raw)

Hi,

This is a batch of patches touching drm for preparing for the coming
implementation by GCC and Clang of the __counted_by attribute. Flexible
array members annotated with __counted_by can have their accesses
bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array
indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).

As found with Coccinelle[1], add __counted_by to structs that would
benefit from the annotation.

Since the element count member must be set before accessing the annotated
flexible array member, some patches also move the member's initialization
earlier. (These are noted in the individual patches.)

-Kees

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Kees Cook (9):
  drm/amd/pm: Annotate struct smu10_voltage_dependency_table with
    __counted_by
  drm/amdgpu/discovery: Annotate struct ip_hw_instance with __counted_by
  drm/i915/selftests: Annotate struct perf_series with __counted_by
  drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by
  drm/nouveau/pm: Annotate struct nvkm_perfdom with __counted_by
  drm/vc4: Annotate struct vc4_perfmon with __counted_by
  drm/virtio: Annotate struct virtio_gpu_object_array with __counted_by
  drm/vmwgfx: Annotate struct vmw_surface_dirty with __counted_by
  drm/v3d: Annotate struct v3d_perfmon with __counted_by

 drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c        | 2 +-
 drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu10_hwmgr.h | 2 +-
 drivers/gpu/drm/i915/selftests/i915_request.c        | 2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h    | 2 +-
 drivers/gpu/drm/nouveau/nvkm/engine/pm/priv.h        | 2 +-
 drivers/gpu/drm/v3d/v3d_drv.h                        | 2 +-
 drivers/gpu/drm/vc4/vc4_drv.h                        | 2 +-
 drivers/gpu/drm/virtio/virtgpu_drv.h                 | 2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_surface.c              | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)

-- 
2.34.1

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization