From: kernel test robot <lkp@intel.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
virtualization@lists.linux-foundation.org
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, John Fastabend <john.fastabend@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>,
oe-kbuild-all@lists.linux.dev, Jakub Kicinski <kuba@kernel.org>,
bpf@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH vhost 01/22] virtio_ring: virtqueue_set_dma_premapped support disable
Date: Wed, 11 Oct 2023 22:13:17 +0800 [thread overview]
Message-ID: <202310112204.h03TUDpH-lkp@intel.com> (raw)
In-Reply-To: <20231011092728.105904-2-xuanzhuo@linux.alibaba.com>
Hi Xuan,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on v6.6-rc5 next-20231011]
[cannot apply to mst-vhost/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Xuan-Zhuo/virtio_ring-virtqueue_set_dma_premapped-support-disable/20231011-180709
base: linus/master
patch link: https://lore.kernel.org/r/20231011092728.105904-2-xuanzhuo%40linux.alibaba.com
patch subject: [PATCH vhost 01/22] virtio_ring: virtqueue_set_dma_premapped support disable
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231011/202310112204.h03TUDpH-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231011/202310112204.h03TUDpH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310112204.h03TUDpH-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/virtio/virtio_ring.c:2788: warning: Function parameter or member 'mode' not described in 'virtqueue_set_dma_premapped'
vim +2788 drivers/virtio/virtio_ring.c
c790e8e1817f1a Xuan Zhuo 2022-08-01 2765
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2766 /**
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2767 * virtqueue_set_dma_premapped - set the vring premapped mode
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2768 * @_vq: the struct virtqueue we're talking about.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2769 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2770 * Enable the premapped mode of the vq.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2771 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2772 * The vring in premapped mode does not do dma internally, so the driver must
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2773 * do dma mapping in advance. The driver must pass the dma_address through
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2774 * dma_address of scatterlist. When the driver got a used buffer from
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2775 * the vring, it has to unmap the dma address.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2776 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2777 * This function must be called immediately after creating the vq, or after vq
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2778 * reset, and before adding any buffers to it.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2779 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2780 * Caller must ensure we don't call this with other virtqueue operations
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2781 * at the same time (except where noted).
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2782 *
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2783 * Returns zero or a negative error.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2784 * 0: success.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2785 * -EINVAL: vring does not use the dma api, so we can not enable premapped mode.
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2786 */
f8d1a236ad114f Xuan Zhuo 2023-10-11 2787 int virtqueue_set_dma_premapped(struct virtqueue *_vq, bool mode)
8daafe9ebbd21a Xuan Zhuo 2023-08-10 @2788 {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2789 struct vring_virtqueue *vq = to_vvq(_vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2790 u32 num;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2791
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2792 START_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2793
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2794 num = vq->packed_ring ? vq->packed.vring.num : vq->split.vring.num;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2795
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2796 if (num != vq->vq.num_free) {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2797 END_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2798 return -EINVAL;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2799 }
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2800
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2801 if (!vq->use_dma_api) {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2802 END_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2803 return -EINVAL;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2804 }
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2805
f8d1a236ad114f Xuan Zhuo 2023-10-11 2806 if (mode) {
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2807 vq->premapped = true;
b319940f83c21b Xuan Zhuo 2023-08-10 2808 vq->do_unmap = false;
f8d1a236ad114f Xuan Zhuo 2023-10-11 2809 } else {
f8d1a236ad114f Xuan Zhuo 2023-10-11 2810 vq->premapped = false;
f8d1a236ad114f Xuan Zhuo 2023-10-11 2811 vq->do_unmap = vq->use_dma_api;
f8d1a236ad114f Xuan Zhuo 2023-10-11 2812 }
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2813
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2814 END_USE(vq);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2815
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2816 return 0;
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2817 }
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2818 EXPORT_SYMBOL_GPL(virtqueue_set_dma_premapped);
8daafe9ebbd21a Xuan Zhuo 2023-08-10 2819
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-10-11 14:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 9:27 [PATCH vhost 00/22] virtio-net: support AF_XDP zero copy Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 01/22] virtio_ring: virtqueue_set_dma_premapped support disable Xuan Zhuo
2023-10-11 14:13 ` kernel test robot [this message]
2023-10-12 9:15 ` Michael S. Tsirkin
2023-10-12 9:18 ` Xuan Zhuo
2023-10-12 9:40 ` Michael S. Tsirkin
2023-10-12 11:36 ` Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 02/22] virtio_ring: introduce virtqueue_dma_[un]map_page_attrs Xuan Zhuo
2023-10-18 7:53 ` Xuan Zhuo
2023-10-18 7:59 ` Michael S. Tsirkin
2023-10-18 8:00 ` Xuan Zhuo
2023-10-18 8:44 ` Michael S. Tsirkin
2023-10-18 8:57 ` Xuan Zhuo
2023-10-18 9:13 ` Michael S. Tsirkin
2023-10-18 9:17 ` Xuan Zhuo
2023-10-18 8:09 ` Michael S. Tsirkin
2023-10-11 9:27 ` [PATCH vhost 03/22] virtio_net: rename free_old_xmit_skbs to free_old_xmit Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 04/22] virtio_net: unify the code for recycling the xmit ptr Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 05/22] virtio_net: independent directory Xuan Zhuo
2023-10-11 23:22 ` kernel test robot
2023-10-11 9:27 ` [PATCH vhost 06/22] virtio_net: move to virtio_net.h Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 07/22] virtio_net: add prefix virtnet to all struct/api inside virtio_net.h Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 08/22] virtio_net: virtnet_poll_tx support rescheduled Xuan Zhuo
2023-10-12 9:13 ` Michael S. Tsirkin
2023-10-11 9:27 ` [PATCH vhost 09/22] virtio_net: separate virtnet_rx_resize() Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 10/22] virtio_net: separate virtnet_tx_resize() Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 11/22] virtio_net: sq support premapped mode Xuan Zhuo
2023-10-13 10:13 ` kernel test robot
2023-10-11 9:27 ` [PATCH vhost 12/22] virtio_net: xsk: bind/unbind xsk Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 13/22] virtio_net: xsk: prevent disable tx napi Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 14/22] virtio_net: xsk: tx: support tx Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 15/22] virtio_net: xsk: tx: support wakeup Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 16/22] virtio_net: xsk: tx: virtnet_free_old_xmit() distinguishes xsk buffer Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 17/22] virtio_net: xsk: tx: virtnet_sq_free_unused_buf() check " Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 18/22] virtio_net: xsk: rx: introduce add_recvbuf_xsk() Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 19/22] virtio_net: xsk: rx: introduce receive_xsk() to recv xsk buffer Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 20/22] virtio_net: xsk: rx: virtnet_rq_free_unused_buf() check " Xuan Zhuo
2023-10-11 9:27 ` [PATCH vhost 21/22] virtio_net: update tx timeout record Xuan Zhuo
2023-10-12 9:10 ` Michael S. Tsirkin
2023-10-12 9:12 ` Xuan Zhuo
2023-10-12 9:36 ` Michael S. Tsirkin
2023-10-12 11:54 ` Xuan Zhuo
2023-10-12 13:07 ` Michael S. Tsirkin
2023-10-11 9:27 ` [PATCH vhost 22/22] virtio_net: xdp_features add NETDEV_XDP_ACT_XSK_ZEROCOPY Xuan Zhuo
[not found] ` <20231011100057.535f3834@kernel.org>
2023-10-12 1:53 ` [PATCH vhost 00/22] virtio-net: support AF_XDP zero copy Xuan Zhuo
2023-10-12 7:50 ` Jason Wang
2023-10-12 8:32 ` Xuan Zhuo
2023-10-12 14:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202310112204.h03TUDpH-lkp@intel.com \
--to=lkp@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).