virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: yi.l.liu@intel.com, Cindy Lu <lulu@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [RFC v1 0/8] vhost-vdpa: add support for iommufd
Date: Tue, 7 Nov 2023 11:11:07 -0500	[thread overview]
Message-ID: <20231107105718-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20231107154848.GP4488@nvidia.com>

On Tue, Nov 07, 2023 at 11:48:48AM -0400, Jason Gunthorpe wrote:
> On Tue, Nov 07, 2023 at 09:55:26AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Nov 07, 2023 at 08:49:02AM -0400, Jason Gunthorpe wrote:
> > > IMHO, this patch series needs to spend more time internally to Red Hat
> > > before it is presented to the community.
> > 
> > Just to add an example why I think this "internal review" is a bad idea
> > I seem to recall that someone internal to nvidia at some point
> > attempted to implement this already. The only output from that
> > work we have is that "it's tough" - no pointers to what's tough,
> > no code to study even as a bad path to follow.
> > And while Red Hat might be big, the virt team is rather smaller.
> 
> I don't think Nicolin got to a presentable code point.
> 
> But you can start to see the issues even in this series, like
> simulator is complicated. mlx5 is complicated. Deciding to omit those
> is one path. Come with a proposal and justification to take it out,
> not a patch with an unexplained #ifdef.

Right. Simulator I don't think we need to support, or at least
not necessarily to get this merged - it does not really
benefit from any iommufd features.

_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2023-11-07 16:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20231103171641.1703146-1-lulu@redhat.com>
2023-11-06  4:11 ` [RFC v1 0/8] vhost-vdpa: add support for iommufd Jason Wang
     [not found] ` <20231103171641.1703146-8-lulu@redhat.com>
2023-11-06  7:25   ` [RFC v1 7/8] vp_vdpa::Add " Jason Wang
     [not found] ` <20231103171641.1703146-9-lulu@redhat.com>
2023-11-06  7:26   ` [RFC v1 8/8] iommu: expose the function iommu_device_use_default_domain Jason Wang
     [not found]     ` <CACLfguUPZVY2HDBoir67u0CeR3A9wHjCGvuc3cGLe0L43f8jkg@mail.gmail.com>
2023-11-08  3:03       ` Jason Wang
2023-11-08  7:05         ` Cindy Lu
     [not found] ` <20231103171641.1703146-4-lulu@redhat.com>
2023-11-06  7:27   ` [RFC v1 3/8] vhost: Add 3 new uapi to support iommufd Jason Wang
2023-11-06  7:30   ` Jason Wang
     [not found]     ` <CACLfguX9-wEQPUyZkJZoRMmgPDRFNyZCmt0nvHROhyP1yooiYA@mail.gmail.com>
2023-11-08  3:03       ` Jason Wang
2023-11-08  6:38         ` Cindy Lu
2023-11-08  7:09           ` Jason Wang
2023-11-10  2:31             ` Jason Wang
2023-11-10  6:49               ` Cindy Lu
2023-11-07  7:30 ` [RFC v1 0/8] vhost-vdpa: add support for iommufd Michael S. Tsirkin
     [not found]   ` <20231107124902.GJ4488@nvidia.com>
2023-11-07 13:28     ` Michael S. Tsirkin
     [not found]       ` <20231107141237.GO4488@nvidia.com>
2023-11-07 14:30         ` Michael S. Tsirkin
     [not found]           ` <20231107155217.GQ4488@nvidia.com>
2023-11-09 23:48             ` Michael S. Tsirkin
2023-11-10 14:00               ` Jason Gunthorpe
2023-11-07 14:55     ` Michael S. Tsirkin
     [not found]       ` <20231107154848.GP4488@nvidia.com>
2023-11-07 16:11         ` Michael S. Tsirkin [this message]
2023-11-07 13:23 ` Michael S. Tsirkin
2024-01-10 22:25 ` Michael S. Tsirkin
2024-01-11  9:02   ` Cindy Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231107105718-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).