From: Andrew Jones <ajones@ventanamicro.com>
To: kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
virtualization@lists.linux-foundation.org
Cc: anup@brainfault.org, atishp@atishpatra.org, pbonzini@redhat.com,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, jgross@suse.com, srivatsa@csail.mit.edu,
guoren@kernel.org, conor.dooley@microchip.com
Subject: [PATCH v3 00/13] RISC-V: Add steal-time support
Date: Sun, 17 Dec 2023 21:40:20 +0100 [thread overview]
Message-ID: <20231217204019.36492-15-ajones@ventanamicro.com> (raw)
One frequently touted benefit of virtualization is the ability to
consolidate machines, increasing resource utilization. It may even be
desirable to overcommit, at the risk of one or more VCPUs having to wait.
Hypervisors which have interfaces for guests to retrieve the amount of
time each VCPU had to wait give observers within the guests ways to
account for less progress than would otherwise be expected. The SBI STA
extension[1] provides a standard interface for guest VCPUs to retrieve
the amount of time "stolen".
This series has three parts:
1) Patches 01-03 - Add paravirt support to RISC-V and implement
steal-time accounting support using the SBI STA
extension.
2) Patches 04-09 - Implement SBI STA in KVM so KVM guests, such as
Linux guests which enable the paravirt steal-time
support, can be enlightened about stolen time.
3) Patches 10-13 - Add RISC-V support to the KVM selftests steal_time
test and the SBI extension regs in the get-reg-list
test.
These patches are based on kvm-riscv/riscv_kvm_queue
[1] https://github.com/riscv-non-isa/riscv-sbi-doc/blob/master/src/ext-steal-time.adoc
This patches are also available here
https://github.com/jones-drew/linux/commits/kvm/steal-time-v3
Changes since v2:
- Always check sequence in case the SBI impl isn't writing steal
atomically [Anup]
- Create a reset function for sta and also reset last_steal [Anup]
- Picked up Anup's r-b's
Changes since v1:
- sbi_sta_steal_time_set_shmem() now maps SBI errors to linux errors [Conor]
- Squashed v1 patch 4 into v1 patch 3 [Conor]
- Moved kvm_riscv_vcpu_set/get_reg_sbi() to arch/riscv/kvm/vcpu_sbi.c
which seems like a more appropriate file for them
- Rebased on kvm-riscv/riscv_kvm_queue which has all the dependencies
Changes since RFC:
- Rebased on v6.7-rc3 (plus the patches mentioned above)
- Added defines for the -1's [Conor]
- Added a comment to the steal read sequence [Conor]
- Only do the steal read sequence for 32-bit and added READ_ONCE's
- Check for SBI v2.0 implementation
- Rename set_steal_time_shmem to steal_time_set_shmem
- Add get-reg-list support and test with get-reg-list kselftest
- A few other minor improvements
- Picked up one r-b from Conor
Thanks,
drew
Andrew Jones (13):
RISC-V: paravirt: Add skeleton for pv-time support
RISC-V: Add SBI STA extension definitions
RISC-V: paravirt: Implement steal-time support
RISC-V: KVM: Add SBI STA extension skeleton
RISC-V: KVM: Add steal-update vcpu request
RISC-V: KVM: Add SBI STA info to vcpu_arch
RISC-V: KVM: Add support for SBI extension registers
RISC-V: KVM: Add support for SBI STA registers
RISC-V: KVM: Implement SBI STA extension
RISC-V: KVM: selftests: Move sbi_ecall to processor.c
RISC-V: KVM: selftests: Add guest_sbi_probe_extension
RISC-V: KVM: selftests: Add steal_time test support
RISC-V: KVM: selftests: Add get-reg-list test for STA registers
.../admin-guide/kernel-parameters.txt | 6 +-
arch/riscv/Kconfig | 19 ++
arch/riscv/include/asm/kvm_host.h | 10 +
arch/riscv/include/asm/kvm_vcpu_sbi.h | 10 +
arch/riscv/include/asm/paravirt.h | 28 +++
arch/riscv/include/asm/paravirt_api_clock.h | 1 +
arch/riscv/include/asm/sbi.h | 17 ++
arch/riscv/include/uapi/asm/kvm.h | 13 ++
arch/riscv/kernel/Makefile | 1 +
arch/riscv/kernel/paravirt.c | 134 +++++++++++
arch/riscv/kernel/time.c | 3 +
arch/riscv/kvm/Kconfig | 1 +
arch/riscv/kvm/Makefile | 1 +
arch/riscv/kvm/vcpu.c | 7 +
arch/riscv/kvm/vcpu_onereg.c | 50 ++++-
arch/riscv/kvm/vcpu_sbi.c | 67 ++++++
arch/riscv/kvm/vcpu_sbi_sta.c | 208 ++++++++++++++++++
tools/testing/selftests/kvm/Makefile | 5 +-
.../selftests/kvm/include/riscv/processor.h | 22 ++
.../selftests/kvm/lib/riscv/processor.c | 45 ++++
tools/testing/selftests/kvm/lib/riscv/ucall.c | 26 ---
.../selftests/kvm/riscv/get-reg-list.c | 43 ++++
tools/testing/selftests/kvm/steal_time.c | 99 +++++++++
23 files changed, 781 insertions(+), 35 deletions(-)
create mode 100644 arch/riscv/include/asm/paravirt.h
create mode 100644 arch/riscv/include/asm/paravirt_api_clock.h
create mode 100644 arch/riscv/kernel/paravirt.c
create mode 100644 arch/riscv/kvm/vcpu_sbi_sta.c
--
2.43.0
next reply other threads:[~2023-12-17 20:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 20:40 Andrew Jones [this message]
2023-12-17 20:40 ` [PATCH v3 01/13] RISC-V: paravirt: Add skeleton for pv-time support Andrew Jones
2023-12-19 0:48 ` Atish Patra
2023-12-19 14:29 ` Andrew Jones
2023-12-17 20:40 ` [PATCH v3 02/13] RISC-V: Add SBI STA extension definitions Andrew Jones
2023-12-19 0:49 ` Atish Patra
2023-12-17 20:40 ` [PATCH v3 03/13] RISC-V: paravirt: Implement steal-time support Andrew Jones
2023-12-19 1:41 ` Atish Patra
2023-12-20 6:41 ` Anup Patel
2023-12-17 20:40 ` [PATCH v3 04/13] RISC-V: KVM: Add SBI STA extension skeleton Andrew Jones
2023-12-19 1:42 ` Atish Patra
2023-12-17 20:40 ` [PATCH v3 05/13] RISC-V: KVM: Add steal-update vcpu request Andrew Jones
2023-12-19 1:46 ` Atish Patra
2023-12-17 20:40 ` [PATCH v3 06/13] RISC-V: KVM: Add SBI STA info to vcpu_arch Andrew Jones
2023-12-19 1:49 ` Atish Patra
2023-12-17 20:40 ` [PATCH v3 07/13] RISC-V: KVM: Add support for SBI extension registers Andrew Jones
2023-12-19 19:58 ` Atish Patra
2023-12-20 6:16 ` Andrew Jones
2023-12-20 6:19 ` Anup Patel
2023-12-20 6:32 ` Andrew Jones
2023-12-17 20:40 ` [PATCH v3 08/13] RISC-V: KVM: Add support for SBI STA registers Andrew Jones
2023-12-17 20:40 ` [PATCH v3 09/13] RISC-V: KVM: Implement SBI STA extension Andrew Jones
2023-12-19 21:52 ` Atish Patra
2023-12-17 20:40 ` [PATCH v3 10/13] RISC-V: KVM: selftests: Move sbi_ecall to processor.c Andrew Jones
2023-12-17 20:40 ` [PATCH v3 11/13] RISC-V: KVM: selftests: Add guest_sbi_probe_extension Andrew Jones
2023-12-19 21:57 ` Atish Patra
2023-12-20 6:28 ` Andrew Jones
2023-12-17 20:40 ` [PATCH v3 12/13] RISC-V: KVM: selftests: Add steal_time test support Andrew Jones
2023-12-19 23:39 ` Atish Patra
2023-12-17 20:40 ` [PATCH v3 13/13] RISC-V: KVM: selftests: Add get-reg-list test for STA registers Andrew Jones
2023-12-19 23:40 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217204019.36492-15-ajones@ventanamicro.com \
--to=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=conor.dooley@microchip.com \
--cc=guoren@kernel.org \
--cc=jgross@suse.com \
--cc=kvm-riscv@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=srivatsa@csail.mit.edu \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).