From: Dragos Tatulea <dtatulea@nvidia.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Eugenio Perez Martin <eperezma@redhat.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
<virtualization@lists.linux-foundation.org>,
Gal Pressman <gal@nvidia.com>
Cc: Dragos Tatulea <dtatulea@nvidia.com>, <kvm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Parav Pandit <parav@nvidia.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Subject: [PATCH vhost v4 11/15] vdpa/mlx5: Mark vq addrs for modification in hw vq
Date: Tue, 19 Dec 2023 20:08:54 +0200 [thread overview]
Message-ID: <20231219180858.120898-12-dtatulea@nvidia.com> (raw)
In-Reply-To: <20231219180858.120898-1-dtatulea@nvidia.com>
Addresses get set by .set_vq_address. hw vq addresses will be updated on
next modify_virtqueue.
Advertise that the device supports changing the vq addresses when
device is in DRIVER_OK state and suspended.
Reviewed-by: Gal Pressman <gal@nvidia.com>
Signed-off-by: Dragos Tatulea <dtatulea@nvidia.com>
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 17 ++++++++++++++++-
include/linux/mlx5/mlx5_ifc_vdpa.h | 1 +
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index f8f088cced50..93812683c88c 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1209,6 +1209,7 @@ static int modify_virtqueue(struct mlx5_vdpa_net *ndev,
bool state_change = false;
void *obj_context;
void *cmd_hdr;
+ void *vq_ctx;
void *in;
int err;
@@ -1230,6 +1231,7 @@ static int modify_virtqueue(struct mlx5_vdpa_net *ndev,
MLX5_SET(general_obj_in_cmd_hdr, cmd_hdr, uid, ndev->mvdev.res.uid);
obj_context = MLX5_ADDR_OF(modify_virtio_net_q_in, in, obj_context);
+ vq_ctx = MLX5_ADDR_OF(virtio_net_q_object, obj_context, virtio_q_context);
if (mvq->modified_fields & MLX5_VIRTQ_MODIFY_MASK_STATE) {
if (!is_valid_state_change(mvq->fw_state, state, is_resumable(ndev))) {
@@ -1241,6 +1243,12 @@ static int modify_virtqueue(struct mlx5_vdpa_net *ndev,
state_change = true;
}
+ if (mvq->modified_fields & MLX5_VIRTQ_MODIFY_MASK_VIRTIO_Q_ADDRS) {
+ MLX5_SET64(virtio_q, vq_ctx, desc_addr, mvq->desc_addr);
+ MLX5_SET64(virtio_q, vq_ctx, used_addr, mvq->device_addr);
+ MLX5_SET64(virtio_q, vq_ctx, available_addr, mvq->driver_addr);
+ }
+
MLX5_SET64(virtio_net_q_object, obj_context, modify_field_select, mvq->modified_fields);
err = mlx5_cmd_exec(ndev->mvdev.mdev, in, inlen, out, sizeof(out));
if (err)
@@ -2202,6 +2210,7 @@ static int mlx5_vdpa_set_vq_address(struct vdpa_device *vdev, u16 idx, u64 desc_
mvq->desc_addr = desc_area;
mvq->device_addr = device_area;
mvq->driver_addr = driver_area;
+ mvq->modified_fields |= MLX5_VIRTQ_MODIFY_MASK_VIRTIO_Q_ADDRS;
return 0;
}
@@ -2626,7 +2635,13 @@ static void unregister_link_notifier(struct mlx5_vdpa_net *ndev)
static u64 mlx5_vdpa_get_backend_features(const struct vdpa_device *vdpa)
{
- return BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK);
+ u64 features = BIT_ULL(VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK);
+ struct mlx5_vdpa_dev *mvdev = to_mvdev(vdpa);
+
+ if (MLX5_CAP_DEV_VDPA_EMULATION(mvdev->mdev, freeze_to_rdy_supported))
+ features |= BIT_ULL(VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND);
+
+ return features;
}
static int mlx5_vdpa_set_driver_features(struct vdpa_device *vdev, u64 features)
diff --git a/include/linux/mlx5/mlx5_ifc_vdpa.h b/include/linux/mlx5/mlx5_ifc_vdpa.h
index b86d51a855f6..9594ac405740 100644
--- a/include/linux/mlx5/mlx5_ifc_vdpa.h
+++ b/include/linux/mlx5/mlx5_ifc_vdpa.h
@@ -145,6 +145,7 @@ enum {
MLX5_VIRTQ_MODIFY_MASK_STATE = (u64)1 << 0,
MLX5_VIRTQ_MODIFY_MASK_DIRTY_BITMAP_PARAMS = (u64)1 << 3,
MLX5_VIRTQ_MODIFY_MASK_DIRTY_BITMAP_DUMP_ENABLE = (u64)1 << 4,
+ MLX5_VIRTQ_MODIFY_MASK_VIRTIO_Q_ADDRS = (u64)1 << 6,
MLX5_VIRTQ_MODIFY_MASK_DESC_GROUP_MKEY = (u64)1 << 14,
};
--
2.43.0
next prev parent reply other threads:[~2023-12-19 18:10 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 18:08 [PATCH vhost v4 00/15] vdpa/mlx5: Add support for resumable vqs Dragos Tatulea
2023-12-19 18:08 ` [PATCH mlx5-vhost v4 01/15] vdpa/mlx5: Expose resumable vq capability Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-20 4:05 ` Jason Wang
2023-12-20 12:57 ` Dragos Tatulea
2023-12-20 13:32 ` Eugenio Perez Martin
2023-12-21 2:03 ` Jason Wang
2023-12-21 7:46 ` Eugenio Perez Martin
2023-12-21 11:52 ` Dragos Tatulea
2023-12-21 12:08 ` Eugenio Perez Martin
2023-12-21 14:38 ` Dragos Tatulea
2023-12-21 14:55 ` Eugenio Perez Martin
2023-12-21 15:07 ` Dragos Tatulea
2023-12-22 7:30 ` Eugenio Perez Martin
2023-12-22 8:29 ` Michael S. Tsirkin
2023-12-22 10:51 ` Dragos Tatulea
2023-12-25 13:45 ` Dragos Tatulea
2023-12-22 2:50 ` Jason Wang
2023-12-20 16:09 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 03/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND flag Dragos Tatulea
2023-12-20 16:10 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 04/15] vdpa: Accept VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND backend feature Dragos Tatulea
2023-12-20 16:11 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 05/15] vdpa: Accept VHOST_BACKEND_F_CHANGEABLE_VQ_STATE_IN_SUSPEND " Dragos Tatulea
2023-12-20 16:12 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 06/15] vdpa: Track device suspended state Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-20 12:55 ` Dragos Tatulea
2023-12-22 11:22 ` Dragos Tatulea
2023-12-25 4:11 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 07/15] vdpa: Block vq address change in DRIVER_OK unless device supports it Dragos Tatulea
2023-12-20 16:31 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 08/15] vdpa: Block vq state " Dragos Tatulea
2023-12-20 16:32 ` Eugenio Perez Martin
2023-12-19 18:08 ` [PATCH vhost v4 09/15] vdpa/mlx5: Allow modifying multiple vq fields in one modify command Dragos Tatulea
2023-12-20 3:46 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 10/15] vdpa/mlx5: Introduce per vq and device resume Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` Dragos Tatulea [this message]
2023-12-19 18:08 ` [PATCH vhost v4 12/15] vdpa/mlx5: Mark vq state for modification in hw vq Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 13/15] vdpa/mlx5: Use vq suspend/resume during .set_map Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 14/15] vdpa/mlx5: Introduce reference counting to mrs Dragos Tatulea
2023-12-20 3:47 ` Jason Wang
2023-12-19 18:08 ` [PATCH vhost v4 15/15] vdpa/mlx5: Add mkey leak detection Dragos Tatulea
2023-12-25 14:41 ` [PATCH vhost v4 00/15] vdpa/mlx5: Add support for resumable vqs Michael S. Tsirkin
2023-12-25 15:05 ` Dragos Tatulea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231219180858.120898-12-dtatulea@nvidia.com \
--to=dtatulea@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gal@nvidia.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox