From: Stefan Hajnoczi <stefanha@redhat.com>
To: Yi Sun <yi.sun@unisoc.com>
Cc: axboe@kernel.dk, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, pbonzini@redhat.com,
virtualization@lists.linux.dev, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, zhiguo.niu@unisoc.com,
hongyu.jin@unisoc.com, sunyibuaa@gmail.com
Subject: Re: [PATCH 2/2] virtio-blk: Ensure no requests in virtqueues before deleting vqs.
Date: Mon, 22 Jan 2024 10:42:55 -0500 [thread overview]
Message-ID: <20240122154255.GA389442@fedora> (raw)
In-Reply-To: <20240122110722.690223-3-yi.sun@unisoc.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On Mon, Jan 22, 2024 at 07:07:22PM +0800, Yi Sun wrote:
> Ensure no remaining requests in virtqueues before resetting vdev and
> deleting virtqueues. Otherwise these requests will never be completed.
> It may cause the system to become unresponsive. So it is better to place
> blk_mq_quiesce_queue() in front of virtio_reset_device().
QEMU's virtio-blk device implementation completes all requests during
device reset. Most device implementations have to do the same to avoid
leaving dangling requests in flight across device reset.
Which device implementation are you using and why is it safe for the
device is simply drop requests across device reset?
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-01-22 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 11:07 [PATCH 0/2] Fix requests loss during virtio-blk device suspend Yi Sun
2024-01-22 11:07 ` [PATCH 1/2] blk-mq: introduce blk_mq_tagset_wait_request_completed() Yi Sun
2024-01-23 18:45 ` kernel test robot
2024-01-23 19:14 ` Keith Busch
2024-01-24 11:22 ` yi sun
2024-01-24 17:17 ` Keith Busch
2024-01-22 11:07 ` [PATCH 2/2] virtio-blk: Ensure no requests in virtqueues before deleting vqs Yi Sun
2024-01-22 15:42 ` Stefan Hajnoczi [this message]
2024-01-23 3:27 ` yi sun
2024-01-23 15:09 ` Stefan Hajnoczi
2024-01-24 7:38 ` yi sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122154255.GA389442@fedora \
--to=stefanha@redhat.com \
--cc=axboe@kernel.dk \
--cc=hongyu.jin@unisoc.com \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sunyibuaa@gmail.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yi.sun@unisoc.com \
--cc=zhiguo.niu@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).