From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Damien Le Moal <dlemoal@kernel.org>,
Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
virtualization@lists.linux.dev, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 01/14] block: move max_{open,active}_zones to struct queue_limits
Date: Mon, 29 Jan 2024 07:15:53 +0100 [thread overview]
Message-ID: <20240129061553.GA19581@lst.de> (raw)
In-Reply-To: <a0d499e7-ec2d-44f8-9b13-b1ef857e4c14@acm.org>
On Sun, Jan 28, 2024 at 03:32:32PM -0800, Bart Van Assche wrote:
>> @@ -307,6 +305,8 @@ struct queue_limits {
>> unsigned char discard_misaligned;
>> unsigned char raid_partial_stripes_expensive;
>> bool zoned;
>> + unsigned int max_open_zones;
>> + unsigned int max_active_zones;
>
> Not all struct queue_limits instances are associated with a gendisk. Do we need
> a way to separate the limits that apply to all request queues from the limits
> that only apply to disks in struct queue_limits, e.g. a comment that separates
> the two?
I've actually been thinking about that for a while. It does sound like
a good idea but I wonder how practical it is. But that is on the table
for after we've sorted out the basic API problems, as that makes
splitting it much easier if we do that eventually.
next prev parent reply other threads:[~2024-01-29 6:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 16:57 atomic queue limits updates v2 Christoph Hellwig
2024-01-28 16:58 ` [PATCH 01/14] block: move max_{open,active}_zones to struct queue_limits Christoph Hellwig
2024-01-28 23:32 ` Bart Van Assche
2024-01-29 6:15 ` Christoph Hellwig [this message]
2024-01-28 16:58 ` [PATCH 02/14] block: refactor disk_update_readahead Christoph Hellwig
2024-01-29 2:59 ` Bart Van Assche
2024-01-29 6:16 ` Christoph Hellwig
2024-01-28 16:58 ` [PATCH 03/14] block: add an API to atomically update queue limits Christoph Hellwig
2024-01-29 6:11 ` Hannes Reinecke
2024-01-30 11:46 ` John Garry
2024-01-30 14:41 ` Christoph Hellwig
2024-01-30 15:05 ` John Garry
2024-01-28 16:58 ` [PATCH 04/14] block: use queue_limits_commit_update in queue_max_sectors_store Christoph Hellwig
2024-01-30 12:14 ` John Garry
2024-01-30 14:43 ` Christoph Hellwig
2024-01-28 16:58 ` [PATCH 05/14] block: add a max_user_discard_sectors queue limit Christoph Hellwig
2024-01-29 6:13 ` Hannes Reinecke
2024-01-28 16:58 ` [PATCH 06/14] block: use queue_limits_commit_update in queue_discard_max_store Christoph Hellwig
2024-01-28 16:58 ` [PATCH 07/14] block: pass a queue_limits argument to blk_alloc_queue Christoph Hellwig
2024-01-30 12:48 ` John Garry
2024-01-28 16:58 ` [PATCH 08/14] block: pass a queue_limits argument to blk_mq_init_queue Christoph Hellwig
2024-01-30 12:38 ` John Garry
2024-01-28 16:58 ` [PATCH 09/14] block: pass a queue_limits argument to blk_mq_alloc_disk Christoph Hellwig
2024-01-30 12:52 ` John Garry
2024-01-28 16:58 ` [PATCH 10/14] virtio_blk: split virtblk_probe Christoph Hellwig
2024-01-28 16:58 ` [PATCH 11/14] virtio_blk: pass queue_limits to blk_mq_alloc_disk Christoph Hellwig
2024-01-28 16:58 ` [PATCH 12/14] loop: cleanup loop_config_discard Christoph Hellwig
2024-01-28 16:58 ` [PATCH 13/14] loop: pass queue_limits to blk_mq_alloc_disk Christoph Hellwig
2024-01-28 16:58 ` [PATCH 14/14] loop: use the atomic queue limits update API Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2024-01-31 13:03 atomic queue limits updates v3 Christoph Hellwig
2024-01-31 13:03 ` [PATCH 01/14] block: move max_{open,active}_zones to struct queue_limits Christoph Hellwig
2024-01-31 23:10 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129061553.GA19581@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=dlemoal@kernel.org \
--cc=hare@suse.de \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sagi@grimberg.me \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).