From: Zhu Lingshan <lingshan.zhu@intel.com>
To: jasowang@redhat.com, mst@redhat.com
Cc: virtualization@lists.linux.dev, Zhu Lingshan <lingshan.zhu@intel.com>
Subject: [PATCH 06/10] vDPA: report virtio-block topology info to user space
Date: Mon, 19 Feb 2024 02:56:02 +0800 [thread overview]
Message-ID: <20240218185606.13509-7-lingshan.zhu@intel.com> (raw)
In-Reply-To: <20240218185606.13509-1-lingshan.zhu@intel.com>
This commit allows vDPA reporting topology information of
virtio-blk devices to user space, includes:
1) the number of logical blocks per physical block
2) offset of first aligned logical block
3) suggested minimum I/O size in blocks
4) optimal (suggested maximum) I/O size in blocks
Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
---
drivers/vdpa/vdpa.c | 32 ++++++++++++++++++++++++++++++++
include/uapi/linux/vdpa.h | 4 ++++
2 files changed, 36 insertions(+)
diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
index 26e8768b869a..dfd9aa5779dc 100644
--- a/drivers/vdpa/vdpa.c
+++ b/drivers/vdpa/vdpa.c
@@ -1012,6 +1012,35 @@ static int vdpa_dev_blk_mq_config_fill(struct sk_buff *msg, u64 features,
return nla_put_u16(msg, VDPA_ATTR_DEV_BLK_CFG_NUM_QUEUES, val_u16);
}
+static int vdpa_dev_blk_topology_config_fill(struct sk_buff *msg, u64 features,
+ const struct virtio_blk_config *config)
+{
+ u16 min_io_size;
+ u32 opt_io_size;
+
+ if ((features & BIT_ULL(VIRTIO_BLK_F_TOPOLOGY)) == 0)
+ return 0;
+
+ min_io_size = __virtio16_to_cpu(true, config->min_io_size);
+ opt_io_size = __virtio32_to_cpu(true, config->opt_io_size);
+
+ if (nla_put_u8(msg, VDPA_ATTR_DEV_BLK_CFG_PHY_BLK_EXP,
+ config->physical_block_exp))
+ return -EMSGSIZE;
+
+ if (nla_put_u8(msg, VDPA_ATTR_DEV_BLK_CFG_ALIGN_OFFSET,
+ config->alignment_offset))
+ return -EMSGSIZE;
+
+ if (nla_put_u16(msg, VDPA_ATTR_DEV_BLK_CFG_MIN_IO_SIZE, min_io_size))
+ return -EMSGSIZE;
+
+ if (nla_put_u32(msg, VDPA_ATTR_DEV_BLK_CFG_OPT_IO_SIZE, opt_io_size))
+ return -EMSGSIZE;
+
+ return 0;
+}
+
static int vdpa_dev_blk_config_fill(struct vdpa_device *vdev,
struct sk_buff *msg)
{
@@ -1041,6 +1070,9 @@ static int vdpa_dev_blk_config_fill(struct vdpa_device *vdev,
if (vdpa_dev_blk_mq_config_fill(msg, features_device, &config))
return -EMSGSIZE;
+ if (vdpa_dev_blk_topology_config_fill(msg, features_device, &config))
+ return -EMSGSIZE;
+
return 0;
}
diff --git a/include/uapi/linux/vdpa.h b/include/uapi/linux/vdpa.h
index 3c8e3c87a864..5cc70614c97a 100644
--- a/include/uapi/linux/vdpa.h
+++ b/include/uapi/linux/vdpa.h
@@ -61,6 +61,10 @@ enum vdpa_attr {
VDPA_ATTR_DEV_BLK_CFG_BLK_SIZE, /* u32 */
VDPA_ATTR_DEV_BLK_CFG_SEG_MAX, /* u32 */
VDPA_ATTR_DEV_BLK_CFG_NUM_QUEUES, /* u16 */
+ VDPA_ATTR_DEV_BLK_CFG_PHY_BLK_EXP, /* u8 */
+ VDPA_ATTR_DEV_BLK_CFG_ALIGN_OFFSET, /* u8 */
+ VDPA_ATTR_DEV_BLK_CFG_MIN_IO_SIZE, /* u16 */
+ VDPA_ATTR_DEV_BLK_CFG_OPT_IO_SIZE, /* u32 */
/* new attributes must be added above here */
VDPA_ATTR_MAX,
--
2.39.3
next prev parent reply other threads:[~2024-02-18 10:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 18:55 [PATCH 00/10] vDPA: allow userspace query virito-block device Zhu Lingshan
2024-02-18 18:55 ` [PATCH 01/10] vDPA: report virtio-block capacity to user space Zhu Lingshan
2024-03-19 16:43 ` Stefano Garzarella
2024-02-18 18:55 ` [PATCH 02/10] vDPA: report virtio-block max segment size " Zhu Lingshan
2024-03-19 16:04 ` Stefano Garzarella
2024-03-29 14:48 ` Zhu, Lingshan
2024-03-31 20:03 ` Michael S. Tsirkin
2024-02-18 18:55 ` [PATCH 03/10] vDPA: report virtio-block block-size " Zhu Lingshan
2024-03-19 16:43 ` Stefano Garzarella
2024-02-18 18:56 ` [PATCH 04/10] vDPA: report virtio-block max segments in a request " Zhu Lingshan
2024-03-19 16:43 ` Stefano Garzarella
2024-02-18 18:56 ` [PATCH 05/10] vDPA: report virtio-block MQ info " Zhu Lingshan
2024-03-19 16:44 ` Stefano Garzarella
2024-02-18 18:56 ` Zhu Lingshan [this message]
2024-03-19 16:44 ` [PATCH 06/10] vDPA: report virtio-block topology " Stefano Garzarella
2024-02-18 18:56 ` [PATCH 07/10] vDPA: report virtio-block discarding configuration " Zhu Lingshan
2024-03-19 16:44 ` Stefano Garzarella
2024-02-18 18:56 ` [PATCH 08/10] vDPA: report virtio-block write zeroes " Zhu Lingshan
2024-03-19 16:36 ` Stefano Garzarella
2024-03-19 17:02 ` Michael S. Tsirkin
2024-03-19 17:08 ` Stefano Garzarella
2024-03-19 17:57 ` Michael S. Tsirkin
2024-02-18 18:56 ` [PATCH 09/10] vDPA: report virtio-block read-only info " Zhu Lingshan
2024-03-19 16:40 ` Stefano Garzarella
2024-04-09 8:37 ` Zhu, Lingshan
2024-05-03 12:18 ` Stefano Garzarella
2024-02-18 18:56 ` [PATCH 10/10] vDPA: report virtio-blk flush " Zhu Lingshan
2024-03-19 16:42 ` Stefano Garzarella
2024-03-19 6:39 ` [PATCH 00/10] vDPA: allow userspace query virito-block device Michael S. Tsirkin
2024-03-20 3:30 ` Jason Wang
2024-03-20 7:00 ` Michael S. Tsirkin
2024-03-19 16:49 ` Stefano Garzarella
2024-03-20 10:31 ` Zhu, Lingshan
2024-03-20 10:53 ` Stefano Garzarella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240218185606.13509-7-lingshan.zhu@intel.com \
--to=lingshan.zhu@intel.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).