Re: [PATCH 00/10] vDPA: allow userspace query virito-block device

["Michael S. Tsirkin" <mst@redhat.com>]

On Wed, Mar 20, 2024 at 11:30:57AM +0800, Jason Wang wrote:
> On Tue, Mar 19, 2024 at 2:40 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Mon, Feb 19, 2024 at 02:55:56AM +0800, Zhu Lingshan wrote:
> > > This series allows the user space applications query vDPA virtio-block
> > > device inforamtion.
> > >
> > > testing on vdpa_sim_blk, iproute2 output:
> > > sudo ./vdpa/vdpa dev config show -jp vdpa_blk0
> > > {
> > >     "config": {
> > >         "vdpa_blk0": {
> > >             "capacity": 262144,
> > >             "segment size": 4096,
> > >             "block size": 512,
> > >             "max segments in a request": 32,
> > >             "num of queues": 1,
> > >             "logical blocks per physical block (log2)": 0,
> > >             "offset of first aligned logical block": 0,
> > >             "minimum io size": 1,
> > >             "optimal io size": 1,
> > >             "maximum discard sectors for a segment": 4294967295,
> > >             "max discard segments in a command": 1,
> > >             "discard sector alignment": 512,
> > >             "max write zeros sectors in a segment": 4294967295,
> > >             "max write zero segments": 1,
> > >             "read only": false,
> > >             "flush command support": true
> > >         }
> > >     }
> > > }
> > >
> > > Please help review
> > >
> > > Thanks
> > > Zhu Lingshan
> >
> > It's been in my tree for a while so it will be in the next pull,
> > but going forward Jason I'd like to know what kind of
> > timeline do you have in mind for reviewing vdpa patches?
> 
> I think there are some misunderstandings here.
> 
> I usually try my best to offer a review.
> 
> This series was posted during my vacation, and when I came back after
> the vacation it was merged into your tree. I'd expect you are fine
> with the patches.

Yes.

> If that doesn't work, maybe we can start to do something like:
> 
> vDPA patches needs my ack before it can be merged
> 
> Does it work?
> 
> Thanks

We have redundancy in review, it's not a problem by itself.
If you are going on an extended vacation, it's a good idea
to make this fact public so people know whether to expect your review.

> >
> > > Zhu Lingshan (10):
> > >   vDPA: report virtio-block capacity to user space
> > >   vDPA: report virtio-block max segment size to user space
> > >   vDPA: report virtio-block block-size to user space
> > >   vDPA: report virtio-block max segments in a request to user space
> > >   vDPA: report virtio-block MQ info to user space
> > >   vDPA: report virtio-block topology info to user space
> > >   vDPA: report virtio-block discarding configuration to user space
> > >   vDPA: report virtio-block write zeroes configuration to user space
> > >   vDPA: report virtio-block read-only info to user space
> > >   vDPA: report virtio-blk flush info to user space
> > >
> > >  drivers/vdpa/vdpa.c       | 212 ++++++++++++++++++++++++++++++++++++++
> > >  include/linux/vdpa.h      |   1 +
> > >  include/uapi/linux/vdpa.h |  17 +++
> > >  3 files changed, 230 insertions(+)
> > >
> > > --
> > > 2.39.3
> >