From: "Michael S. Tsirkin" <mst@redhat.com>
To: Srujana Challa <schalla@marvell.com>
Cc: Jason Wang <jasowang@redhat.com>,
"virtualization@lists.linux.dev" <virtualization@lists.linux.dev>,
"xuanzhuo@linux.alibaba.com" <xuanzhuo@linux.alibaba.com>,
Vamsi Krishna Attunuru <vattunuru@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Jerin Jacob <jerinj@marvell.com>, eperezma <eperezma@redhat.com>
Subject: Re: [EXTERNAL] Re: [PATCH] virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices
Date: Sun, 31 Mar 2024 07:31:34 -0400 [thread overview]
Message-ID: <20240331072925-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <DS0PR18MB53686F5F53AF5D26B7CE37B6A03A2@DS0PR18MB5368.namprd18.prod.outlook.com>
On Fri, Mar 29, 2024 at 12:34:34PM +0000, Srujana Challa wrote:
> > > +static void octep_vdpa_set_config(struct vdpa_device *vdpa_dev, unsigned
> > int offset,
> > > + const void *buf, unsigned int len)
> > > +{
> > > + /* Not supported */
> >
> > We probably need to filter out VIRTIO_NET_F_ANNOUNCE and other
> > features that depend on the config writing.
> As per modern virtio spec(v1.2), device config is read only for the driver.
> Still do we need to filter out these features?
Yes I didn't get this either. What is VIRTIO_NET_F_ANNOUNCE?
VIRTIO_NET_F_GUEST_ANNOUNCE? And how does it depend on config
writing?
--
MST
next prev parent reply other threads:[~2024-03-31 11:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 11:21 [PATCH] virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices Srujana Challa
2024-03-29 4:28 ` Jason Wang
2024-03-29 12:34 ` [EXTERNAL] " Srujana Challa
2024-03-31 11:31 ` Michael S. Tsirkin [this message]
2024-04-07 3:24 ` Jason Wang
2024-04-07 3:34 ` Jason Wang
2024-04-10 10:15 ` Srujana Challa
2024-04-10 11:19 ` Michael S. Tsirkin
2024-04-10 12:34 ` Srujana Challa
2024-04-11 6:01 ` Jason Wang
2024-04-12 5:12 ` Srujana Challa
2024-04-12 6:41 ` Jason Wang
2024-04-12 9:48 ` Srujana Challa
2024-04-15 6:49 ` Jason Wang
2024-04-15 12:42 ` Srujana Challa
2024-04-16 3:17 ` Jason Wang
2024-04-22 20:42 ` Michael S. Tsirkin
2024-04-24 13:05 ` Srujana Challa
2024-04-23 5:40 ` Srujana Challa
2024-04-11 5:59 ` Jason Wang
2024-03-29 11:37 ` Stefano Garzarella
2024-03-29 13:02 ` [EXTERNAL] " Srujana Challa
2024-03-29 13:19 ` Stefano Garzarella
2024-04-10 12:40 ` Srujana Challa
2024-04-22 20:44 ` Michael S. Tsirkin
2024-04-24 19:08 ` [PATCH v2] " Srujana Challa
2024-04-25 1:57 ` Jason Wang
2024-04-25 9:36 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240331072925-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=schalla@marvell.com \
--cc=sthotton@marvell.com \
--cc=vattunuru@marvell.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).