From: Halil Pasic <pasic@linux.ibm.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: virtualization@lists.linux.dev,
"Richard Weinberger" <richard@nod.at>,
"Anton Ivanov" <anton.ivanov@cambridgegreys.com>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Vadim Pasternak" <vadimp@nvidia.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Cornelia Huck" <cohuck@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Sven Schnelle" <svens@linux.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
linux-um@lists.infradead.org,
platform-driver-x86@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, "Halil Pasic" <pasic@linux.ibm.com>
Subject: Re: [PATCH vhost v7 2/6] virtio: remove support for names array entries being null.
Date: Tue, 2 Apr 2024 20:01:03 +0200 [thread overview]
Message-ID: <20240402200103.19618d0c.pasic@linux.ibm.com> (raw)
In-Reply-To: <20240328080348.3620-3-xuanzhuo@linux.alibaba.com>
On Thu, 28 Mar 2024 16:03:44 +0800
Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -659,7 +659,7 @@ static int virtio_ccw_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> {
> struct virtio_ccw_device *vcdev = to_vc_device(vdev);
> unsigned long *indicatorp = NULL;
> - int ret, i, queue_idx = 0;
> + int ret, i;
> struct ccw1 *ccw;
>
> ccw = ccw_device_dma_zalloc(vcdev->cdev, sizeof(*ccw));
> @@ -668,11 +668,11 @@ static int virtio_ccw_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>
> for (i = 0; i < nvqs; ++i) {
> if (!names[i]) {
> - vqs[i] = NULL;
> - continue;
> + ret = -EINVAL;
> + goto out;
> }
>
> - vqs[i] = virtio_ccw_setup_vq(vdev, queue_idx++, callbacks[i],
> + vqs[i] = virtio_ccw_setup_vq(vdev, i, callbacks[i],
> names[i], ctx ? ctx[i] : false,
> ccw);
> if (IS_ERR(vqs[i])) {
For the virtio-ccw part:
Acked-by: Halil Pasic <pasic@linux.ibm.com>
next prev parent reply other threads:[~2024-04-02 18:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 8:03 [PATCH vhost v7 0/6] refactor the params of find_vqs() Xuan Zhuo
2024-03-28 8:03 ` [PATCH vhost v7 1/6] virtio_balloon: remove the dependence where names[] is null Xuan Zhuo
2024-03-28 8:03 ` [PATCH vhost v7 2/6] virtio: remove support for names array entries being null Xuan Zhuo
2024-04-01 19:02 ` Eric Farman
2024-04-02 18:01 ` Halil Pasic [this message]
2024-03-28 8:03 ` [PATCH vhost v7 3/6] virtio: find_vqs: pass struct instead of multi parameters Xuan Zhuo
2024-04-01 19:06 ` Eric Farman
2024-04-02 20:35 ` Halil Pasic
2024-03-28 8:03 ` [PATCH vhost v7 4/6] virtio: vring_create_virtqueue: " Xuan Zhuo
2024-04-01 19:07 ` Eric Farman
2024-04-02 20:42 ` Halil Pasic
2024-03-28 8:03 ` [PATCH vhost v7 5/6] virtio: vring_new_virtqueue(): " Xuan Zhuo
2024-03-28 8:06 ` Jason Wang
2024-03-28 8:03 ` [PATCH vhost v7 6/6] virtio_ring: simplify the parameters of the funcs related to vring_create/new_virtqueue() Xuan Zhuo
2024-04-01 19:57 ` [PATCH vhost v7 0/6] refactor the params of find_vqs() Eric Farman
2024-04-07 6:07 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402200103.19618d0c.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=andersson@kernel.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=farman@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=kvm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=richard@nod.at \
--cc=svens@linux.ibm.com \
--cc=vadimp@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).