From: Heng Qi <hengqi@linux.alibaba.com>
To: netdev@vger.kernel.org, virtualization@lists.linux.dev
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Brett Creeley" <bcreeley@amd.com>,
"Ratheesh Kannoth" <rkannoth@marvell.com>,
"Alexander Lobakin" <aleksander.lobakin@intel.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Tal Gilboa" <talgi@nvidia.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-doc@vger.kernel.org,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Paul Greenwalt" <paul.greenwalt@intel.com>,
"Ahmed Zaki" <ahmed.zaki@intel.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Kory Maincent" <kory.maincent@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
justinstitt@google.com, donald.hunter@gmail.com,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dragos Tatulea" <dtatulea@nvidia.com>,
"Rahul Rameshbabu" <rrameshbabu@nvidia.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"awel Dembicki" <paweldembicki@gmail.com>
Subject: [PATCH RESEND net-next v14 0/5] ethtool: provide the dim profile fine-tuning channel
Date: Tue, 18 Jun 2024 10:56:39 +0800 [thread overview]
Message-ID: <20240618025644.25754-1-hengqi@linux.alibaba.com> (raw)
The NetDIM library provides excellent acceleration for many modern
network cards. However, the default profiles of DIM limits its maximum
capabilities for different NICs, so providing a way which the NIC can
be custom configured is necessary.
Currently, the way is based on the commonly used "ethtool -C".
Please review, thank you very much!
Changelog
=====
Jakub feedback: Use RESEND to refresh the review queue.
v13->v14:
- Make DIMLIB dependent on NET (patch 2/5).
v12->v13:
- Rebase net-next to fix the one-line conflict.
- Update tiny comments.
- Config ETHTOOL_NETLINK to select DIMLIB.
v11->v12:
- Remove the use of IS_ENABLED(DIMLIB).
- Update Simon's htmldoc hint.
v10->v11:
- Fix and clean up some issues from Kuba, thanks.
- Rebase net-next/main
v9->v10:
- Collect dim related flags/mode/work into one place.
- Use rx_profile + tx_profile instead of four profiles.
- Add several helps.
- Update commit logs.
v8->v9:
- Fix the compilation error of conflicting names of rx_profile in
dim.h and ice driver: in dim.h, rx_profile is replaced with
dim_rx_profile. So does tx_profile.
v7->v8:
- Use kmemdup() instead of kzalloc()/memcpy() in dev_dim_profile_init().
v6->v7:
- A new wrapper struct pointer is used in struct net_device.
- Add IS_ENABLED(CONFIG_DIMLIB) to avoid compiler warnings.
- Profile fields changed from u16 to u32.
v5->v6:
- Place the profile in netdevice to bypass the driver.
The interaction code of ethtool <-> kernel has not changed at all,
only the interaction part of kernel <-> driver has changed.
v4->v5:
- Update some snippets from Kuba.
v3->v4:
- Some tiny updates and patch 1 only add a new comment.
v2->v3:
- Break up the attributes to avoid the use of raw c structs.
- Use per-device profile instead of global profile in the driver.
v1->v2:
- Use ethtool tool instead of net-sysfs.
Heng Qi (5):
linux/dim: move useful macros to .h file
dim: make DIMLIB dependent on NET
ethtool: provide customized dim profile management
dim: add new interfaces for initialization and getting results
virtio-net: support dim profile fine-tuning
Documentation/netlink/specs/ethtool.yaml | 31 +++
Documentation/networking/ethtool-netlink.rst | 4 +
Documentation/networking/net_dim.rst | 42 +++
drivers/net/virtio_net.c | 54 +++-
drivers/soc/fsl/Kconfig | 2 +-
include/linux/dim.h | 113 ++++++++
include/linux/ethtool.h | 4 +-
include/linux/netdevice.h | 3 +
include/uapi/linux/ethtool_netlink.h | 22 ++
lib/Kconfig | 1 +
lib/dim/net_dim.c | 144 +++++++++-
net/Kconfig | 1 +
net/ethtool/coalesce.c | 263 ++++++++++++++++++-
13 files changed, 667 insertions(+), 17 deletions(-)
--
2.32.0.3.g01195cf9f
next reply other threads:[~2024-06-18 2:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 2:56 Heng Qi [this message]
2024-06-18 2:56 ` [PATCH RESEND net-next v14 1/5] linux/dim: move useful macros to .h file Heng Qi
2024-06-20 12:11 ` Simon Horman
2024-06-18 2:56 ` [PATCH RESEND net-next v14 2/5] dim: make DIMLIB dependent on NET Heng Qi
2024-06-20 12:12 ` Simon Horman
2024-06-18 2:56 ` [PATCH RESEND net-next v14 3/5] ethtool: provide customized dim profile management Heng Qi
2024-06-20 12:13 ` Simon Horman
2024-06-21 3:39 ` Jakub Kicinski
2024-06-21 6:28 ` Heng Qi
2024-06-21 3:44 ` Jakub Kicinski
2024-06-21 6:33 ` Heng Qi
2024-06-18 2:56 ` [PATCH RESEND net-next v14 4/5] dim: add new interfaces for initialization and getting results Heng Qi
2024-06-20 12:13 ` Simon Horman
2024-06-18 2:56 ` [PATCH RESEND net-next v14 5/5] virtio-net: support dim profile fine-tuning Heng Qi
2024-06-20 12:13 ` Simon Horman
2024-06-21 3:40 ` [PATCH RESEND net-next v14 0/5] ethtool: provide the dim profile fine-tuning channel Jakub Kicinski
2024-06-21 3:44 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240618025644.25754-1-hengqi@linux.alibaba.com \
--to=hengqi@linux.alibaba.com \
--cc=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew@lunn.ch \
--cc=bcreeley@amd.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hkallweit1@gmail.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=justinstitt@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=paweldembicki@gmail.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rkannoth@marvell.com \
--cc=rrameshbabu@nvidia.com \
--cc=talgi@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=vladimir.oltean@nxp.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).