* [PATCH] virtio: add missing MODULE_DESCRIPTION() macro
@ 2024-06-02 20:25 Jeff Johnson
2024-06-23 17:36 ` Jeff Johnson
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Johnson @ 2024-06-02 20:25 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez
Cc: virtualization, linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/virtio/virtio_dma_buf.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/virtio/virtio_dma_buf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/virtio/virtio_dma_buf.c b/drivers/virtio/virtio_dma_buf.c
index 2521a75009c3..3034a2f605c8 100644
--- a/drivers/virtio/virtio_dma_buf.c
+++ b/drivers/virtio/virtio_dma_buf.c
@@ -85,5 +85,6 @@ int virtio_dma_buf_get_uuid(struct dma_buf *dma_buf,
}
EXPORT_SYMBOL(virtio_dma_buf_get_uuid);
+MODULE_DESCRIPTION("dma-bufs for virtio exported objects");
MODULE_LICENSE("GPL");
MODULE_IMPORT_NS(DMA_BUF);
---
base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
change-id: 20240602-md-virtio_dma_buf-b3552ca6c5d5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] virtio: add missing MODULE_DESCRIPTION() macro
2024-06-02 20:25 [PATCH] virtio: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-23 17:36 ` Jeff Johnson
2024-07-11 18:43 ` Jeff Johnson
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Johnson @ 2024-06-23 17:36 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez
Cc: virtualization, linux-kernel, kernel-janitors
On 6/2/2024 1:25 PM, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/virtio/virtio_dma_buf.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/virtio/virtio_dma_buf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/virtio/virtio_dma_buf.c b/drivers/virtio/virtio_dma_buf.c
> index 2521a75009c3..3034a2f605c8 100644
> --- a/drivers/virtio/virtio_dma_buf.c
> +++ b/drivers/virtio/virtio_dma_buf.c
> @@ -85,5 +85,6 @@ int virtio_dma_buf_get_uuid(struct dma_buf *dma_buf,
> }
> EXPORT_SYMBOL(virtio_dma_buf_get_uuid);
>
> +MODULE_DESCRIPTION("dma-bufs for virtio exported objects");
> MODULE_LICENSE("GPL");
> MODULE_IMPORT_NS(DMA_BUF);
>
> ---
> base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
> change-id: 20240602-md-virtio_dma_buf-b3552ca6c5d5
>
Following up to see if anything else is needed from me.
Hoping to see this in linux-next :)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] virtio: add missing MODULE_DESCRIPTION() macro
2024-06-23 17:36 ` Jeff Johnson
@ 2024-07-11 18:43 ` Jeff Johnson
2024-07-11 19:22 ` Michael S. Tsirkin
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Johnson @ 2024-07-11 18:43 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Greg Kroah-Hartman
Cc: virtualization, linux-kernel, kernel-janitors
On 6/23/24 10:36, Jeff Johnson wrote:
> On 6/2/2024 1:25 PM, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/virtio/virtio_dma_buf.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/virtio/virtio_dma_buf.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/virtio/virtio_dma_buf.c b/drivers/virtio/virtio_dma_buf.c
>> index 2521a75009c3..3034a2f605c8 100644
>> --- a/drivers/virtio/virtio_dma_buf.c
>> +++ b/drivers/virtio/virtio_dma_buf.c
>> @@ -85,5 +85,6 @@ int virtio_dma_buf_get_uuid(struct dma_buf *dma_buf,
>> }
>> EXPORT_SYMBOL(virtio_dma_buf_get_uuid);
>>
>> +MODULE_DESCRIPTION("dma-bufs for virtio exported objects");
>> MODULE_LICENSE("GPL");
>> MODULE_IMPORT_NS(DMA_BUF);
>>
>> ---
>> base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
>> change-id: 20240602-md-virtio_dma_buf-b3552ca6c5d5
>>
>
> Following up to see if anything else is needed from me.
> Hoping to see this in linux-next :)
I still don't see this in linux-next so following up to see if anything
else is needed to get this merged. Adding Greg KH since he's signed off
on this file before and he's taken quite a few of my cleanups through
his trees.
I'm hoping to have all of these warnings fixed tree-wide in 6.11.
/jeff
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] virtio: add missing MODULE_DESCRIPTION() macro
2024-07-11 18:43 ` Jeff Johnson
@ 2024-07-11 19:22 ` Michael S. Tsirkin
0 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2024-07-11 19:22 UTC (permalink / raw)
To: Jeff Johnson
Cc: Jason Wang, Xuan Zhuo, Eugenio Pérez, Greg Kroah-Hartman,
virtualization, linux-kernel, kernel-janitors
On Thu, Jul 11, 2024 at 11:43:18AM -0700, Jeff Johnson wrote:
> On 6/23/24 10:36, Jeff Johnson wrote:
> > On 6/2/2024 1:25 PM, Jeff Johnson wrote:
> > > make allmodconfig && make W=1 C=1 reports:
> > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/virtio/virtio_dma_buf.o
> > >
> > > Add the missing invocation of the MODULE_DESCRIPTION() macro.
> > >
> > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > > ---
> > > drivers/virtio/virtio_dma_buf.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/virtio/virtio_dma_buf.c b/drivers/virtio/virtio_dma_buf.c
> > > index 2521a75009c3..3034a2f605c8 100644
> > > --- a/drivers/virtio/virtio_dma_buf.c
> > > +++ b/drivers/virtio/virtio_dma_buf.c
> > > @@ -85,5 +85,6 @@ int virtio_dma_buf_get_uuid(struct dma_buf *dma_buf,
> > > }
> > > EXPORT_SYMBOL(virtio_dma_buf_get_uuid);
> > > +MODULE_DESCRIPTION("dma-bufs for virtio exported objects");
> > > MODULE_LICENSE("GPL");
> > > MODULE_IMPORT_NS(DMA_BUF);
> > >
> > > ---
> > > base-commit: 83814698cf48ce3aadc5d88a3f577f04482ff92a
> > > change-id: 20240602-md-virtio_dma_buf-b3552ca6c5d5
> > >
> >
> > Following up to see if anything else is needed from me.
> > Hoping to see this in linux-next :)
>
> I still don't see this in linux-next so following up to see if anything else
> is needed to get this merged. Adding Greg KH since he's signed off on this
> file before and he's taken quite a few of my cleanups through his trees.
>
> I'm hoping to have all of these warnings fixed tree-wide in 6.11.
>
> /jeff
not sure why I tag it and it gets cleared again.
tagged again hope it holds now.
--
MST
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-11 19:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-02 20:25 [PATCH] virtio: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-23 17:36 ` Jeff Johnson
2024-07-11 18:43 ` Jeff Johnson
2024-07-11 19:22 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).