From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alexander Potapenko <glider@google.com>
Cc: "Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
virtualization@lists.linux.dev,
"Eugenio Pérez" <eperezma@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Aleksandr Nogikh" <nogikh@google.com>
Subject: Re: [PATCH] virtio_ring: fix KMSAN error for premapped mode
Date: Mon, 15 Jul 2024 10:20:45 -0400 [thread overview]
Message-ID: <20240715102018-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAG_fn=VwB_EepsY7GcMM2ihz77vtWDR3tsxJ6iD0Sdx-wQVx+g@mail.gmail.com>
On Mon, Jul 15, 2024 at 03:24:17PM +0200, Alexander Potapenko wrote:
> On Mon, Jun 24, 2024 at 3:57 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Mon, Jun 24, 2024 at 03:51:50PM +0200, Alexander Potapenko wrote:
> > > On Fri, Jun 7, 2024 at 8:34 AM Jason Wang <jasowang@redhat.com> wrote:
> > > >
> > > > On Thu, Jun 6, 2024 at 7:13 PM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > > > >
> > > > > Add kmsan for virtqueue_dma_map_single_attrs to fix:
> > > > >
> > > > > BUG: KMSAN: uninit-value in receive_buf+0x45ca/0x6990
> > > > > receive_buf+0x45ca/0x6990
> > > > > virtnet_poll+0x17e0/0x3130
> > > > > net_rx_action+0x832/0x26e0
> > > > > handle_softirqs+0x330/0x10f0
> > > > > [...]
> > > > >
> > > > > Uninit was created at:
> > > > > __alloc_pages_noprof+0x62a/0xe60
> > > > > alloc_pages_noprof+0x392/0x830
> > > > > skb_page_frag_refill+0x21a/0x5c0
> > > > > virtnet_rq_alloc+0x50/0x1500
> > > > > try_fill_recv+0x372/0x54c0
> > > > > virtnet_open+0x210/0xbe0
> > > > > __dev_open+0x56e/0x920
> > > > > __dev_change_flags+0x39c/0x2000
> > > > > dev_change_flags+0xaa/0x200
> > > > > do_setlink+0x197a/0x7420
> > > > > rtnl_setlink+0x77c/0x860
> > > > > [...]
> > > > >
> > > > > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > > > > Tested-by: Alexander Potapenko <glider@google.com>
> > > >
> > > > Acked-by: Jason Wang <jasowang@redhat.com>
> > >
> > > Jason, Michael, any chance this patch can make it to 6.10?
> > > The bug in question has essentially been blocking KMSAN on syzbot for
> > > the past month:
> > > https://syzkaller.appspot.com/bug?id=2819883f3d376b703e686e700fde00a01eec62fa
> > >
> > > The patch should probably have
> > > Fixes: b6253b4e21939 ("virtio_ring: introduce dma map api for virtqueue")
> > >
> > > , but I am not exactly sure why syzkaller only started triggering the
> > > bug this year, given that the patch dates back to 2023.
> >
> > Yes that's probably a good idea. I will queue it with this tag.
>
> Hi Michael,
>
> Looks like the patch is still stuck in the limbo :(
It should be in linux next. Don't you see it there?
next prev parent reply other threads:[~2024-07-15 14:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 11:13 [PATCH] virtio_ring: fix KMSAN error for premapped mode Xuan Zhuo
2024-06-06 11:54 ` Ilya Leoshkevich
2024-06-07 6:34 ` Jason Wang
2024-06-24 13:51 ` Alexander Potapenko
2024-06-24 13:57 ` Michael S. Tsirkin
2024-07-15 13:24 ` Alexander Potapenko
2024-07-15 14:20 ` Michael S. Tsirkin [this message]
2024-07-15 15:30 ` Ilya Leoshkevich
2024-07-15 16:06 ` Michael S. Tsirkin
2024-07-15 16:32 ` Alexander Potapenko
2024-07-15 20:11 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715102018-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=glider@google.com \
--cc=iii@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=nogikh@google.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).