From: "Michael S. Tsirkin" <mst@redhat.com>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, virtualization@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/virtio:Fix the wrong format specifier
Date: Wed, 24 Jul 2024 06:45:12 -0400 [thread overview]
Message-ID: <20240724064459-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240724074108.9530-1-zhujun2@cmss.chinamobile.com>
On Wed, Jul 24, 2024 at 12:41:08AM -0700, Zhu Jun wrote:
> The unsigned int should use "%u" instead of "%d".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
which matters why?
> ---
> tools/virtio/ringtest/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c
> index 5a18b2301a63..e471d8e7cfaa 100644
> --- a/tools/virtio/ringtest/main.c
> +++ b/tools/virtio/ringtest/main.c
> @@ -276,7 +276,7 @@ static void help(void)
> fprintf(stderr, "Usage: <test> [--help]"
> " [--host-affinity H]"
> " [--guest-affinity G]"
> - " [--ring-size R (default: %d)]"
> + " [--ring-size R (default: %u)]"
> " [--run-cycles C (default: %d)]"
> " [--batch b]"
> " [--outstanding o]"
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2024-07-24 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 7:41 [PATCH] tools/virtio:Fix the wrong format specifier Zhu Jun
2024-07-24 10:23 ` Eugenio Perez Martin
2024-07-24 10:45 ` Michael S. Tsirkin [this message]
2024-07-30 1:13 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240724064459-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).