* [PATCH] tools/virtio:Fix the wrong format specifier
@ 2024-07-24 7:41 Zhu Jun
2024-07-24 10:23 ` Eugenio Perez Martin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhu Jun @ 2024-07-24 7:41 UTC (permalink / raw)
To: mst, jasowang; +Cc: xuanzhuo, eperezma, zhujun2, virtualization, linux-kernel
The unsigned int should use "%u" instead of "%d".
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
tools/virtio/ringtest/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c
index 5a18b2301a63..e471d8e7cfaa 100644
--- a/tools/virtio/ringtest/main.c
+++ b/tools/virtio/ringtest/main.c
@@ -276,7 +276,7 @@ static void help(void)
fprintf(stderr, "Usage: <test> [--help]"
" [--host-affinity H]"
" [--guest-affinity G]"
- " [--ring-size R (default: %d)]"
+ " [--ring-size R (default: %u)]"
" [--run-cycles C (default: %d)]"
" [--batch b]"
" [--outstanding o]"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/virtio:Fix the wrong format specifier
2024-07-24 7:41 [PATCH] tools/virtio:Fix the wrong format specifier Zhu Jun
@ 2024-07-24 10:23 ` Eugenio Perez Martin
2024-07-24 10:45 ` Michael S. Tsirkin
2024-07-30 1:13 ` Xuan Zhuo
2 siblings, 0 replies; 4+ messages in thread
From: Eugenio Perez Martin @ 2024-07-24 10:23 UTC (permalink / raw)
To: Zhu Jun; +Cc: mst, jasowang, xuanzhuo, virtualization, linux-kernel
On Wed, Jul 24, 2024 at 9:44 AM Zhu Jun <zhujun2@cmss.chinamobile.com> wrote:
>
> The unsigned int should use "%u" instead of "%d".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Thanks!
> ---
> tools/virtio/ringtest/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c
> index 5a18b2301a63..e471d8e7cfaa 100644
> --- a/tools/virtio/ringtest/main.c
> +++ b/tools/virtio/ringtest/main.c
> @@ -276,7 +276,7 @@ static void help(void)
> fprintf(stderr, "Usage: <test> [--help]"
> " [--host-affinity H]"
> " [--guest-affinity G]"
> - " [--ring-size R (default: %d)]"
> + " [--ring-size R (default: %u)]"
> " [--run-cycles C (default: %d)]"
> " [--batch b]"
> " [--outstanding o]"
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/virtio:Fix the wrong format specifier
2024-07-24 7:41 [PATCH] tools/virtio:Fix the wrong format specifier Zhu Jun
2024-07-24 10:23 ` Eugenio Perez Martin
@ 2024-07-24 10:45 ` Michael S. Tsirkin
2024-07-30 1:13 ` Xuan Zhuo
2 siblings, 0 replies; 4+ messages in thread
From: Michael S. Tsirkin @ 2024-07-24 10:45 UTC (permalink / raw)
To: Zhu Jun; +Cc: jasowang, xuanzhuo, eperezma, virtualization, linux-kernel
On Wed, Jul 24, 2024 at 12:41:08AM -0700, Zhu Jun wrote:
> The unsigned int should use "%u" instead of "%d".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
which matters why?
> ---
> tools/virtio/ringtest/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c
> index 5a18b2301a63..e471d8e7cfaa 100644
> --- a/tools/virtio/ringtest/main.c
> +++ b/tools/virtio/ringtest/main.c
> @@ -276,7 +276,7 @@ static void help(void)
> fprintf(stderr, "Usage: <test> [--help]"
> " [--host-affinity H]"
> " [--guest-affinity G]"
> - " [--ring-size R (default: %d)]"
> + " [--ring-size R (default: %u)]"
> " [--run-cycles C (default: %d)]"
> " [--batch b]"
> " [--outstanding o]"
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools/virtio:Fix the wrong format specifier
2024-07-24 7:41 [PATCH] tools/virtio:Fix the wrong format specifier Zhu Jun
2024-07-24 10:23 ` Eugenio Perez Martin
2024-07-24 10:45 ` Michael S. Tsirkin
@ 2024-07-30 1:13 ` Xuan Zhuo
2 siblings, 0 replies; 4+ messages in thread
From: Xuan Zhuo @ 2024-07-30 1:13 UTC (permalink / raw)
To: Zhu Jun; +Cc: eperezma, zhujun2, virtualization, linux-kernel, mst, jasowang
On Wed, 24 Jul 2024 00:41:08 -0700, Zhu Jun <zhujun2@cmss.chinamobile.com> wrote:
> The unsigned int should use "%u" instead of "%d".
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> ---
> tools/virtio/ringtest/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtio/ringtest/main.c b/tools/virtio/ringtest/main.c
> index 5a18b2301a63..e471d8e7cfaa 100644
> --- a/tools/virtio/ringtest/main.c
> +++ b/tools/virtio/ringtest/main.c
> @@ -276,7 +276,7 @@ static void help(void)
> fprintf(stderr, "Usage: <test> [--help]"
> " [--host-affinity H]"
> " [--guest-affinity G]"
> - " [--ring-size R (default: %d)]"
> + " [--ring-size R (default: %u)]"
> " [--run-cycles C (default: %d)]"
> " [--batch b]"
> " [--outstanding o]"
> --
> 2.17.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-30 1:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-24 7:41 [PATCH] tools/virtio:Fix the wrong format specifier Zhu Jun
2024-07-24 10:23 ` Eugenio Perez Martin
2024-07-24 10:45 ` Michael S. Tsirkin
2024-07-30 1:13 ` Xuan Zhuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).