From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC70C1B0122 for ; Thu, 29 Aug 2024 14:23:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724941431; cv=none; b=EsixgVfQO2tTYozPfKj8r0EfrNfIhP1zsiEQ08a+t95F41zyrCU8LEmMZQUOzdEyzMVBQWSSCwtpbNBjvdIAjVRNA1kSHUFiqqHImM3BxCTgrs4DymLE3l+xB4lUnMEZC8JZBmCD6M26m0dQADHKJQjI5sXX8rrVfTLs34LJORU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724941431; c=relaxed/simple; bh=qPoGd42IBzZ4QGCIKQdm0vMwov6rl40Xn2loXjcYRCY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=prtCkiP235l36QbiZZIdd6PVci9k+8v0GgZgWx28Lyxx9Vmf0C9iJbGjpJJ6zx/MedPC4Hl7TIhFd/OtF+lenWYQ0oTl4bc/u0+jarCqewllak7vkH4LtYrVLSwzbkH0flwaf910rodUI6sRq+p6HWmHWOf41r+bZ/AdFFwb2+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AKH/uEOB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AKH/uEOB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724941428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ql1Ne45LZaHMxqlqyDYKdi5gydRbYI8USnMenQZimU8=; b=AKH/uEOBYDFppaAvg6GRgH66oL7zuYQ4LrSDgv/nra99S56J1BKAlqiKSTlQupV686Vo94 0g/btCzQAPXXvGI9Hd76+OVPUR/nz8oZfIVuoxeEg7EdOEQdfdstBYxJf9bZQboMWQvfip DOMNwDcnWhEpjPOQL9QeqazoK31pADE= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-01A6da4UNC-17j3IeHRleg-1; Thu, 29 Aug 2024 10:23:46 -0400 X-MC-Unique: 01A6da4UNC-17j3IeHRleg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-533500041b1so894710e87.3 for ; Thu, 29 Aug 2024 07:23:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724941425; x=1725546225; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ql1Ne45LZaHMxqlqyDYKdi5gydRbYI8USnMenQZimU8=; b=JYhvkjbADcm+aBFJJ6bCxs40If8ZXcVKme3HRQOYjOhOfOB02sg0ogryuj0fgRdDri Z/Jxfj925NkUrGz3Nl6bE5jBa1T2P6JcZQqnYyuxnfyMkqszOZsUWyGf9/YiIhJc1bEX aDOC70dDGIN6/uKO2axTE3bfAeTvo0CQFElbXT40QIqOXGmZk5bez7fjd59yCMUVJvPV G70v7BNj7bZicxvkxRlJGu2aCK3NPAY/xwbLX3rB/BmwYdxo2r057twrI0JomasodpEY Fz91O4gny0FkOR4tro3MsQId3CKECWTUeoEV0XHZ/Adtas3kwOOMeK/av13tlj3NpkZ9 9oug== X-Forwarded-Encrypted: i=1; AJvYcCX1+A9VNvqVUT6wt3m3reoFyaQeIi06aOw0rTR25nB+ygDU+n0Bz826KMqpDzT7aN+SJMATHKIb0X1dAopa2g==@lists.linux.dev X-Gm-Message-State: AOJu0YyDzWPytsVQA+vLcOj/ppbuw9ENCM4qdiftHKcH86ZfUYVmhoya 0kkSUEv1KYX4dVScrKfiE4c63urOQyd7JqlsOg2e0LrUzYN6Sul0YEPTsL7qX0m2MuYarqWViBu gBEJEnJ1EvfM4vlKfGcOmXlUb+Wur34C9MoVNg5f4pitYHJKC8HVtIWYnT00plZQI X-Received: by 2002:a05:6512:3e1b:b0:532:fb9e:a175 with SMTP id 2adb3069b0e04-5353e54320emr3380668e87.6.1724941425066; Thu, 29 Aug 2024 07:23:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFORO8WjY/vuiIa32r8sJHMtCMpPhEFpMY3fd+SrJTy3Fj3cveqXXWkkApSrWhroGzyUo6WIg== X-Received: by 2002:a05:6512:3e1b:b0:532:fb9e:a175 with SMTP id 2adb3069b0e04-5353e54320emr3380605e87.6.1724941423996; Thu, 29 Aug 2024 07:23:43 -0700 (PDT) Received: from redhat.com ([2a02:14f:17c:f3dd:4b1c:bb80:a038:2df3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891a3e52sm84049166b.116.2024.08.29.07.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 07:23:43 -0700 (PDT) Date: Thu, 29 Aug 2024 10:23:35 -0400 From: "Michael S. Tsirkin" To: Philipp Stanner Cc: Jens Axboe , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Bjorn Helgaas , Alvaro Karsz , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Richard Cochran , Damien Le Moal , Hannes Reinecke , John Garry , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, stable@vger.kernel.org, Christophe JAILLET Subject: Re: [PATCH v5 6/7] vdpa: solidrun: Fix UB bug with devres Message-ID: <20240829102320-mutt-send-email-mst@kernel.org> References: <20240829141844.39064-1-pstanner@redhat.com> <20240829141844.39064-7-pstanner@redhat.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240829141844.39064-7-pstanner@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 29, 2024 at 04:16:25PM +0200, Philipp Stanner wrote: > In psnet_open_pf_bar() and snet_open_vf_bar() a string later passed to > pcim_iomap_regions() is placed on the stack. Neither > pcim_iomap_regions() nor the functions it calls copy that string. > > Should the string later ever be used, this, consequently, causes > undefined behavior since the stack frame will by then have disappeared. > > Fix the bug by allocating the strings on the heap through > devm_kasprintf(). > > Cc: stable@vger.kernel.org # v6.3 > Fixes: 51a8f9d7f587 ("virtio: vdpa: new SolidNET DPU driver.") > Reported-by: Christophe JAILLET > Closes: https://lore.kernel.org/all/74e9109a-ac59-49e2-9b1d-d825c9c9f891@wanadoo.fr/ > Suggested-by: Andy Shevchenko > Signed-off-by: Philipp Stanner Post this separately, so I can apply? > --- > drivers/vdpa/solidrun/snet_main.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/vdpa/solidrun/snet_main.c b/drivers/vdpa/solidrun/snet_main.c > index 99428a04068d..c8b74980dbd1 100644 > --- a/drivers/vdpa/solidrun/snet_main.c > +++ b/drivers/vdpa/solidrun/snet_main.c > @@ -555,7 +555,7 @@ static const struct vdpa_config_ops snet_config_ops = { > > static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet) > { > - char name[50]; > + char *name; > int ret, i, mask = 0; > /* We don't know which BAR will be used to communicate.. > * We will map every bar with len > 0. > @@ -573,7 +573,10 @@ static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet) > return -ENODEV; > } > > - snprintf(name, sizeof(name), "psnet[%s]-bars", pci_name(pdev)); > + name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "psnet[%s]-bars", pci_name(pdev)); > + if (!name) > + return -ENOMEM; > + > ret = pcim_iomap_regions(pdev, mask, name); > if (ret) { > SNET_ERR(pdev, "Failed to request and map PCI BARs\n"); > @@ -590,10 +593,13 @@ static int psnet_open_pf_bar(struct pci_dev *pdev, struct psnet *psnet) > > static int snet_open_vf_bar(struct pci_dev *pdev, struct snet *snet) > { > - char name[50]; > + char *name; > int ret; > > - snprintf(name, sizeof(name), "snet[%s]-bar", pci_name(pdev)); > + name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "snet[%s]-bars", pci_name(pdev)); > + if (!name) > + return -ENOMEM; > + > /* Request and map BAR */ > ret = pcim_iomap_regions(pdev, BIT(snet->psnet->cfg.vf_bar), name); > if (ret) { > -- > 2.46.0