From: "Michael S. Tsirkin" <mst@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux.dev,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Jason Wang <jasowang@redhat.com>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-media@vger.kernel.org, virtualization@lists.linux.dev,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] vdpa_sim: don't select DMA_OPS
Date: Tue, 3 Sep 2024 05:39:04 -0400 [thread overview]
Message-ID: <20240903053857-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20240828061104.1925127-2-hch@lst.de>
On Wed, Aug 28, 2024 at 09:10:28AM +0300, Christoph Hellwig wrote:
> vdpa_sim has been fixed to not override the dma_map_ops in commit
> 6c3d329e6486 ("vdpa_sim: get rid of DMA ops"), so don't select the
> symbol and don't depend on HAS_DMA.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/vdpa/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index 5265d09fc1c409..b08de3b7706109 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -11,8 +11,7 @@ if VDPA
>
> config VDPA_SIM
> tristate "vDPA device simulator core"
> - depends on RUNTIME_TESTING_MENU && HAS_DMA
> - select DMA_OPS
> + depends on RUNTIME_TESTING_MENU
> select VHOST_RING
> select IOMMU_IOVA
> help
> --
> 2.43.0
next prev parent reply other threads:[~2024-09-03 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 6:10 clearly mark DMA_OPS support as an architecture feature v2 Christoph Hellwig
2024-08-28 6:10 ` [PATCH 1/2] vdpa_sim: don't select DMA_OPS Christoph Hellwig
2024-09-03 9:39 ` Michael S. Tsirkin [this message]
2024-08-28 6:10 ` [PATCH 2/2] dma-mapping: clearly mark DMA ops as an architecture feature Christoph Hellwig
2024-08-28 6:21 ` Andreas Larsson
2024-08-29 4:30 ` Christoph Hellwig
2024-09-03 7:27 ` clearly mark DMA_OPS support as an architecture feature v2 Christoph Hellwig
2024-09-03 9:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240903053857-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=bingbu.cao@intel.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sparclinux@vger.kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).