From: Breno Leitao <leitao@debian.org>
To: Leonardo Bras <leobras@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
rbc@meta.com, horms@kernel.org,
"open list:VIRTIO CORE AND NET DRIVERS"
<virtualization@lists.linux.dev>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning
Date: Thu, 5 Sep 2024 02:03:21 -0700 [thread overview]
Message-ID: <20240905-sassy-aboriginal-crocodile-cfadde@devvm32600> (raw)
In-Reply-To: <Ztc5QllkqaKZsaoN@LeoBras>
Hello Leonardo, good to see you here,
On Tue, Sep 03, 2024 at 01:28:50PM -0300, Leonardo Bras wrote:
> Please help me check if the following is correct:
> ###
> Any tree which includes df133f3f9625 ("virtio_net: bulk free tx skbs")
> should also include your patch, since it fixes stuff in there.
>
> The fact that the warning was only made visible in
> bdacf3e34945 ("net: Use nested-BH locking for napi_alloc_cache.")
> does not change the fact that it was already present before.
>
> Also, having bdacf3e34945 is not necessary for the backport, since
> it only made the bug visible.
> ###
>
> Are above statements right?
That is exactly correct.
The bug was introduced by df133f3f9625 ("virtio_net: bulk free tx
skbs"), but it was not visible until bdacf3e34945 ("net: Use nested-BH
locking for napi_alloc_cache.") landed.
You don't need bdacf3e34945 ("net: Use nested-BH locking for
napi_alloc_cache.") patch backported if you don't want to.
I hope it helps,
--breno
next prev parent reply other threads:[~2024-09-05 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:53 [PATCH net-next] virtio_net: Fix napi_skb_cache_put warning Breno Leitao
2024-07-12 14:54 ` Jakub Kicinski
2024-07-12 14:58 ` Breno Leitao
2024-07-13 22:59 ` Jakub Kicinski
2024-07-13 0:45 ` Jakub Kicinski
2024-07-14 7:38 ` Michael S. Tsirkin
2024-07-15 11:25 ` Breno Leitao
2024-09-03 16:28 ` Leonardo Bras
2024-09-05 9:03 ` Breno Leitao [this message]
2024-07-15 1:08 ` Jason Wang
2024-07-15 2:45 ` Heng Qi
2024-07-15 4:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240905-sassy-aboriginal-crocodile-cfadde@devvm32600 \
--to=leitao@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=horms@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=leobras@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rbc@meta.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).