* [PATCH v4 15/15] fs/fuse/virtio_fs: allow idmapped mounts
[not found] <20240903151626.264609-1-aleksandr.mikhalitsyn@canonical.com>
@ 2024-09-03 15:16 ` Alexander Mikhalitsyn
2024-09-05 19:45 ` Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Mikhalitsyn @ 2024-09-03 15:16 UTC (permalink / raw)
To: mszeredi
Cc: brauner, stgraber, linux-fsdevel, Seth Forshee, Miklos Szeredi,
Vivek Goyal, German Maglione, Amir Goldstein, Bernd Schubert,
Alexander Mikhalitsyn, Stefan Hajnoczi, Eugenio Pérez,
linux-kernel, virtualization
Allow idmapped mounts for virtiofs.
It's absolutely safe as for virtiofs we have the same
feature negotiation mechanism as for classical fuse
filesystems. This does not affect any existing
setups anyhow.
virtiofsd support:
https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/245
Cc: Christian Brauner <brauner@kernel.org>
Cc: Seth Forshee <sforshee@kernel.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: German Maglione <gmaglione@redhat.com>
Cc: Amir Goldstein <amir73il@gmail.com>
Cc: Bernd Schubert <bschubert@ddn.com>
Cc: <linux-fsdevel@vger.kernel.org>
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Reviewed-by: Christian Brauner <brauner@kernel.org>
---
v3:
- this commit added
---
fs/fuse/virtio_fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index dd5260141615..7e5bbaef6f76 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -1628,6 +1628,7 @@ static struct file_system_type virtio_fs_type = {
.name = "virtiofs",
.init_fs_context = virtio_fs_init_fs_context,
.kill_sb = virtio_kill_sb,
+ .fs_flags = FS_ALLOW_IDMAP,
};
static int virtio_fs_uevent(const struct kobject *kobj, struct kobj_uevent_env *env)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4 15/15] fs/fuse/virtio_fs: allow idmapped mounts
2024-09-03 15:16 ` [PATCH v4 15/15] fs/fuse/virtio_fs: allow idmapped mounts Alexander Mikhalitsyn
@ 2024-09-05 19:45 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2024-09-05 19:45 UTC (permalink / raw)
To: Alexander Mikhalitsyn
Cc: mszeredi, brauner, stgraber, linux-fsdevel, Seth Forshee,
Miklos Szeredi, Vivek Goyal, German Maglione, Amir Goldstein,
Bernd Schubert, Eugenio Pérez, linux-kernel, virtualization
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Tue, Sep 03, 2024 at 05:16:26PM +0200, Alexander Mikhalitsyn wrote:
> Allow idmapped mounts for virtiofs.
> It's absolutely safe as for virtiofs we have the same
> feature negotiation mechanism as for classical fuse
> filesystems. This does not affect any existing
> setups anyhow.
>
> virtiofsd support:
> https://gitlab.com/virtio-fs/virtiofsd/-/merge_requests/245
>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Seth Forshee <sforshee@kernel.org>
> Cc: Miklos Szeredi <miklos@szeredi.hu>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: German Maglione <gmaglione@redhat.com>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: Bernd Schubert <bschubert@ddn.com>
> Cc: <linux-fsdevel@vger.kernel.org>
> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
> Reviewed-by: Christian Brauner <brauner@kernel.org>
> ---
> v3:
> - this commit added
> ---
> fs/fuse/virtio_fs.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-05 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20240903151626.264609-1-aleksandr.mikhalitsyn@canonical.com>
2024-09-03 15:16 ` [PATCH v4 15/15] fs/fuse/virtio_fs: allow idmapped mounts Alexander Mikhalitsyn
2024-09-05 19:45 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).