From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 051B41448DF for ; Tue, 24 Sep 2024 22:02:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727215363; cv=none; b=EipUPlLuXqWfCvaX4v2KlfZnELXxQXfbx5FFbjvawuaWLPQVEsZ4mb0jGhjryyMr5mtrPWj1UWqwFmNWJUAwoUjN40AuYH7pp9RgoeRVHeEKioYWeQUdfvIpk0yvJ0K2Md9MKMjIsLS0sw6WcExHeVY3EQUqkYkkZc0RHNvBtuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727215363; c=relaxed/simple; bh=pu5G5qXLTl3zSGB+7dQNsdrINE8JNYhjhl+yhhCbdIQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=VKt8i28rOQvUorWchXx/r1R0ptC9iim9HDQWBOabqKmmuyZtQ9wJeg+uI3XAKwIKaaRWyvCx3pz8Nvlh4kEkoo/VRXEis3mTIUoSIFGCnDaHRBbhTW9prbt7BXdUdZoVLwzKlkN3ArSl4vC27Ec5WbWr4SJc//kiVB1ILLjFxGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ThW1fV/6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ThW1fV/6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727215359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=p08RO7jNAHbqAPJ0LfZ/6PkDLGb4/JJG3jEYdwRpx2U=; b=ThW1fV/6vSmrP0OpD8NDzkYFegFb4EyUMx21jb2h2QjoyLeAtZmU0iaqBeGH/qbYt8zsk1 vb5NVkpFmK0TYZ3SCZcDRsTz0zS6x0GonLGgmYVwv329LBt6ujee1hYh+Ejo3okepl4sKH zgfr+TaY6IGCUQX5pYd3JcmatDaRQv8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-235-JCcx9fhCMG6cCkVwuxqQlA-1; Tue, 24 Sep 2024 18:02:37 -0400 X-MC-Unique: JCcx9fhCMG6cCkVwuxqQlA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-374b385b146so2921009f8f.0 for ; Tue, 24 Sep 2024 15:02:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727215354; x=1727820154; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p08RO7jNAHbqAPJ0LfZ/6PkDLGb4/JJG3jEYdwRpx2U=; b=oaCphWvKDTfY31Ao9iGnbLlEp8vZcJ8ll1psYtSBEsKpOlwDvzdODv6EM6GcRRBf1b E3RrZttnbBQal+MUOH0NGAoz9Kn1/5gzKah0rj1ScggN4asKFK+FQzvGO9Y8m1R5+7+2 yO/un/6QR0dP7Vc7wKBft8X3ksFnH3+bLfkuyiR6Rq605GrHD2Xp+trDXvOxR+c7uGKE Hq2g0RTD+LITm2EcCK8RIDuiolxGfhQFR3CTpTdxcIEsdKHAqWQCbLSaTf6gHiIgEOaX qzWE1O88+Pe1yL2MoGJZZ+jmI56j9M6VQnzRUSBKiPljp6R6ctJad6ekbdZWw/MmFGbB xgwQ== X-Forwarded-Encrypted: i=1; AJvYcCVf7J7CVE/jfETIDrbnmkjQ6/5olaIbwbPJ6l4viBKnCHG3DqKtr/4hC9TW4SLUVcwtc1i0SdGosY4rgUkp/A==@lists.linux.dev X-Gm-Message-State: AOJu0YwSPVb4hDIDjzGA+anxuKTa9W/foQsjCBq576tM17L11ppukvT6 9aCwIwmP+O2umisr02KJOqW3ZqEafP0bs8S0cuqxGzee6MKvIBk1Bid42LYqlhkh7A8SsAlw94/ DHc/IfXVAr+BoFbzC+ukVYNY40CH9/jZbapN/OpwOVrAZZmEr8usYx+aSYy0biIuNQ7ETJwPu X-Received: by 2002:adf:c006:0:b0:374:c142:80e7 with SMTP id ffacd0b85a97d-37cc245c0d7mr469101f8f.1.1727215354154; Tue, 24 Sep 2024 15:02:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE798q0O7Fe/wwcjVDfqt4MNQ2Rk3GAssMMKcDml1GPXBnju2SlRN5umha2Yafd8UUyK6orbQ== X-Received: by 2002:adf:c006:0:b0:374:c142:80e7 with SMTP id ffacd0b85a97d-37cc245c0d7mr469086f8f.1.1727215353661; Tue, 24 Sep 2024 15:02:33 -0700 (PDT) Received: from redhat.com ([2a06:c701:7405:9900:56a3:401a:f419:5de9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2f96f6sm2496359f8f.87.2024.09.24.15.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Sep 2024 15:02:29 -0700 (PDT) Date: Tue, 24 Sep 2024 18:02:25 -0400 From: "Michael S. Tsirkin" To: Wenyu Huang Cc: jasowang@redhat.com, xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] virtio: Make vring_new_virtqueue support for packed vring Message-ID: <20240924175414-mutt-send-email-mst@kernel.org> References: <20240920202141.89446-1-huangwenyuu@outlook.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240920202141.89446-1-huangwenyuu@outlook.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Sep 21, 2024 at 04:21:41AM +0800, Wenyu Huang wrote: > From: Wenyu Huang > > It's also available for packed ring now. > > Signed-off-by: Wenyu Huang More specifically, what are you trying to address here? Which configuration did not work but does now? > --- > drivers/virtio/virtio_ring.c | 153 +++++++++++++++++++++-------------- > 1 file changed, 92 insertions(+), 61 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index be7309b1e860..664a0c40ee05 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -223,7 +223,7 @@ struct vring_virtqueue { > #endif > }; > > -static struct virtqueue *__vring_new_virtqueue(unsigned int index, > +static struct virtqueue *__vring_new_virtqueue_split(unsigned int index, > struct vring_virtqueue_split *vring_split, > struct virtio_device *vdev, > bool weak_barriers, > @@ -232,6 +232,15 @@ static struct virtqueue *__vring_new_virtqueue(unsigned int index, > void (*callback)(struct virtqueue *), > const char *name, > struct device *dma_dev); > +static struct virtqueue *__vring_new_virtqueue_packed(unsigned int index, > + struct vring_virtqueue_packed *vring_packed, > + struct virtio_device *vdev, > + bool weak_barriers, > + bool context, > + bool (*notify)(struct virtqueue *), > + void (*callback)(struct virtqueue *), > + const char *name, > + struct device *dma_dev); > static struct vring_desc_extra *vring_alloc_desc_extra(unsigned int num); > static void vring_free(struct virtqueue *_vq); > > @@ -1160,7 +1169,7 @@ static struct virtqueue *vring_create_virtqueue_split( > if (err) > return NULL; > > - vq = __vring_new_virtqueue(index, &vring_split, vdev, weak_barriers, > + vq = __vring_new_virtqueue_split(index, &vring_split, vdev, weak_barriers, > context, notify, callback, name, dma_dev); > if (!vq) { > vring_free_split(&vring_split, vdev, dma_dev); > @@ -2064,62 +2073,21 @@ static struct virtqueue *vring_create_virtqueue_packed( > struct device *dma_dev) > { > struct vring_virtqueue_packed vring_packed = {}; > - struct vring_virtqueue *vq; > - int err; > + struct virtqueue *vq; > > if (vring_alloc_queue_packed(&vring_packed, vdev, num, dma_dev)) > - goto err_ring; > - > - vq = kmalloc(sizeof(*vq), GFP_KERNEL); > - if (!vq) > - goto err_vq; > - > - vq->vq.callback = callback; > - vq->vq.vdev = vdev; > - vq->vq.name = name; > - vq->vq.index = index; > - vq->vq.reset = false; > - vq->we_own_ring = true; > - vq->notify = notify; > - vq->weak_barriers = weak_barriers; > -#ifdef CONFIG_VIRTIO_HARDEN_NOTIFICATION > - vq->broken = true; > -#else > - vq->broken = false; > -#endif > - vq->packed_ring = true; > - vq->dma_dev = dma_dev; > - vq->use_dma_api = vring_use_dma_api(vdev); > - vq->premapped = false; > - vq->do_unmap = vq->use_dma_api; > - > - vq->indirect = virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC) && > - !context; > - vq->event = virtio_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX); > - > - if (virtio_has_feature(vdev, VIRTIO_F_ORDER_PLATFORM)) > - vq->weak_barriers = false; > - > - err = vring_alloc_state_extra_packed(&vring_packed); > - if (err) > - goto err_state_extra; > - > - virtqueue_vring_init_packed(&vring_packed, !!callback); > + return NULL; > > - virtqueue_init(vq, num); > - virtqueue_vring_attach_packed(vq, &vring_packed); > + vq = __vring_new_virtqueue_packed(index, &vring_packed, vdev, weak_barriers, > + context, notify, callback, name, dma_dev); > + if (!vq) { > + vring_free_packed(&vring_packed, vdev, dma_dev); > + return NULL; > + } > > - spin_lock(&vdev->vqs_list_lock); > - list_add_tail(&vq->vq.list, &vdev->vqs); > - spin_unlock(&vdev->vqs_list_lock); > - return &vq->vq; > + to_vvq(vq)->we_own_ring = true; > > -err_state_extra: > - kfree(vq); > -err_vq: > - vring_free_packed(&vring_packed, vdev, dma_dev); > -err_ring: > - return NULL; > + return vq; > } > > static int virtqueue_resize_packed(struct virtqueue *_vq, u32 num) > @@ -2599,7 +2567,7 @@ irqreturn_t vring_interrupt(int irq, void *_vq) > EXPORT_SYMBOL_GPL(vring_interrupt); > > /* Only available for split ring */ > -static struct virtqueue *__vring_new_virtqueue(unsigned int index, > +static struct virtqueue *__vring_new_virtqueue_split(unsigned int index, > struct vring_virtqueue_split *vring_split, > struct virtio_device *vdev, > bool weak_barriers, > @@ -2612,9 +2580,6 @@ static struct virtqueue *__vring_new_virtqueue(unsigned int index, > struct vring_virtqueue *vq; > int err; > > - if (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED)) > - return NULL; > - > vq = kmalloc(sizeof(*vq), GFP_KERNEL); > if (!vq) > return NULL; > @@ -2662,6 +2627,66 @@ static struct virtqueue *__vring_new_virtqueue(unsigned int index, > return &vq->vq; > } > > +static struct virtqueue *__vring_new_virtqueue_packed(unsigned int index, > + struct vring_virtqueue_packed *vring_packed, > + struct virtio_device *vdev, > + bool weak_barriers, > + bool context, > + bool (*notify)(struct virtqueue *), > + void (*callback)(struct virtqueue *), > + const char *name, > + struct device *dma_dev) > +{ > + struct vring_virtqueue *vq; > + int err; > + > + vq = kmalloc(sizeof(*vq), GFP_KERNEL); > + if (!vq) > + return NULL; > + > + vq->vq.callback = callback; > + vq->vq.vdev = vdev; > + vq->vq.name = name; > + vq->vq.index = index; > + vq->vq.reset = false; > + vq->we_own_ring = false; > + vq->notify = notify; > + vq->weak_barriers = weak_barriers; > +#ifdef CONFIG_VIRTIO_HARDEN_NOTIFICATION > + vq->broken = true; > +#else > + vq->broken = false; > +#endif > + vq->packed_ring = true; > + vq->dma_dev = dma_dev; > + vq->use_dma_api = vring_use_dma_api(vdev); > + vq->premapped = false; > + vq->do_unmap = vq->use_dma_api; > + > + vq->indirect = virtio_has_feature(vdev, VIRTIO_RING_F_INDIRECT_DESC) && > + !context; > + vq->event = virtio_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX); > + > + if (virtio_has_feature(vdev, VIRTIO_F_ORDER_PLATFORM)) > + vq->weak_barriers = false; > + > + err = vring_alloc_state_extra_packed(vring_packed); > + if (err) { > + kfree(vq); > + return NULL; > + } > + > + virtqueue_vring_init_packed(vring_packed, !!callback); > + > + virtqueue_init(vq, vring_packed->vring.num); > + virtqueue_vring_attach_packed(vq, vring_packed); > + > + spin_lock(&vdev->vqs_list_lock); > + list_add_tail(&vq->vq.list, &vdev->vqs); > + spin_unlock(&vdev->vqs_list_lock); > + return &vq->vq; > +} > + > struct virtqueue *vring_create_virtqueue( > unsigned int index, > unsigned int num, > @@ -2840,7 +2865,6 @@ int virtqueue_reset(struct virtqueue *_vq, > } > EXPORT_SYMBOL_GPL(virtqueue_reset); > > -/* Only available for split ring */ > struct virtqueue *vring_new_virtqueue(unsigned int index, > unsigned int num, > unsigned int vring_align, > @@ -2853,12 +2877,19 @@ struct virtqueue *vring_new_virtqueue(unsigned int index, > const char *name) > { > struct vring_virtqueue_split vring_split = {}; > + struct vring_virtqueue_packed vring_packed = {}; > > - if (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED)) > - return NULL; > + if (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED)) { > + vring_packed.vring.num = num; > + vring_packed.vring.desc = pages; > + return __vring_new_virtqueue_packed(index, &vring_packed, > + vdev, weak_barriers, > + context, notify, callback, > + name, vdev->dev.parent); > + } > > vring_init(&vring_split.vring, num, pages, vring_align); > - return __vring_new_virtqueue(index, &vring_split, vdev, weak_barriers, > + return __vring_new_virtqueue_split(index, &vring_split, vdev, weak_barriers, > context, notify, callback, name, > vdev->dev.parent); > } > -- > 2.43.0