From: Al Viro <viro@zeniv.linux.org.uk>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: virtualization@lists.linux.dev, kvm@vger.kernel.org,
netdev@vger.kernel.org, "Eugenio Pérez" <eperezma@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Tiwei Bie" <tiwei.bie@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config()
Date: Wed, 25 Sep 2024 21:50:05 +0100 [thread overview]
Message-ID: <20240925205005.GL3550746@ZenIV> (raw)
In-Reply-To: <79b2f48a-f6a1-4bfc-9a8d-cb09777f2a07@web.de>
On Wed, Sep 25, 2024 at 08:48:16PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Wed, 25 Sep 2024 20:36:35 +0200
>
> Assign the return value from a copy_to_user() call to an additional
> local variable so that a kvfree() call and return statement can be
> omitted accordingly.
Ugly and unidiomatic.
> This issue was detected by using the Coccinelle software.
What issue?
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Nevermind (and I really need more coffee, seeing that I'd missed the
obvious indicator of garbage and failed to hit delete)...
next prev parent reply other threads:[~2024-09-25 20:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 18:48 [PATCH] vhost-vdpa: Refactor copy_to_user() usage in vhost_vdpa_get_config() Markus Elfring
2024-09-25 20:50 ` Al Viro [this message]
2024-09-26 6:04 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925205005.GL3550746@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=Markus.Elfring@web.de \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tiwei.bie@intel.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).