Re: [PATCH 1/2] Virtio: Add CONFIG_VIRTIO_MMIO_POLL_RESET

["Michael S. Tsirkin" <mst@redhat.com>]

On Sun, Sep 22, 2024 at 08:34:34PM +0800, Jianguo Sun wrote:
> Add CONFIG_VIRTIO_MMIO_POLL_RESET to as an option to enable
> synchronous reset for the MMIO based transport for virtio.
> Change-Id: Ifa7e29b4c0cfa26922535f921c6ab69eacdc4cfc

Don't put these in.

> Signed-off-by: Jianguo Sun <quic_jianguos@quicinc.com>
> Signed-off-by: Anant Goel <quic_anantg@quicinc.com>
> ---
>  drivers/virtio/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> index 42a48ac763ee..fb17b1078d53 100644
> --- a/drivers/virtio/Kconfig
> +++ b/drivers/virtio/Kconfig
> @@ -188,4 +188,12 @@ config VIRTIO_DEBUG
>  
>  	  If unsure, say N.
>  
> +config VIRTIO_MMIO_POLL_RESET
> +	bool "Virti-mmio device synchronous reset support"
> +	depends on VIRTIO_MMIO
> +	help
> +	  Say y here to enable synchronous reset for the MMIO transport based
> +	  virtio device. After writing 0 to device_status, the driver must
> +	  wait for a read of device_status to return 0 before reinitializing
> +	  the device.

I see no real value in this config option as defined, users will have no
idea when to enable it. And you definitely do not want this
as a separate patch, you are adding an option but it does not work,
then you fix it in a separate patch. No need for this, it's
small enough.

>  endif # VIRTIO_MENU
> -- 
> 2.17.1