From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F5741E379B for ; Tue, 15 Oct 2024 10:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728986949; cv=none; b=eGJ3THtSQuYEhj55rn15kq4MwjRJ4aPlNL5U+AgsSp9apzzJq+4sMNJRywDZPuTbCvGJeaRLQ4bzR3Z+FmIHciYY7qRlI9SezY7VEowJs5xQt3b1S2W4lm0fy/jQ4Gp/usVL03bGm+qaIbpFYlEnQows1grBGiAg+K/WP53qDSw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728986949; c=relaxed/simple; bh=L/+YSZd9FgzSTjtlgoEb7AhHZrvE5ViY4redsR5s1EE=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=GbAx4hUELYOLjFA6nt2wHeDm1yCnOg+Ge7zA9XApkBKs/M7X2+y2e/aekD6BeBfa95sDxY+c/MxbhHngcA7YKSvYw0JPv8so+hij4BPxi6Bg+NF8DEVGX+UgIF8DDCla5GVX3p4TpAIw3IbSCHmjoFeBRkegoQ2To4WJ+WbVirw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=orD2fuzx; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="orD2fuzx" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F8PIdt023808; Tue, 15 Oct 2024 10:09:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=/c7LV/XQCFoM90nvgmsgvrUkllUDo6 cElhrXfABkZfQ=; b=orD2fuzxADOT2+HxgEydnL3W+PkhEdGjS5UKKVau1xhD5b EgtbAK4cINCp6W7feBhvjPexGoQbNGSBMg4Niu20J3NYWfq4ti551CFDS9F7UUs4 uJI6QQgPmfNYxb8ejTqzwUby7nEIfRJaG12732FzvJ9RkqL6t+fWS0kMANy5ss/E olzppJ2JbaqWLgxLdiG4guUDpoRWRYSpBmIjjHw6ahq69x6/xv08Q5rV4ekCr6fu jFK/7dSCrKf6xaML6LtYFhz9dxxBnfUoS7zOBhVRnoE4TfZ7PVFEckqULqo6Z3ej 2iDVmL5pjdwfZBhIGkxCw/D4iKme8VVz3FkbS8iA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429mv4rh6x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 10:09:02 +0000 (GMT) Received: from m0360083.ppops.net (m0360083.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 49FA91wf019574; Tue, 15 Oct 2024 10:09:01 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 429mv4rh6q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 10:09:01 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 49F8hDOg005377; Tue, 15 Oct 2024 10:09:00 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4285nj2w6a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Oct 2024 10:09:00 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 49FA8uJs53608814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Oct 2024 10:08:56 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 75FC52004B; Tue, 15 Oct 2024 10:08:56 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3088B20049; Tue, 15 Oct 2024 10:08:56 +0000 (GMT) Received: from osiris (unknown [9.152.212.60]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 15 Oct 2024 10:08:56 +0000 (GMT) Date: Tue, 15 Oct 2024 12:08:54 +0200 From: Heiko Carstens To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Morton , Jonathan Corbet , Mario Casquero , Alexander Egorenkov , Mikhail Zaslonko Subject: Re: [PATCH v2 1/7] s390/kdump: implement is_kdump_kernel() Message-ID: <20241015100854.7641-J-hca@linux.ibm.com> References: <20241014144622.876731-1-david@redhat.com> <20241014144622.876731-2-david@redhat.com> <20241014182054.10447-D-hca@linux.ibm.com> <20241015083040.7641-C-hca@linux.ibm.com> <0c7e876f-5648-4a82-b809-ca48f778b4a6@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0c7e876f-5648-4a82-b809-ca48f778b4a6@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: B4FoBzXg4xRB3GzcXvcGiFpFwcYSCEoJ X-Proofpoint-ORIG-GUID: ydJ8NcHofxE6nimFbJhOvYGvELg379sK X-Proofpoint-UnRewURL: 0 URL was un-rewritten Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0 mlxlogscore=468 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150068 On Tue, Oct 15, 2024 at 10:41:21AM +0200, David Hildenbrand wrote: > On 15.10.24 10:30, Heiko Carstens wrote: > > On Mon, Oct 14, 2024 at 09:26:03PM +0200, David Hildenbrand wrote: > > > On 14.10.24 20:20, Heiko Carstens wrote: > > > > Looks like this could work. But the comment in smp.c above > > > > dump_available() needs to be updated. > > > > > > A right, I remember that there was some outdated documentation. ... > My concern is that we'll now have > > bool is_kdump_kernel(void) > { > return oldmem_data.start && !is_ipl_type_dump(); > } > > Which matches 3), but if 2) is also called "kdump", then should it actually > be > > bool is_kdump_kernel(void) > { > return oldmem_data.start; > } > > ? > > When I wrote that code I was rather convinced that the variant in this patch > is the right thing to do. Oh well, we simply of too many dump options. I'll let Alexander and Mikhail better comment on this :) Alexander, Mikhail, the discussion starts here, and we need a sane is_kdump_kernel() for s390: https://lore.kernel.org/all/20241014144622.876731-1-david@redhat.com/