From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Yishai Hadas <yishaih@nvidia.com>,
mst@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org, parav@nvidia.com,
feliu@nvidia.com, kevin.tian@intel.com,
joao.m.martins@oracle.com, leonro@nvidia.com, maorg@nvidia.com
Subject: Re: [PATCH V1 vfio 5/7] vfio/virtio: Add support for the basic live migration functionality
Date: Wed, 6 Nov 2024 11:48:54 -0400 [thread overview]
Message-ID: <20241106154854.GQ458827@nvidia.com> (raw)
In-Reply-To: <20241105154746.60e06e75.alex.williamson@redhat.com>
On Tue, Nov 05, 2024 at 03:47:46PM -0700, Alex Williamson wrote:
> I think the API to vfio core also suggests we shouldn't be modifying the
> ops pointer after the core device is allocated.
Yeah, that is a dangerous pattern we should avoid
Jason
next prev parent reply other threads:[~2024-11-06 15:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-04 10:21 [PATCH V1 vfio 0/7] Enhance the vfio-virtio driver to support live migration Yishai Hadas
2024-11-04 10:21 ` [PATCH V1 vfio 1/7] virtio_pci: Introduce device parts access commands Yishai Hadas
2024-11-04 10:21 ` [PATCH V1 vfio 2/7] virtio: Extend the admin command to include the result size Yishai Hadas
2024-11-04 10:21 ` [PATCH V1 vfio 3/7] virtio: Manage device and driver capabilities via the admin commands Yishai Hadas
2024-11-04 10:21 ` [PATCH V1 vfio 4/7] virtio-pci: Introduce APIs to execute device parts " Yishai Hadas
2024-11-04 10:21 ` [PATCH V1 vfio 5/7] vfio/virtio: Add support for the basic live migration functionality Yishai Hadas
2024-11-05 22:47 ` Alex Williamson
2024-11-06 10:21 ` Yishai Hadas
2024-11-06 21:33 ` Alex Williamson
2024-11-07 9:39 ` Yishai Hadas
2024-11-06 15:48 ` Jason Gunthorpe [this message]
2024-11-04 10:21 ` [PATCH V1 vfio 6/7] vfio/virtio: Add PRE_COPY support for live migration Yishai Hadas
2024-11-05 23:18 ` Alex Williamson
2024-11-06 11:16 ` Yishai Hadas
2024-11-06 21:40 ` Alex Williamson
2024-11-04 10:21 ` [PATCH V1 vfio 7/7] vfio/virtio: Enable live migration once VIRTIO_PCI was configured Yishai Hadas
2024-11-05 23:29 ` Alex Williamson
2024-11-06 13:59 ` Jason Gunthorpe
2024-11-06 22:27 ` Alex Williamson
2024-11-07 12:57 ` Yishai Hadas
2024-11-07 21:25 ` Alex Williamson
2024-11-11 8:22 ` Yishai Hadas
2024-11-11 10:32 ` Joao Martins
2024-11-11 14:17 ` Yishai Hadas
2024-11-11 15:30 ` Joao Martins
2024-11-11 21:27 ` Alex Williamson
2024-11-06 9:32 ` [PATCH V1 vfio 0/7] Enhance the vfio-virtio driver to support live migration Michael S. Tsirkin
2024-11-06 22:30 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241106154854.GQ458827@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=feliu@nvidia.com \
--cc=jasowang@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=maorg@nvidia.com \
--cc=mst@redhat.com \
--cc=parav@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).