From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CEE8171C9 for ; Wed, 13 Nov 2024 15:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731510396; cv=none; b=eQvFQcJLa3iJ4+b2pIMkQQx8YZMceb+3YU/ssJEgNV4LdlXS0paR6iwfA9IgtCPYPkkY2EJvcv0hgmhIfDoYdBfHRqEV924r4KY1B+qNcw57IWeoRODQ7qk7A+/KRkqyOYwlxS2avCNFBqO2h8y8VNnAqSMt4mj94HzZCVSuJ2s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731510396; c=relaxed/simple; bh=mpJgoK+KWuNIIegnc/x2H4Utp5hqy3HIkW65cX40Zx4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: In-Reply-To:Content-Type:Content-Disposition; b=jdIN0Ny0XiRSi5rWsPZSr8Tov621qz5Vr/fqpmR4YfmfkWCCIar6Cq0pVs5O8fdBeczBVPKDMTLMwVIPddEEBX5bsRlJpXkzQuZQdfJtraYAmozdfGq+dXSyTseswX+DoqylA3Vi1XB30EuO+h0iQNxNC1h7xhOJKcWib4flrRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P4ukQDWx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P4ukQDWx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731510393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GWLdOv3kD3hyDaciZE7jYJRmtPh0CooncSDI6Dayl5M=; b=P4ukQDWxkK/AJPitoTJP0Mk/Pcv3XlvmYPlOrsRuJ17dx0/+vycpeRDrOzxOqnoXrgink6 hevJZvQVqZUUlwD/wMY1aLfq6qKVFOpxTXVV2zIaum5fyiF7ERHtUvvL8XYHoax132Vnfq Uq0Kl194PBxLKwXJVuAbn6BxJhsUg0A= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-9iLWHpuyMeWYVjgStvMBhg-1; Wed, 13 Nov 2024 10:06:31 -0500 X-MC-Unique: 9iLWHpuyMeWYVjgStvMBhg-1 X-Mimecast-MFC-AGG-ID: 9iLWHpuyMeWYVjgStvMBhg Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d52ccc50eso3809695f8f.3 for ; Wed, 13 Nov 2024 07:06:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731510390; x=1732115190; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GWLdOv3kD3hyDaciZE7jYJRmtPh0CooncSDI6Dayl5M=; b=rCbepZ5sCawLaEPwyJYxEI4TxCssdPr1dODm19MMpkdE75kdxR2rPgayzoI9pasR+3 WaYluk05Ia0Ee6ozS4idlCewKAE5NVMOmAsrg4fAYuXiJo1e4PNYSkHnQg+j9Y7I1/jy nVoJlRcjGx3Qlo+IR4rf+sqEYXV4MZ4c4rbr3OYLFPCyD+jfvemtjjkfd/8Ca7FdPBx/ sYtwhnAvDLu5CcaTm2cUsY1QREpOG08rvL47FbGRuM8RSxCd/ttqITi9uAFB7cp/ZV3L W8aJUYSIJrr+eJKJM9tkvNByL2MxNrfFTruY6OC/g5Lm74ueW6x3K52AqfQVRsKcsx1q mdCA== X-Gm-Message-State: AOJu0YyfjkNTg8E4Ojpd9181dAu1iyI5LH26fUeuakkyO8ZXDNI+a7gz gff2eUbcUh6CvgO+/8PmkomeM6nqfFeabxsAL+2spmUv1a/2Z9UEk4cOQkyA13eBE5+gkJP7gZC dY9AEnnVLYIxn0SPBHWRSKRqppqhhSt29033C2irQTgoFgpdigGUkbaQtZL1JiM3h X-Received: by 2002:a5d:588d:0:b0:37d:3bad:a50b with SMTP id ffacd0b85a97d-381f18855aamr18437797f8f.45.1731510389840; Wed, 13 Nov 2024 07:06:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IFR7SGrB4Fhm/j6pwU0uLR/0ukNIUrLvC+LHfK+NVU9lonHgPfDgfk60S9MS3/zsxXaiAHN+g== X-Received: by 2002:a5d:588d:0:b0:37d:3bad:a50b with SMTP id ffacd0b85a97d-381f18855aamr18437760f8f.45.1731510389417; Wed, 13 Nov 2024 07:06:29 -0800 (PST) Received: from redhat.com ([2.55.171.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed99681csm19022148f8f.49.2024.11.13.07.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 07:06:28 -0800 (PST) Date: Wed, 13 Nov 2024 10:06:24 -0500 From: "Michael S. Tsirkin" To: Dragos Tatulea Cc: virtualization@lists.linux.dev, Si-Wei Liu , Jason Wang , Eugenio Perez Martin , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Gal Pressman , Parav Pandit , Xuan Zhuo Subject: Re: [PATCH vhost 2/2] vdpa/mlx5: Fix suboptimal range on iotlb iteration Message-ID: <20241113100618-mutt-send-email-mst@kernel.org> References: <20241021134040.975221-1-dtatulea@nvidia.com> <20241021134040.975221-3-dtatulea@nvidia.com> <20241113013149-mutt-send-email-mst@kernel.org> <195f8d81-36d8-4730-9911-5797f41c58ad@nvidia.com> <20241113094920-mutt-send-email-mst@kernel.org> <83e533ff-e7cc-41e3-8632-7c4e3f6af8b7@nvidia.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <83e533ff-e7cc-41e3-8632-7c4e3f6af8b7@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Pgpo9gNbW-brXm_FzHMKH_rnhuRCWn5iqZ6pFXHEvzY_1731510390 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 13, 2024 at 04:01:05PM +0100, Dragos Tatulea wrote: > > > On 13.11.24 15:49, Michael S. Tsirkin wrote: > > On Wed, Nov 13, 2024 at 03:33:35PM +0100, Dragos Tatulea wrote: > >> > >> > >> On 13.11.24 07:32, Michael S. Tsirkin wrote: > >>> On Mon, Oct 21, 2024 at 04:40:40PM +0300, Dragos Tatulea wrote: > >>>> From: Si-Wei Liu > >>>> > >>>> The starting iova address to iterate iotlb map entry within a range > >>>> was set to an irrelevant value when passing to the itree_next() > >>>> iterator, although luckily it doesn't affect the outcome of finding > >>>> out the granule of the smallest iotlb map size. Fix the code to make > >>>> it consistent with the following for-loop. > >>>> > >>>> Fixes: 94abbccdf291 ("vdpa/mlx5: Add shared memory registration code") > >>> > >>> > >>> But the cover letter says "that's why it does not have a fixes tag". > >>> Confused. > >> Sorry about that. Patch is fine with fixes tag, I forgot to drop that > >> part of the sentence from the cover letter. > >> > >> Let me know if I need to resend something. > >> > >> Thanks, > >> Dragos > > > > But why does it need the fixes tag? That one means "if you have > > that hash, you need this patch". Pls do not abuse it for > > optimizations. > > > Well, it is a fix but it happens that the code around still works without > this fix. I figured that it would be better to take it into older stable kernels > just like the other one. But if you consider it an improvement I will send a v2 > without the Fixes tag. > > Thanks, > Dragos No need.