Re: [PATCH v2] vdpa/vp_vdpa: implement kick_vq_with_data callback

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Dec 03, 2024 at 10:37:43AM +0800, Yuxue Liu yuxue.liu@jaguarmicro.com wrote:
> From: Yuxue Liu <yuxue.liu@jaguarmicro.com>
> 
> Implement the kick_vq_with_data vDPA callback.
> On kick, we pass the next available data to the hardware by writing it in
> the kick offset.
> 
> Signed-off-by: Yuxue Liu <yuxue.liu@jaguarmicro.com>

Pls do not send v2 as reply to v1.
I am not sure all tools test the patch if you do.

> ---
> v2: fix build error for kernel test robot
> 
>  drivers/vdpa/virtio_pci/vp_vdpa.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index 16380764275e..8787407f75b0 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -367,6 +367,14 @@ static void vp_vdpa_kick_vq(struct vdpa_device *vdpa, u16 qid)
>  	vp_iowrite16(qid, vp_vdpa->vring[qid].notify);
>  }
>  
> +static void vp_vdpa_kick_vq_with_data(struct vdpa_device *vdpa, u32 data)
> +{
> +	struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa);
> +	u16 qid = data & 0xFFFF;
> +
> +	vp_iowrite32(data, vp_vdpa->vring[qid].notify);
> +}
> +
>  static u32 vp_vdpa_get_generation(struct vdpa_device *vdpa)
>  {
>  	struct virtio_pci_modern_device *mdev = vdpa_to_mdev(vdpa);
> @@ -472,6 +480,7 @@ static const struct vdpa_config_ops vp_vdpa_ops = {
>  	.get_vq_size	= vp_vdpa_get_vq_size,
>  	.set_vq_address	= vp_vdpa_set_vq_address,
>  	.kick_vq	= vp_vdpa_kick_vq,
> +	.kick_vq_with_data      = vp_vdpa_kick_vq_with_data,
>  	.get_generation	= vp_vdpa_get_generation,
>  	.get_device_id	= vp_vdpa_get_device_id,
>  	.get_vendor_id	= vp_vdpa_get_vendor_id,
> -- 
> 2.34.1