virtualization.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org,
	linux-mediatek@lists.infradead.org,
	freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
	nouveau@lists.freedesktop.org, virtualization@lists.linux.dev,
	spice-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
	intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Subject: [PATCH v3 08/25] drm/gma500: Compute dumb-buffer sizes with drm_mode_size_dumb()
Date: Tue, 18 Feb 2025 15:23:31 +0100	[thread overview]
Message-ID: <20250218142542.438557-9-tzimmermann@suse.de> (raw)
In-Reply-To: <20250218142542.438557-1-tzimmermann@suse.de>

Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
buffer size. Align the pitch to a multiple of 64.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
---
 drivers/gpu/drm/gma500/gem.c | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/gma500/gem.c b/drivers/gpu/drm/gma500/gem.c
index 4b7627a72637..fc337db0a948 100644
--- a/drivers/gpu/drm/gma500/gem.c
+++ b/drivers/gpu/drm/gma500/gem.c
@@ -16,6 +16,7 @@
 #include <asm/set_memory.h>
 
 #include <drm/drm.h>
+#include <drm/drm_dumb_buffers.h>
 #include <drm/drm_vma_manager.h>
 
 #include "gem.h"
@@ -199,35 +200,25 @@ psb_gem_create(struct drm_device *dev, u64 size, const char *name, bool stolen,
 int psb_gem_dumb_create(struct drm_file *file, struct drm_device *dev,
 			struct drm_mode_create_dumb *args)
 {
-	size_t pitch, size;
 	struct psb_gem_object *pobj;
 	struct drm_gem_object *obj;
-	u32 handle;
 	int ret;
 
-	pitch = args->width * DIV_ROUND_UP(args->bpp, 8);
-	pitch = ALIGN(pitch, 64);
-
-	size = pitch * args->height;
-	size = roundup(size, PAGE_SIZE);
-	if (!size)
-		return -EINVAL;
+	ret = drm_mode_size_dumb(dev, args, SZ_64, 0);
+	if (ret)
+		return ret;
 
-	pobj = psb_gem_create(dev, size, "gem", false, PAGE_SIZE);
+	pobj = psb_gem_create(dev, args->size, "gem", false, PAGE_SIZE);
 	if (IS_ERR(pobj))
 		return PTR_ERR(pobj);
 	obj = &pobj->base;
 
-	ret = drm_gem_handle_create(file, obj, &handle);
+	ret = drm_gem_handle_create(file, obj, &args->handle);
 	if (ret)
 		goto err_drm_gem_object_put;
 
 	drm_gem_object_put(obj);
 
-	args->pitch = pitch;
-	args->size = size;
-	args->handle = handle;
-
 	return 0;
 
 err_drm_gem_object_put:
-- 
2.48.1


  parent reply	other threads:[~2025-02-18 14:26 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18 14:23 [PATCH v3 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 01/25] drm/dumb-buffers: Sanitize output on errors Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size Thomas Zimmermann
2025-02-18 19:32   ` Geert Uytterhoeven
2025-02-19  8:08     ` Thomas Zimmermann
2025-02-20  9:18   ` Tomi Valkeinen
2025-02-20 10:05     ` Thomas Zimmermann
2025-02-20 10:53       ` Tomi Valkeinen
2025-02-21  9:19         ` Thomas Zimmermann
2025-02-21  9:57           ` Geert Uytterhoeven
2025-02-21 10:08             ` Thomas Zimmermann
2025-02-25 13:45           ` Tomi Valkeinen
2025-02-26 10:16             ` Thomas Zimmermann
2025-03-07  8:42   ` Simona Vetter
2025-03-07 13:19     ` Simona Vetter
2025-02-18 14:23 ` [PATCH v3 03/25] drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb() Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 04/25] drm/gem-shmem: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 05/25] drm/gem-vram: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 06/25] drm/armada: " Thomas Zimmermann
2025-02-18 15:57   ` Russell King (Oracle)
2025-02-19  8:09     ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 07/25] drm/exynos: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann [this message]
2025-02-18 14:23 ` [PATCH v3 09/25] drm/hibmc: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 10/25] drm/imx/ipuv3: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 11/25] drm/loongson: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 12/25] drm/mediatek: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 13/25] drm/msm: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 14/25] drm/nouveau: " Thomas Zimmermann
2025-02-20 22:17   ` Lyude Paul
2025-02-18 14:23 ` [PATCH v3 15/25] drm/omapdrm: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 16/25] drm/qxl: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 17/25] drm/renesas/rcar-du: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 18/25] drm/renesas/rz-du: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 19/25] drm/rockchip: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 20/25] drm/tegra: " Thomas Zimmermann
2025-03-06 19:26   ` Thierry Reding
2025-02-18 14:23 ` [PATCH v3 21/25] drm/virtio: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 22/25] drm/vmwgfx: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 23/25] drm/xe: " Thomas Zimmermann
2025-02-20 10:08   ` Matthew Auld
2025-02-18 14:23 ` [PATCH v3 24/25] drm/xen: " Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 25/25] drm/xlnx: " Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250218142542.438557-9-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=imx@lists.linux.dev \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=patrik.r.jakobsson@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=spice-devel@lists.freedesktop.org \
    --cc=virtualization@lists.linux.dev \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).