From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DCEE205ADA for ; Fri, 21 Feb 2025 11:41:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740138105; cv=none; b=cf47KIoaBNVWXGYLpMlU4y+BEhoeYUpLff5O9DbKT+gy/r2TlUOlNUMk1toz9gerb8c7inBbjepAukG33ONs1PJGfaPgbRUobWHFWjiQfgezZFOx6CiU5tpxPm2KHzaplMxtHAmCpQd4Qz1NUWKdxQ0ql4uLOzWu3jjBaX4Cpv0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740138105; c=relaxed/simple; bh=SvjxmZauslII2+Ca1ZFCYVVzR/2EOh8sGT3TqK6IOHk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RHQ0mTrjERVKIN2smkzUX7RCQgAXIzg3yZMy9k8XrrINeXJ17PhSuoxS3dv58SSGDmMwT+98eq4Z0i3aqatgcrhR3OqCGc05qdunReal+5KURszaEXuBW2jsJR6ea4PegOxwLdPuWgtlZFgQ3yUcAC4goGc6B1/U8CXNSY0WJNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iQaVvLe6; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iQaVvLe6" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4398ec2abc2so17206995e9.1 for ; Fri, 21 Feb 2025 03:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740138101; x=1740742901; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8Hjqn4Gzw1MqP1NTAwTa5QXz+1IZXGfOQwpEgvNl05E=; b=iQaVvLe6EXCJRQ/e+PtRn/wv+GbG+g8QQjl4lhK6QJGZfvGWZcQQb3L+c0UeLaajQk 5kzcCcXlVpoqHGrweGmwdDvlZjBM6+x7EI0I7zTL9t6LZYFOLCsuVYjXQoHBtUR1JyIb SgTTr+P5P0VZzPzRM+P8Z0li8J8Ii4ydf20j+uL5z+xCgLVpksVSyMKClM+rqnpLvxWi n7yqxoRXfeb4xqRXFBLjGdX3L5LKFNW5/WcpvoQZvp4X9hIrKurasKJn14G5GteA0+vA wCNpnjhtCGYw/7LY8Xf4g7a39VzVC6Mfxahlur5OAd9jB0mZ1cjIIbNJvKEgqL/gi49K s0FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740138101; x=1740742901; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Hjqn4Gzw1MqP1NTAwTa5QXz+1IZXGfOQwpEgvNl05E=; b=kPZT7rG6CUxVE8TxrWr67jgc7UUL79XfqpkIif55U5w+YNMyRFZREo6ah+13nZXHCj SfBvXttleS2gppveTB2dozIKUFH0o8AflhRsvC72WL3Rzi+6KsIOA1kUSxx7wnu2I9MR sUHj0wz7ftMBI3MQ0f/rh1RZw29HawwdhsI0vdjP5moPpw3VARFWyrfp8OdRukto/ZMn HFQ+9/NS+r+3AATKOvc8QTMFUZIZsNid4dETh+RTcEEXsbGvrDk8xXkSqXl/q9m4wWUi aX1iPIHDxZo5EP5xE+6l33TfK8oPbmQHRymZbQhQX8yhirGNU6TDba36W8dDZBc9AVEt MeMg== X-Forwarded-Encrypted: i=1; AJvYcCX039mFABrNt7C9XWK3YJB4oKMbHsMTY8hd+SKeSVHHZ/JE/Yju7ABHR8wXw7tEQ3Qar+MtSGHDxcYu/IK64A==@lists.linux.dev X-Gm-Message-State: AOJu0Yyd7SKkWqurqcZ4guM6dzaZ03j4QhsB33qgIH0c3Z2qySUNQwZx pqHj9ecElwnq3ZfcT2GXKL26QQvASQKB0iOjo5Pq7CBuSR/TkLeA8fDzN4irV6c= X-Gm-Gg: ASbGnctKzHACO7jKjWXqlLGVk5EJ7qJ4Es6+g1ystkyRoukCHwiMiNQx9wjQeMBVGpG CFlAzZ7wswYvlQ0HQxCeQoV9QACWx4nednN0W5kBPMI6RX6QR49AZuKBWM4x11Lknnd11mZ2VoJ fdsp17tmRuERVvG6nZPxsgbdd7nsTy+9d8tmD/jhtCkX+jkPrvF2jfh8CiqUrjK9U2ZbXKriEqp a126cLeFyAzIk7xkdtYUbK+zHA8mVs3ywLbKCMUz+V5YrkpmHo1YQRcwwxNTdiTykSkOs8wrBU8 8zySi2cG+t/UCY2xtmw9WFXC X-Google-Smtp-Source: AGHT+IFsNsE6nwYIxjV3tb1IOYQfAHzudn/bvPIeUKbaIvn1PvgigfMsE/xHa387zcqeYKxGoOg7pA== X-Received: by 2002:a05:600c:4590:b0:439:95b9:91fc with SMTP id 5b1f17b1804b1-439ae1e6e9emr24389505e9.12.1740138101489; Fri, 21 Feb 2025 03:41:41 -0800 (PST) Received: from myrica ([2.221.137.100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-439b02d5610sm14624925e9.11.2025.02.21.03.41.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Feb 2025 03:41:41 -0800 (PST) Date: Fri, 21 Feb 2025 11:42:06 +0000 From: Jean-Philippe Brucker To: Jason Gunthorpe Cc: Jacob Pan , iommu@lists.linux.dev, Joerg Roedel , Robin Murphy , virtualization@lists.linux.dev, Will Deacon , Eric Auger , patches@lists.linux.dev Subject: Re: [PATCH 0/5] Convert virtio-iommu to domain_alloc_paging() Message-ID: <20250221114206.GB719702@myrica> References: <0-v1-91eed9c8014a+53a37-iommu_virtio_domains_jgg@nvidia.com> <20250211164151.723cfce0@DESKTOP-0403QTC.> <20250212125007.GP3754072@nvidia.com> Precedence: bulk X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250212125007.GP3754072@nvidia.com> On Wed, Feb 12, 2025 at 08:50:07AM -0400, Jason Gunthorpe wrote: > On Tue, Feb 11, 2025 at 04:41:51PM -0800, Jacob Pan wrote: > > > I see the same on arm64 with v9.0, assigned an ixgbe nic via VFIO. > > Huh, I figured it worked on ARM.. Crosvm would be a more useful test because it doesn't implement any BYPASS feature, but I don't have it set up at the moment. It's not a problem on QEMU since it supports the BYPASS feature and doesn't need identity-mapped domains. > > There is no requirement that an iommu driver implement identity, this > is all an optimization. If it doesn't work in alot of cases can we > just remove it? It would simplfy a lot.. No objection. Identity domains are useful if the use-case of virtio-iommu is assigning devices to guest userspace, in which case you'd want to bypass the IOMMU for the devices that are still owned by the kernel. But VMMs have at least two alternatives to identity-mapping (BYPASS feature and tailored topology). Thanks, Jean