From: Jason Gunthorpe <jgg@nvidia.com>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
virtualization@lists.linux.dev, Will Deacon <will@kernel.org>,
Eric Auger <eric.auger@redhat.com>,
patches@lists.linux.dev
Subject: Re: [PATCH v2 3/5] iommu/virtio: Move to domain_alloc_paging()
Date: Mon, 3 Mar 2025 13:02:08 -0400 [thread overview]
Message-ID: <20250303170208.GA133783@nvidia.com> (raw)
In-Reply-To: <20250303152143.GA2083810@myrica>
On Mon, Mar 03, 2025 at 03:21:43PM +0000, Jean-Philippe Brucker wrote:
> On Thu, Feb 27, 2025 at 08:20:01PM -0400, Jason Gunthorpe wrote:
> > virtio has the complication that it sometimes wants to return a paging
> > domain for IDENTITY which makes this conversion a little different than
> > other drivers.
> >
> > Add a viommu_domain_alloc_paging() that combines viommu_domain_alloc() and
> > viommu_domain_finalise() to always return a fully initialized and
> > finalized paging domain.
> >
> > Use viommu_domain_alloc_identity() to implement the special non-bypass
> > IDENTITY flow by calling viommu_domain_alloc_paging() then
> > viommu_domain_map_identity().
> >
> > Remove support for deferred finalize and the vdomain->mutex.
> >
> > Remove core support for domain_alloc() IDENTITY as virtio was the last
> > driver using it.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
>
> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
>
> And my tests still pass (after fixing the build issue on patch 2)
Yeah, my mistake, my tree has a different fix for that in a followup
series :\ I will resend it
Thanks,
Jason
next prev parent reply other threads:[~2025-03-03 17:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 0:19 [PATCH v2 0/5] Convert virtio-iommu to domain_alloc_paging() Jason Gunthorpe
2025-02-28 0:19 ` [PATCH v2 1/5] iommu/virtio: Break out bypass identity support into a global static Jason Gunthorpe
2025-03-03 15:22 ` Jean-Philippe Brucker
2025-02-28 0:20 ` [PATCH v2 2/5] iommu: Add domain_alloc_identity() Jason Gunthorpe
2025-02-28 1:59 ` Baolu Lu
2025-02-28 14:31 ` Jason Gunthorpe
2025-02-28 0:20 ` [PATCH v2 3/5] iommu/virtio: Move to domain_alloc_paging() Jason Gunthorpe
2025-03-03 15:21 ` Jean-Philippe Brucker
2025-03-03 17:02 ` Jason Gunthorpe [this message]
2025-02-28 0:20 ` [PATCH v2 4/5] iommu: Do not call domain_alloc() in iommu_sva_domain_alloc() Jason Gunthorpe
2025-02-28 2:03 ` Baolu Lu
2025-02-28 0:20 ` [PATCH v2 5/5] iommu: Hide ops.domain_alloc behind CONFIG_FSL_PAMU Jason Gunthorpe
2025-02-28 2:04 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303170208.GA133783@nvidia.com \
--to=jgg@nvidia.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=virtualization@lists.linux.dev \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).