From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: netdev@vger.kernel.org, mkarsten@uwaterloo.ca,
gerhard@engleder-embedded.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, mst@redhat.com, leiyang@redhat.com,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"open list:VIRTIO CORE AND NET DRIVERS"
<virtualization@lists.linux.dev>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v5 3/4] virtio-net: Map NAPIs to queues
Date: Wed, 5 Mar 2025 18:21:18 -0800 [thread overview]
Message-ID: <20250305182118.3d885f0d@kernel.org> (raw)
In-Reply-To: <Z8j9i-bW3P-GOpbw@LQ3V64L9R2>
On Wed, 5 Mar 2025 17:42:35 -0800 Joe Damato wrote:
> Two spots that come to mind are:
> - in virtnet_probe where all the other netdev ops are plumbed
> through, or
> - above virtnet_disable_queue_pair which I assume a future queue
> API implementor would need to call for ndo_queue_stop
I'd put it next to some call which will have to be inspected.
Normally we change napi_disable() to napi_disable_locked()
for drivers using the instance lock, so maybe on the napi_disable()
line in the refill?
next prev parent reply other threads:[~2025-03-06 2:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 18:50 [PATCH net-next v5 0/4] virtio-net: Link queues to NAPIs Joe Damato
2025-02-27 18:50 ` [PATCH net-next v5 1/4] virtio-net: Refactor napi_enable paths Joe Damato
2025-02-27 18:50 ` [PATCH net-next v5 2/4] virtio-net: Refactor napi_disable paths Joe Damato
2025-02-27 18:50 ` [PATCH net-next v5 3/4] virtio-net: Map NAPIs to queues Joe Damato
2025-02-28 8:14 ` Jason Wang
2025-03-01 2:27 ` Jakub Kicinski
2025-03-03 16:46 ` Joe Damato
2025-03-03 17:00 ` Joe Damato
2025-03-03 18:33 ` Joe Damato
2025-03-04 0:03 ` Jakub Kicinski
2025-03-04 15:08 ` Joe Damato
2025-03-05 5:11 ` Jason Wang
2025-03-05 16:34 ` Joe Damato
2025-03-06 0:15 ` Jason Wang
2025-03-06 1:42 ` Joe Damato
2025-03-06 2:21 ` Jakub Kicinski [this message]
2025-03-06 17:00 ` Joe Damato
2025-03-06 18:21 ` Jakub Kicinski
2025-02-27 18:50 ` [PATCH net-next v5 4/4] virtio_net: Use persistent NAPI config Joe Damato
2025-02-28 14:39 ` [PATCH net-next v5 0/4] virtio-net: Link queues to NAPIs Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305182118.3d885f0d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=gerhard@engleder-embedded.com \
--cc=jasowang@redhat.com \
--cc=jdamato@fastly.com \
--cc=leiyang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).