From: Thomas Zimmermann <tzimmermann@suse.de>
To: simona@ffwll.ch, airlied@gmail.com, mripard@kernel.org,
maarten.lankhorst@linux.intel.com, geert@linux-m68k.org,
tomi.valkeinen@ideasonboard.com
Cc: dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
nouveau@lists.freedesktop.org, virtualization@lists.linux.dev,
spice-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Lyude Paul <lyude@redhat.com>, Karol Herbst <kherbst@redhat.com>,
Danilo Krummrich <dakr@kernel.org>
Subject: [PATCH v4 14/25] drm/nouveau: Compute dumb-buffer sizes with drm_mode_size_dumb()
Date: Tue, 11 Mar 2025 16:47:18 +0100 [thread overview]
Message-ID: <20250311155120.442633-15-tzimmermann@suse.de> (raw)
In-Reply-To: <20250311155120.442633-1-tzimmermann@suse.de>
Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
buffer size. Align the pitch to a multiple of 256.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: Danilo Krummrich <dakr@kernel.org>
---
drivers/gpu/drm/nouveau/nouveau_display.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau/nouveau_display.c
index add006fc8d81..daa2528f9c9a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -30,6 +30,7 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_client_event.h>
#include <drm/drm_crtc_helper.h>
+#include <drm/drm_dumb_buffers.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_gem_framebuffer_helper.h>
#include <drm/drm_probe_helper.h>
@@ -808,9 +809,9 @@ nouveau_display_dumb_create(struct drm_file *file_priv, struct drm_device *dev,
uint32_t domain;
int ret;
- args->pitch = roundup(args->width * (args->bpp / 8), 256);
- args->size = args->pitch * args->height;
- args->size = roundup(args->size, PAGE_SIZE);
+ ret = drm_mode_size_dumb(dev, args, SZ_256, 0);
+ if (ret)
+ return ret;
/* Use VRAM if there is any ; otherwise fallback to system memory */
if (nouveau_drm(dev)->client.device.info.ram_size != 0)
--
2.48.1
next prev parent reply other threads:[~2025-03-11 15:55 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 15:47 [PATCH v4 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 01/25] drm/dumb-buffers: Sanitize output on errors Thomas Zimmermann
2025-06-12 8:11 ` Tomi Valkeinen
2025-03-11 15:47 ` [PATCH v4 02/25] drm/dumb-buffers: Provide helper to set pitch and size Thomas Zimmermann
2025-06-12 8:36 ` Tomi Valkeinen
2025-06-13 7:02 ` Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 03/25] drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb() Thomas Zimmermann
2025-06-12 8:43 ` Tomi Valkeinen
2025-06-13 7:15 ` Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 04/25] drm/gem-shmem: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 05/25] drm/gem-vram: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 06/25] drm/armada: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 07/25] drm/exynos: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 08/25] drm/gma500: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 09/25] drm/hibmc: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 10/25] drm/imx/ipuv3: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 11/25] drm/loongson: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 12/25] drm/mediatek: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 13/25] drm/msm: " Thomas Zimmermann
2025-03-11 15:47 ` Thomas Zimmermann [this message]
2025-03-11 15:47 ` [PATCH v4 15/25] drm/omapdrm: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 16/25] drm/qxl: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 17/25] drm/renesas/rcar-du: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 18/25] drm/renesas/rz-du: " Thomas Zimmermann
2025-03-13 2:15 ` kernel test robot
2025-03-13 3:58 ` kernel test robot
2025-03-11 15:47 ` [PATCH v4 19/25] drm/rockchip: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 20/25] drm/tegra: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 21/25] drm/virtio: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 22/25] drm/vmwgfx: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 23/25] drm/xe: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 24/25] drm/xen: " Thomas Zimmermann
2025-03-11 15:47 ` [PATCH v4 25/25] drm/xlnx: " Thomas Zimmermann
2025-05-28 8:23 ` [PATCH v4 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250311155120.442633-15-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=imx@lists.linux.dev \
--cc=intel-xe@lists.freedesktop.org \
--cc=kherbst@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=spice-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=virtualization@lists.linux.dev \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox