From: Halil Pasic <pasic@linux.ibm.com>
To: Maximilian Immanuel Brandtner <maxbr@linux.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Amit Shah <amit@kernel.org>,
linux-kernel@vger.kernel.org, virtualization@lists.linux.dev,
arnd@arndb.de, gregkh@linuxfoundation.org,
brueckner@linux.ibm.com, schnelle@linux.ibm.com,
Halil Pasic <pasic@linux.ibm.com>
Subject: Re: [PATCH] virtio: console: Make resizing compliant with virtio spec
Date: Thu, 20 Mar 2025 11:41:20 +0100 [thread overview]
Message-ID: <20250320114120.383a706f.pasic@linux.ibm.com> (raw)
In-Reply-To: <fe72c90a59354f2507c1d528c4e5b8562b20a3e8.camel@linux.ibm.com>
On Thu, 20 Mar 2025 08:12:23 +0100
Maximilian Immanuel Brandtner <maxbr@linux.ibm.com> wrote:
> > Another thing I noticed during looking at this. AFAICT Linux does not
> > seem to handle endiannes here. And AFAIU the message is supposed to
> > hold
> > le16 that is little endian u16! Maximilian, is this in your opinion
> > something we need to fix as well? Or am I just missing the
> > conversion?
> >
> > Regards,
> > Halil
>
> Thanks, I didn't notice that, as I only tested this feature on x86. I
> double checked struct virtio_console_config as it also defines cols
> before rows, but there the kernel follows the spec (including
> endianness).
> I'll send a patch v2 shortly.
I can send a fix for the endiannes issue. It should be a separate
patch anyway.
Regards,
Halil
next prev parent reply other threads:[~2025-03-20 10:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 9:21 [PATCH] virtio: console: Make resizing compliant with virtio spec Maximilian Immanuel Brandtner
2025-03-03 11:54 ` Amit Shah
2025-03-05 9:53 ` Maximilian Immanuel Brandtner
2025-03-05 12:13 ` Niklas Schnelle
2025-03-05 12:15 ` Niklas Schnelle
2025-03-05 12:33 ` Maximilian Immanuel Brandtner
2025-03-10 13:04 ` Maximilian Immanuel Brandtner
2025-03-18 9:51 ` Amit Shah
2025-03-18 10:07 ` Maximilian Immanuel Brandtner
2025-03-18 14:25 ` Amit Shah
2025-03-19 8:54 ` Maximilian Immanuel Brandtner
2025-03-19 9:12 ` Amit Shah
2025-03-19 13:00 ` Maximilian Immanuel Brandtner
2025-03-19 15:00 ` Michael S. Tsirkin
2025-03-19 17:13 ` Halil Pasic
2025-03-19 21:21 ` Michael S. Tsirkin
2025-03-20 7:12 ` Maximilian Immanuel Brandtner
2025-03-20 10:41 ` Halil Pasic [this message]
2025-03-20 11:53 ` Maximilian Immanuel Brandtner
2025-03-20 14:09 ` Halil Pasic
2025-03-20 14:19 ` Halil Pasic
2025-03-20 17:19 ` Maximilian Immanuel Brandtner
2025-03-20 7:23 ` Maximilian Immanuel Brandtner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320114120.383a706f.pasic@linux.ibm.com \
--to=pasic@linux.ibm.com \
--cc=amit@kernel.org \
--cc=arnd@arndb.de \
--cc=brueckner@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=schnelle@linux.ibm.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).