* [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml
@ 2025-04-07 16:53 Rob Herring (Arm)
2025-04-08 7:35 ` Jean-Philippe Brucker
2025-04-17 12:49 ` Rob Herring (Arm)
0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-04-07 16:53 UTC (permalink / raw)
To: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Krzysztof Kozlowski, Conor Dooley, Jean-Philippe Brucker
Cc: virtualization, devicetree, linux-kernel
The virtio pci-iommu is a PCI device, so it should have a reference to
the pci-device.yaml schema. The pci-device.yaml schema defines the 'reg'
format as a schema, so the text description for 'reg' can be dropped.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../devicetree/bindings/virtio/pci-iommu.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/virtio/pci-iommu.yaml b/Documentation/devicetree/bindings/virtio/pci-iommu.yaml
index 972a785a42de..8bd6ad72ac7a 100644
--- a/Documentation/devicetree/bindings/virtio/pci-iommu.yaml
+++ b/Documentation/devicetree/bindings/virtio/pci-iommu.yaml
@@ -20,6 +20,9 @@ description: |
virtio-iommu node doesn't have an "iommus" property, and is omitted from
the iommu-map property of the root complex.
+allOf:
+ - $ref: /schemas/pci/pci-device.yaml#
+
properties:
# If compatible is present, it should contain the vendor and device ID
# according to the PCI Bus Binding specification. Since PCI provides
@@ -33,12 +36,7 @@ properties:
- const: pci1af4,1057
reg:
- description: |
- PCI address of the IOMMU. As defined in the PCI Bus Binding
- reference, the reg property is a five-cell address encoded as (phys.hi
- phys.mid phys.lo size.hi size.lo). phys.hi should contain the device's
- BDF as 0b00000000 bbbbbbbb dddddfff 00000000. The other cells should be
- zero. See Documentation/devicetree/bindings/pci/pci.txt
+ maxItems: 1
'#iommu-cells':
const: 1
--
2.47.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml
2025-04-07 16:53 [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml Rob Herring (Arm)
@ 2025-04-08 7:35 ` Jean-Philippe Brucker
2025-04-17 12:49 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Jean-Philippe Brucker @ 2025-04-08 7:35 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Michael S. Tsirkin, Jason Wang, Xuan Zhuo, Eugenio Pérez,
Krzysztof Kozlowski, Conor Dooley, virtualization, devicetree,
linux-kernel
On Mon, Apr 07, 2025 at 11:53:40AM -0500, Rob Herring (Arm) wrote:
> The virtio pci-iommu is a PCI device, so it should have a reference to
> the pci-device.yaml schema. The pci-device.yaml schema defines the 'reg'
> format as a schema, so the text description for 'reg' can be dropped.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
> ---
> .../devicetree/bindings/virtio/pci-iommu.yaml | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/virtio/pci-iommu.yaml b/Documentation/devicetree/bindings/virtio/pci-iommu.yaml
> index 972a785a42de..8bd6ad72ac7a 100644
> --- a/Documentation/devicetree/bindings/virtio/pci-iommu.yaml
> +++ b/Documentation/devicetree/bindings/virtio/pci-iommu.yaml
> @@ -20,6 +20,9 @@ description: |
> virtio-iommu node doesn't have an "iommus" property, and is omitted from
> the iommu-map property of the root complex.
>
> +allOf:
> + - $ref: /schemas/pci/pci-device.yaml#
> +
> properties:
> # If compatible is present, it should contain the vendor and device ID
> # according to the PCI Bus Binding specification. Since PCI provides
> @@ -33,12 +36,7 @@ properties:
> - const: pci1af4,1057
>
> reg:
> - description: |
> - PCI address of the IOMMU. As defined in the PCI Bus Binding
> - reference, the reg property is a five-cell address encoded as (phys.hi
> - phys.mid phys.lo size.hi size.lo). phys.hi should contain the device's
> - BDF as 0b00000000 bbbbbbbb dddddfff 00000000. The other cells should be
> - zero. See Documentation/devicetree/bindings/pci/pci.txt
> + maxItems: 1
>
> '#iommu-cells':
> const: 1
> --
> 2.47.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml
2025-04-07 16:53 [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml Rob Herring (Arm)
2025-04-08 7:35 ` Jean-Philippe Brucker
@ 2025-04-17 12:49 ` Rob Herring (Arm)
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2025-04-17 12:49 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: linux-kernel, Xuan Zhuo, Conor Dooley, virtualization,
Eugenio Pérez, Michael S. Tsirkin, Krzysztof Kozlowski,
devicetree, Jean-Philippe Brucker, Jason Wang
On Mon, 07 Apr 2025 11:53:40 -0500, Rob Herring (Arm) wrote:
> The virtio pci-iommu is a PCI device, so it should have a reference to
> the pci-device.yaml schema. The pci-device.yaml schema defines the 'reg'
> format as a schema, so the text description for 'reg' can be dropped.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../devicetree/bindings/virtio/pci-iommu.yaml | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-17 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 16:53 [PATCH] dt-bindings: virtio: pci-iommu: Add ref to pci-device.yaml Rob Herring (Arm)
2025-04-08 7:35 ` Jean-Philippe Brucker
2025-04-17 12:49 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).