[PATCH] drm/cirrus: Use non-hybrid PCI devres API

[PATCH] drm/cirrus: Use non-hybrid PCI devres API

[Philipp Stanner]

cirrus enables its PCI device with pcim_enable_device(). This,
implicitly, switches the function pci_request_regions() into managed
mode, where it becomes a devres function.

The PCI subsystem wants to remove this hybrid nature from its
interfaces. To do so, users of the aforementioned combination of
functions must be ported to non-hybrid functions.

Replace the call to sometimes-managed pci_request_regions() with one to
the always-managed pcim_request_all_regions().

Signed-off-by: Philipp Stanner <phasta@kernel.org>
---
 drivers/gpu/drm/tiny/cirrus-qemu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/cirrus-qemu.c b/drivers/gpu/drm/tiny/cirrus-qemu.c
index 52ec1e4ea9e5..1ff678e26aa1 100644
--- a/drivers/gpu/drm/tiny/cirrus-qemu.c
+++ b/drivers/gpu/drm/tiny/cirrus-qemu.c
@@ -681,7 +681,7 @@ static int cirrus_pci_probe(struct pci_dev *pdev,
 	if (ret)
 		return ret;
 
-	ret = pci_request_regions(pdev, DRIVER_NAME);
+	ret = pcim_request_all_regions(pdev, DRIVER_NAME);
 	if (ret)
 		return ret;
 
-- 
2.48.1

Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API

[Javier Martinez Canillas]

Philipp Stanner <phasta@kernel.org> writes:

Hello Philipp,

> cirrus enables its PCI device with pcim_enable_device(). This,
> implicitly, switches the function pci_request_regions() into managed
> mode, where it becomes a devres function.
>
> The PCI subsystem wants to remove this hybrid nature from its
> interfaces. To do so, users of the aforementioned combination of
> functions must be ported to non-hybrid functions.
>
> Replace the call to sometimes-managed pci_request_regions() with one to
> the always-managed pcim_request_all_regions().
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API

[Philipp Stanner]

On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
> Philipp Stanner <phasta@kernel.org> writes:
> 
> Hello Philipp,
> 
> > cirrus enables its PCI device with pcim_enable_device(). This,
> > implicitly, switches the function pci_request_regions() into
> > managed
> > mode, where it becomes a devres function.
> > 
> > The PCI subsystem wants to remove this hybrid nature from its
> > interfaces. To do so, users of the aforementioned combination of
> > functions must be ported to non-hybrid functions.
> > 
> > Replace the call to sometimes-managed pci_request_regions() with
> > one to
> > the always-managed pcim_request_all_regions().
> > 
> > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> > ---
> 
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> 

Who's in charge of applying this? Any objections with me just putting
it into drm-misc-next?

P.

Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API

[Javier Martinez Canillas]

Philipp Stanner <phasta@mailbox.org> writes:

Hello Philipp,

> On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
>> Philipp Stanner <phasta@kernel.org> writes:
>> 
>> Hello Philipp,
>> 
>> > cirrus enables its PCI device with pcim_enable_device(). This,
>> > implicitly, switches the function pci_request_regions() into
>> > managed
>> > mode, where it becomes a devres function.
>> > 
>> > The PCI subsystem wants to remove this hybrid nature from its
>> > interfaces. To do so, users of the aforementioned combination of
>> > functions must be ported to non-hybrid functions.
>> > 
>> > Replace the call to sometimes-managed pci_request_regions() with
>> > one to
>> > the always-managed pcim_request_all_regions().
>> > 
>> > Signed-off-by: Philipp Stanner <phasta@kernel.org>
>> > ---
>> 
>> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
>> 
>
> Who's in charge of applying this? Any objections with me just putting
> it into drm-misc-next?
>

Sure, go ahead.

> P.
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API

[Philipp Stanner]

On Thu, 2025-05-08 at 12:44 +0200, Javier Martinez Canillas wrote:
> Philipp Stanner <phasta@mailbox.org> writes:
> 
> Hello Philipp,
> 
> > On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
> > > Philipp Stanner <phasta@kernel.org> writes:
> > > 
> > > Hello Philipp,
> > > 
> > > > cirrus enables its PCI device with pcim_enable_device(). This,
> > > > implicitly, switches the function pci_request_regions() into
> > > > managed
> > > > mode, where it becomes a devres function.
> > > > 
> > > > The PCI subsystem wants to remove this hybrid nature from its
> > > > interfaces. To do so, users of the aforementioned combination
> > > > of
> > > > functions must be ported to non-hybrid functions.
> > > > 
> > > > Replace the call to sometimes-managed pci_request_regions()
> > > > with
> > > > one to
> > > > the always-managed pcim_request_all_regions().
> > > > 
> > > > Signed-off-by: Philipp Stanner <phasta@kernel.org>
> > > > ---
> > > 
> > > Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> > > 
> > 
> > Who's in charge of applying this? Any objections with me just
> > putting
> > it into drm-misc-next?
> > 
> 
> Sure, go ahead.

Applied, thx

> 
> > P.
> > 
>